Skip to content

Revert the ship-signal requirement for unmerged work (#52) - #56

Merged
bguidolim merged 1 commit into
mainfrom
bruno/relax-ship-signal
Oct 29, 2026
Merged

bguidolim merged 1 commit into
mainfrom
bruno/relax-ship-signal

Conversation

@bguidolim

Copy link
Copy Markdown
Collaborator

Why

Capture runs in the turn where a finding happens, and on a feature branch that is almost always before a PR exists. Requiring a PR or an explicit "this will ship" therefore skipped most learnings about branch work, and the closing-note prompt to supply the signal never led to a second capture.

This restores the earlier rule: a PR or ticket is enough to save unmerged work as pending. Memories from branches that never merge are left to memory-audit, which already drops pending work with no matching branch or PR, while a memory that shipped differently is now corrected by capture itself (#51).

Test plan

  • mcs sync, then on a ticket branch with no PR find a cause in new code and run continuous-learning → expect a memory with a **Pending:** line naming the ticket
  • Find a cause in code already on the default branch → expect it saved without Pending:, as before

- Count a PR or ticket as pending again, since capture runs before a PR usually exists
- Drop the closing-note line for skips caused by a missing ship signal
@bguidolim
bguidolim merged commit 05d6c02 into main Oct 29, 2026
5 checks passed
@bguidolim
bguidolim deleted the bruno/relax-ship-signal branch October 29, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant