Repository navigation
Conversation
…ved I/O UI Classify secondary source OFF, NEEDS_REMAP, DEGRADED, WAITING_FOR_PCM, and PCM_FLOW_OBSERVED from native reader and physical lease evidence; distinguish driver-open from actual primary consumption and from channel audibility. Project through existing native snapshot, add compact diagnostics to existing AUDIO I/O panel, and cover fail-closed transitions with portable tests. No second renderer, no new JS truth owner, no hardware FAT claim.
…osing UI readback Keep IO-3A native status and approved AUDIO I/O diagnostics while merging exact parent #825 save/autosave P1 fix and its negative tests. No force push or unqualified ASIO hardware claims.
Deploying arsonmix with
|
| Latest commit: |
e9d6797
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://00c28d9a.arsonmix.pages.dev |
| Branch Preview URL: | https://feat-io3-secondary-capture-r.arsonmix.pages.dev |
|
Local cross-track rehearsal with #828 and #829 merged cleanly at the source level. #829 + #828 passed 242/242 focused contracts. Adding #830 (observed |
… is rebuilt from same source
|
@codex review |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e54d647926
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rement P1 fix Preserve exact parent lifecycle gates for CLEAR PATCH/diagnostic/new primary graph and layer the independent B status only into CONTROL readback. No force push or extra DSP/PCM owner.
…g pulls, before flow readback
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…t installed ChannelId graph
…ole ACK/readback dispatcher
…icate pins and rejected unsafe routes
…ng native capture intent Preserve approved G-MV bridge and tests from main plus parent IO-2D revisions. Keep IO-3A truthful native ASRC readback and IO-3B typed control decoder+ACK tests as the only child delta. No force push, no hardware FAT claim.
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…d roster revisions
…guard in single dispatcher
…-only .smix restore and G-MV35 Keep IO3A secondary capture flow evidence and IO3B native intent decoder/ACK while adopting parent protected A-only session restore, map transition safeguards and Windows/GUI baseline. No force push, no new render owner or user-visible fake LIVE.
…B-source ChannelId
…matched MAIN target
…implemented UI/persistence gates
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ice Apply and IO-2D host Use exact parent tree including merged N-MOD coordinator/rollback changes, inject only existing typed secondary-capture v8 control and readback into the single native Main/Engine files, and retain parent .smix A-only restoration tests. No duplicated control graph, no force push.
…snapshot Fix native install ACK always being rejected because LiveAudioEngine B status was not projected to approvedNativeSnapshot. Publish only engine-issued CONTROL status in the existing v8 snapshot and test positive/negative identity projection without manufacturing PCM/audibility.
…moval and chunked ASIO admission Forward exact parent IO-2D leases/FX and restart regression while preserving IO-3A truthful priming/status projection and IO-3B typed control requestId ACK in one G-MV/N-MOD-approved console. No force push; downstream UI/persistence/hardware FAT are still gated.
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…sole v8 controller
…poch/lease readback
…aining picker gap
…advertised capability
…d readback policy matrix
…or optimistic PCM
… Device B control
…-2E epoch recovery
|
INT-1 IO-3 child plan: #837 |
IO-3A/IO-3B — typed native secondary ASIO capture + truthful readback
HEAD:
d702d019b0fef7dfa747c348bb96eeb91f16fd65— stacked on native host PR #825. DRAFT. NOT MERGED. NOT A USER-FACING FEATURE OR PHYSICAL HARDWARE FAT.Delivered in source
integration/QualifiedCaptureConsoleIntent.hdecodesINSTALL_SECONDARY_CAPTUREinside the existing native v8arMixConsoleIntentrequestId / deviceEpoch / graphRevision / rosterRevision transport. Exact 64-bit ChannelId, target bound to B, verified PRIMARY/SECONDARY physical source masks, sorted B pins, supported rate/period, unique input ChannelIds and explicit operator consent; reject stale/invalid requests before driver open.src/Main.cpp::handleApprovedNativeControlroutes the single validated command to the existingLiveAudioEngine::installSecondaryAsioCapture()and emits the samearMixConsoleAck. B driver-open alone does not authorize ACK: readback must verify actual class/pin-mask, device lease, epoch and graph/roster revision. Output permission remains DISARMED andproductionCallbackLive/sourceAudibleProvenare always false.engine/device/SecondaryCaptureReadbackState.handLiveAudioEngine::status()report NOT_CONFIGURED/NEEDS_REMAP/DEGRADED/WAITING_FOR_PCM/PCM_FLOW_OBSERVED, actual B mask/rates/period/lease, ASRC priming and underflow. Flow requires fresh independent producer and usable FIR output; no false positive from authorized priming-only pulls. Project through the one authoritativeMain.cpp::approvedNativeSnapshot.tests/approved_native_v8_projection_test.cppcover approved canonical request, uint64 IDs, opaque session requestId, B target and role, stale revisions, duplicate/unsorted pins, unsupported format, wrong mask/MAIN target. Real ASRC priming and stall/lease failures tested intests/io2/QualifiedSecondaryCaptureReaderCases.h..smixrestore: parent #825 now guards unsavable dual-device v1 checkpoint and explicitly permits only muted saved A-only restoration without retaining the stale B map. No second DSP/FX processor or WebView transport.Verified and blockers
@codex reviewrequested on current HEAD; do not assume old clean review covers latest changes. Full Windows MSVC/CTest for this child NOT YET RUN.mainGUI bridge. Filed exact evidence in cross-thread #699; not hidden or bypassed.web/approved-native-contract.js::readbackProvesIntentdoes not yet support this operation; canonical/preview/generated assets must be rebuilt and tested together in IO-3C. Earlier experimental UI change was reverted; no phantom LIVE picker..smixSave/autosave safely rejects while qualified B installed rather than destroying the recoverable checkpoint. No real simultaneous two-vendor ASIO FAT, no independent BUS/CH physical sink, no installer claim.Next gate: parent #825 protected Windows+Codex+Required Merge Gate, then merge parent; retarget/requalify this child to latest main, implement approved GUI later readback and durable device bindings before any user-facing LIVE capability.