Skip to content

refactor(native N-MOD-15): isolate atomic Player setlist repository - #802

Merged
masarray merged 3 commits into
refactor/native-mv14-player-setlist-archive-20261119from
refactor/nmod15-player-setlist-repository-20261119
Nov 19, 2026
Merged

masarray merged 3 commits into
refactor/native-mv14-player-setlist-archive-20261119from
refactor/nmod15-player-setlist-repository-20261119

Conversation

@masarray

@masarray masarray commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

N-MOD-15 — durable Player repository boundary

Dependency: N-MOD-14 #799 must pass full JUCE Windows CTest and merge first. This branch starts from #799 exact head 46ee0b4825d708fc9aee38c14a2a22cfa67085c5; currently stacked by design and not merge-ready.

Real ownership removed

  • Remove player-library.json JSON parse/read, JUCE TemporaryFile staging and atomic commit from ConsoleWindow::restorePlayerLibrary/persistPlayerLibrary.
  • Add one src/PlayerSetlistRepository.h on CONTROL thread, composing the pure PlayerSetlistArchive (v1/v2/v3 codec) with just one disk I/O admission boundary.
  • ConsoleWindow retains single Player deck, song/set activation, engine stop/advance, user error text and native ACK/readback. No new PCM graph, no second owner, no new writer thread.

Behavioral regression (real disk)

Extend the existing JUCE Player archive CTest (no new Windows workflow) with isolated temporary directory: missing archive, accepted Save→Open + song controls, invalid Save preserving original bytes, impossible parent yielding deterministic I/O failure with no clobber, corrupt JSON preserving its bytes, recovery and 2,000-track Save→Open. Source contract forbids direct JSON/TemporaryFile operations in the Main persistence methods.

CI/merge

Exact initial head 10906be36a8c27a0c3b45d1287be195675b98248. Quick Native source checks auto-trigger; Windows JUCE/CTest NOT YET RUN on this milestone. Do not run expensive CI until N-MOD-14 is accepted on main, then reconcile with any concurrently merged G-MV changes, validate exact SHA, and request one Native lane. Physical ASIO FAT, installer and live audio behavior not qualified.

Exact-head source qualification — 10906be

  • Native fast-source contracts PASS, catalog/YAML shape guard PASS, Codex code review COMPLETED / zero findings on this exact SHA.
  • PR was retargeted to parent N-MOD-14 branch until refactor(native N-MOD-14–18): durable Player transactions, library plans and state projection #799 merges; only four diff files now: src/Main.cpp, src/PlayerSetlistRepository.h, tests/player_setlist_archive_test.cpp, tests/native_caption_wire_geometry_contract.test.cjs.
  • Real I/O regression source is committed, but Windows JUCE 8 CTest NOT RUN for N-MOD-15; current source checks do not certify actual disk operations under Windows. Draft remains NOT MERGED, no installer or hardware FAT.

N-MOD-15 exact-branch checkpoint — 2026-11-19

  • Current draft HEAD: 475ca9b98ef94b786cdfae100837e5f9c6f31dec; stacked strictly on N-MOD-14 95f40e77f4d462812663e974f728bc519f6071a3 (not default main). Comparison to base contains only four files: src/Main.cpp, src/PlayerSetlistRepository.h, tests/native_caption_wire_geometry_contract.test.cjs, tests/player_setlist_archive_test.cpp. No force push; latest concurrent G-MV device/channel-strip source preserved.
  • Fast Native PASS, catalog/owner/source guard PASS, exact-head Codex code review completed with zero findings. Prior Windows CTest validates parent N-MOD-14 only, NOT N-MOD-15.
  • Scope remains remove actual JSON disk read and atomic staging writer from ConsoleWindow, composing pure PlayerSetlistArchive through PlayerSetlistRepository. Real isolated disk tests cover Save/Open, failed writes and corrupt JSON, 2,000-song boundaries. No additional DSP, playback deck, PCM callback, GUI component or new device manager.
  • Keep draft until parent refactor(native N-MOD-14–18): durable Player transactions, library plans and state projection #799 is approved and merged. Afterwards reconcile the four intended modifications against latest main and run one exact SHA Windows MSVC/CTest, then protected gate before merging.

Move durable v1/v2/v3 Player JSON load/validation and atomic staged write from ConsoleWindow into control-only PlayerSetlistRepository. Preserve exact missing/invalid/I/O status text, deck/selection/native PCM ownership and Save/Open shape. Add real filesystem CTest for corrupt JSON, failed write, no clobber on invalid Save and 2k-song recovery.

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact N-MOD-15 HEAD 10906be36a8c27a0c3b45d1287be195675b98248 against parent #799 46ee0b4825d708fc9aee38c14a2a22cfa67085c5. Check JUCE 8 C++20 compile/runtime on Windows: juce::TemporaryFile atomic save, missing/corrupt file handling, juce::File::createDirectory().wasOk(), real I/O failure with file-as-parent, deterministic cleanup, and storage-error UI behavior parity. Verify moved responsibility genuinely removed from Main, one CONTROL owner, no new PCM/GUI logic or media deletion. This is draft/stacked and not eligible to merge before #799. Please report specific real bugs, not style-only concerns.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T00:43:57.734993Z 475ca9b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 475ca9b
Status: ✅  Deploy successful!
Preview URL: https://a4787951.arsonmix.pages.dev
Branch Preview URL: https://refactor-nmod15-player-setli.arsonmix.pages.dev

View logs

@masarray
masarray changed the base branch from main to refactor/native-mv14-player-setlist-archive-20261119 November 18, 2026 22:55
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 10906be36a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…nd N-MOD-14

Preserve exactly four Player repository/source/test edits atop N-MOD-14 and latest G-MV device lifecycle. No GUI bridge overwrite or new PCM owner; keep draft until parent gate and exact Windows CTest.

Copy link
Copy Markdown
Owner Author

@codex review

Please review exact integrated N-MOD-15 draft HEAD ffd74647e58ffc7a0e8524d743943139a50e93d3 against current parent #799 d78985ebe24cad4ebd2e33cc609958361d1d12da: only four Player persistence files should differ. Verify JUCE 8 header compile, std::optional move, juce::TemporaryFile existing good-content preservation on failed write, corrupt JSON handling, test sandbox behavior, exact ConsoleWindow user error parity, and no second PCM/GUI/accepted-state owner. This revision reconciled disjoint G-MV changes; the earlier #802 source review found zero findings. This is draft pending #799 protected merge and its own Windows CTest.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: ffd74647e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Preserve exactly four N-MOD-15 Player repository/CTest/contract changed files, all G-MV view-model and bridge changes from main, and Windows qualified N-MOD-14 code. No force push and no extra PCM authority.

Copy link
Copy Markdown
Owner Author

@codex review

Inspect exact current head 475ca9b98ef94b786cdfae100837e5f9c6f31dec of N-MOD 15 after disjoint parallel G-MV merge. Previous exact code head passed Codex with zero findings; the current commit adds only parent integration with no changed Native file blobs. Verify no lost G-MV changes, no UI or PCM owner overlap, correct Player archive/repository and finite cue contracts, CMake/CTest, native ACK/readback. Report real correctness bugs; never sign off a Windows run that was not performed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 475ca9b98e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masarray
masarray merged commit 94672b2 into refactor/native-mv14-player-setlist-archive-20261119 Nov 19, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant