Repository navigation
refactor(native N-MOD-15): isolate atomic Player setlist repository - #802
Conversation
Move durable v1/v2/v3 Player JSON load/validation and atomic staged write from ConsoleWindow into control-only PlayerSetlistRepository. Preserve exact missing/invalid/I/O status text, deck/selection/native PCM ownership and Save/Open shape. Add real filesystem CTest for corrupt JSON, failed write, no clobber on invalid Save and 2k-song recovery.
|
@codex review Please review exact N-MOD-15 HEAD |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
475ca9b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a4787951.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-nmod15-player-setli.arsonmix.pages.dev |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…nd N-MOD-14 Preserve exactly four Player repository/source/test edits atop N-MOD-14 and latest G-MV device lifecycle. No GUI bridge overwrite or new PCM owner; keep draft until parent gate and exact Windows CTest.
|
@codex review Please review exact integrated N-MOD-15 draft HEAD |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Preserve exactly four N-MOD-15 Player repository/CTest/contract changed files, all G-MV view-model and bridge changes from main, and Windows qualified N-MOD-14 code. No force push and no extra PCM authority.
|
@codex review Inspect exact current head |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
94672b2
into
refactor/native-mv14-player-setlist-archive-20261119
N-MOD-15 — durable Player repository boundary
Dependency: N-MOD-14 #799 must pass full JUCE Windows CTest and merge first. This branch starts from #799 exact head
46ee0b4825d708fc9aee38c14a2a22cfa67085c5; currently stacked by design and not merge-ready.Real ownership removed
player-library.jsonJSON parse/read, JUCE TemporaryFile staging and atomic commit fromConsoleWindow::restorePlayerLibrary/persistPlayerLibrary.src/PlayerSetlistRepository.hon CONTROL thread, composing the purePlayerSetlistArchive(v1/v2/v3 codec) with just one disk I/O admission boundary.ConsoleWindowretains single Player deck, song/set activation, engine stop/advance, user error text and native ACK/readback. No new PCM graph, no second owner, no new writer thread.Behavioral regression (real disk)
Extend the existing JUCE Player archive CTest (no new Windows workflow) with isolated temporary directory: missing archive, accepted Save→Open + song controls, invalid Save preserving original bytes, impossible parent yielding deterministic I/O failure with no clobber, corrupt JSON preserving its bytes, recovery and 2,000-track Save→Open. Source contract forbids direct JSON/TemporaryFile operations in the Main persistence methods.
CI/merge
Exact initial head
10906be36a8c27a0c3b45d1287be195675b98248. Quick Native source checks auto-trigger; Windows JUCE/CTest NOT YET RUN on this milestone. Do not run expensive CI until N-MOD-14 is accepted on main, then reconcile with any concurrently merged G-MV changes, validate exact SHA, and request one Native lane. Physical ASIO FAT, installer and live audio behavior not qualified.Exact-head source qualification — 10906be
src/Main.cpp,src/PlayerSetlistRepository.h,tests/player_setlist_archive_test.cpp,tests/native_caption_wire_geometry_contract.test.cjs.N-MOD-15 exact-branch checkpoint — 2026-11-19
475ca9b98ef94b786cdfae100837e5f9c6f31dec; stacked strictly on N-MOD-1495f40e77f4d462812663e974f728bc519f6071a3(not default main). Comparison to base contains only four files:src/Main.cpp,src/PlayerSetlistRepository.h,tests/native_caption_wire_geometry_contract.test.cjs,tests/player_setlist_archive_test.cpp. No force push; latest concurrent G-MV device/channel-strip source preserved.PlayerSetlistArchivethroughPlayerSetlistRepository. Real isolated disk tests cover Save/Open, failed writes and corrupt JSON, 2,000-song boundaries. No additional DSP, playback deck, PCM callback, GUI component or new device manager.