Repository navigation
refactor(g-mv21): first-ACK-wins and readback-authoritative Device Setup - #803
Conversation
… after installed readback
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/arsonmix-ci ui 53e83d6 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53e83d634e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Deploying arsonmix with
|
| Latest commit: |
4431f8c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b641c607.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-g-mv21-ack-once-dev.arsonmix.pages.dev |
|
/arsonmix-ci ui 4431f8c |
G-MV21 — Owner completion / continuity (19 Nov 2026, WIB)Hasil terlihat oleh operator: Device Setup does not lose a pending accepted Apply due to duplicate/reordered ACKs. An ACK cannot fake installed physical I/O inventory. The DEVICE READY status uses installed schema-v6 readback. On both successful and terminal failed Apply (including Status nyata: MERGED MAIN as squash commit Bukti per exact source SHA:
Aman dipakai? YA for the merged source-level GUI transaction reliability path with all pre-merge checks passed. BELUM a newly packaged Windows installer, physical ASIO field FAT, or dual-vendor device validation. These are separate gates and were NOT RUN. Tindakan Anda: TIDAK PERLU MELAKUKAN APA-APA. Next G-MV: investigate queued Source and Device Setup transaction UI lifecycle under reconnect, confirm one owner and remove actual remaining bridge-side responsibilities with targeted tests, not cosmetic splitting. Preserve one native PCM renderer, ChannelId/EdgeId/ACK/readback, M4 first-sound, existing approved |
G-MV21 — Reliable, idempotent GUI-native transaction boundaries
Operator bug prevented: A duplicate
arMixAudioDeviceApplyAckfor the same request could replace a previously accepted Device Setup ACK whileVERIFYING, incorrectly rejecting/closing the transaction. The existing bridge could also copy an unverifiedack.activeinto its installed device inventory, including rejected driver output, before the actual schema-v6 readback. The single schema-v6 controller had the same duplicate-ACK revision overwrite bug.Implementation
ACCEPTEDACK is immutable until the next independently accepted PCM readback; later duplicate accepted, rejected, malformed, or wrong-epoch ACKs are ignored without resubscribing or changing pending revision.setupAck()accepts a correlated first ACK only inAPPLYING.VERIFYINGcan resolve only on native installed v6 hardware readback or explicit bounded timeout; duplicates cannot hijack the lease.ack.activeno longer mutates the displayed inventory, regardless of success/error. The operator's DEVICE READY notification derives from installednext.deviceverified readback. A fresh nativeaudioDeviceInventoryrefresh is requested only after actual ACCEPTED installation, never from ACK alone.No UI/CSS/layout change. No new transport, renderer, controller, optimistic PCM graph, output auto-ARM or .smix rewrites. Preserve one JUCE VST3/PCM render graph, existing
/preview/, ChannelId/EdgeId, pending source queues and M4 first-sound behavior.Base audited:
225623b06f8231ed4b8dd21634f9e8990dbee20d(G-MV20 merged). Validate Fast UI/Native on PR, exact-SHA Full Chromium, required merge gate, then only merge if clean and all checks pass. No new Windows installer or physical ASIO FAT claimed.