Skip to content

refactor(g-mv21): first-ACK-wins and readback-authoritative Device Setup - #803

Merged
masarray merged 4 commits into
mainfrom
refactor/g-mv21-ack-once-device-inventory-readback-20261119
Nov 18, 2026
Merged

masarray merged 4 commits into
mainfrom
refactor/g-mv21-ack-once-device-inventory-readback-20261119

Conversation

@masarray

Copy link
Copy Markdown
Owner

G-MV21 — Reliable, idempotent GUI-native transaction boundaries

Operator bug prevented: A duplicate arMixAudioDeviceApplyAck for the same request could replace a previously accepted Device Setup ACK while VERIFYING, incorrectly rejecting/closing the transaction. The existing bridge could also copy an unverified ack.active into its installed device inventory, including rejected driver output, before the actual schema-v6 readback. The single schema-v6 controller had the same duplicate-ACK revision overwrite bug.

Implementation

  • One v6 native intent controller: first correlated native ACCEPTED ACK is immutable until the next independently accepted PCM readback; later duplicate accepted, rejected, malformed, or wrong-epoch ACKs are ignored without resubscribing or changing pending revision.
  • Pure Device Setup ViewModel: setupAck() accepts a correlated first ACK only in APPLYING. VERIFYING can resolve only on native installed v6 hardware readback or explicit bounded timeout; duplicates cannot hijack the lease.
  • One approved WebView bridge: native ack.active no longer mutates the displayed inventory, regardless of success/error. The operator's DEVICE READY notification derives from installed next.device verified readback. A fresh native audioDeviceInventory refresh is requested only after actual ACCEPTED installation, never from ACK alone.
  • Regressions: v6 duplicate stale/negative/changed revision ACK and exact subsequent readback; Device Setup duplicate negative/wrong endpoint/mask/generation and real installed readback; bridge source audit prevents ACK-to-inventory mutation and verifies the admitted-only refresh.

No UI/CSS/layout change. No new transport, renderer, controller, optimistic PCM graph, output auto-ARM or .smix rewrites. Preserve one JUCE VST3/PCM render graph, existing /preview/, ChannelId/EdgeId, pending source queues and M4 first-sound behavior.

Base audited: 225623b06f8231ed4b8dd21634f9e8990dbee20d (G-MV20 merged). Validate Fast UI/Native on PR, exact-SHA Full Chromium, required merge gate, then only merge if clean and all checks pass. No new Windows installer or physical ASIO FAT claimed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T23:02:43.940775Z 53e83d6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 53e83d6

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 53e83d634e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/approved-native-bridge.js Resolved
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4431f8c
Status: ✅  Deploy successful!
Preview URL: https://b641c607.arsonmix.pages.dev
Branch Preview URL: https://refactor-g-mv21-ack-once-dev.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 4431f8c

@masarray
masarray merged commit 520d50d into main Nov 18, 2026
29 checks passed

Copy link
Copy Markdown
Owner Author

G-MV21 — Owner completion / continuity (19 Nov 2026, WIB)

Hasil terlihat oleh operator: Device Setup does not lose a pending accepted Apply due to duplicate/reordered ACKs. An ACK cannot fake installed physical I/O inventory. The DEVICE READY status uses installed schema-v6 readback. On both successful and terminal failed Apply (including NEEDS_REMAP), the one existing native Audio I/O inventory is explicitly re-read; this preserves generation-scoped retained-pin recovery and prevents operator settings from being stranded.

Status nyata: MERGED MAIN as squash commit 520d50d932b863765a56ad25b8a15c95213e7a3d; PR #803 closed and merged. Qualified exact source HEAD 4431f8ce467249d54afd5126039c8a83d9ec4843. No layout, CSS, PCM, VST3, driver or .smix changes.

Bukti per exact source SHA:

Aman dipakai? YA for the merged source-level GUI transaction reliability path with all pre-merge checks passed. BELUM a newly packaged Windows installer, physical ASIO field FAT, or dual-vendor device validation. These are separate gates and were NOT RUN.

Tindakan Anda: TIDAK PERLU MELAKUKAN APA-APA.

Next G-MV: investigate queued Source and Device Setup transaction UI lifecycle under reconnect, confirm one owner and remove actual remaining bridge-side responsibilities with targeted tests, not cosmetic splitting. Preserve one native PCM renderer, ChannelId/EdgeId/ACK/readback, M4 first-sound, existing approved /preview/, safe physical output, and no output auto-arm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant