Repository navigation
refactor(g-mv23): skip verified SOURCE duplicates after timeout/readback - #805
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
/arsonmix-ci ui 11d713c |
Deploying arsonmix with
|
| Latest commit: |
11d713c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ab1f8444.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-g-mv23-source-verif.arsonmix.pages.dev |
G-MV23 — Final owner handoff (19 Nov 2026 WIB)1. Hasil nyata untuk operator: Antrean SOURCE/INPUT yang terakhir dipilih tidak lagi mengeluarkan native routing command bila pilihan tersebut SUDAH TERBUKTI terpasang melalui readback PCM yang diterima. Ini menghindari pengiriman SOURCE kedua akibat ACK/readback balapan atau timeout 8 detik. Bila permintaan sebelumnya ditolak dan SOURCE belum terpasang, pilihan terbaru tetap diproses menggunakan graph/M4 revision dari readback terbaru; tidak menghapus retry yang sah. ChannelId dan M4 mempertahankan validasi epoch, canonical hardware fingerprint, pin format, serta jalur M4 first-sound. 2. Status: MERGED MAIN. PR #805 squash merge commit 3. Aman dipakai? YA untuk source GUI hasil merge yang lulus pemeriksaan sebelum merge. BUKAN klaim installer Windows baru siap diuji, hardware ASIO FAT sudah lulus, atau multi-ASIO capture tersedia. Tidak mengubah DSP, driver, VST3, .smix, tampilan 4. Owner action: TIDAK PERLU MELAKUKAN APA-APA untuk milestone code ini. 5. Bukti exact SHA:
6. Next G-MV: audit SOURCE queue fairness and reconnect UI expiration; consolidate duplicated retained-graph transient cleanup with one pure ViewModel decision while preserving valid |
G-MV23 — Verified SOURCE idempotence and efficient queue recovery
Root issue: WebView's shared ChannelId/M4 SOURCE queue previously sent every valid queued edit, even when an earlier SOURCE transaction had actually installed that very same physical input. During rapid operator changes, an ACK/readback race or timeout can leave a follow-up draft equal to accepted PCM. The bridge would then issue a redundant native routing command. Canceling at selection time is unsafe: an initially rejected command must leave the latest operator choice retryable from a fresh revision.
Changes
Only the existing Channel Strip ViewModel, approved WebView bridge, and Node contract test change. No second controller, DSP/PCM owner, driver, VST3, .smix persistence, UI redesign, output auto-arm or N-MOD touch. Keep the ONE approved /preview/.
Fast UI/native, exact-SHA Full Chromium and fail-closed Required Merge Gate before merge. Installer and physical ASIO FAT are separate and not claimed.