Repository navigation
refactor(mv9): pure scalar gesture, M4 ACK and installed readback Channel Strip VM - #787
Conversation
|
/arsonmix-ci ui e8f3b5d |
e8f3b5d to
d4a5feb
Compare
|
/arsonmix-ci ui d4a5feb |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
OWNER DELIVERY — MV-9 scalar Channel Strip ViewModel (2026-11-18)HASIL BAGI OPERATOR: Fader/PAN interaction retains the most recent local visual target only until independently installed accepted PCM readback, not merely an ACK. Incorrect native ChannelId or device epoch drops the pending visual instead of controlling the wrong strip. Each M4 channel's fader/PAN/MUTE/SOLO and MAIN gain uses one correlated native requestId/epoch/routing revision, then waits for the matching installed readback. Invalid nonfinite gesture values cannot enter pending native scalar queue. Existing native 30ms coalesced/released gesture, per-channel M4 timeout, one control dispatcher, offline .smix scalar edit and approved GUI layout remain unchanged. STATUS: MERGED MAIN. PR #787 squash commit BUKTI: Fast UI PASS, Fast Native PASS, all 9 new scalar tests PASS, exact-HEAD Full Chromium #44261475739 PASS 109/109 steps, including Stage C screenshot CSS parity, WIRE/FX/GAIN/fader/device browser controls and Firefox smoke; required commit status AMAN DIPAKAI? YA for the source-GUI control policy qualified by tests and merged. BELUM as a freshly built Windows installer, a new public release, or physical ASIO/multi-interface hardware FAT (all NOT RUN). No UI layout/HTML/CSS/PNG, native JUCE DSP/PCM, plugin, or .smix changes. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. NEXT: continue scoped MVVM only where it removes real domain policy from the remaining GUI bridge (e.g. per-channel scalar coalescing/pending scheduling and device/identity lifecycle), without duplicate state stores, render authority or approved |
MV-9 — Channel Strip scalar transaction boundary, one native PCM owner
Base:
main@8c8a87002b33d3fa2ffa9758fd3d6aa66f7ab23e(MV-8 #785 merged). Parallel active FX PR #786 changes separate FX functions and does not own this native scalar policy.What was unsafe/hard to maintain
The 4k-line approved bridge still implemented exact native gesture identity, fader target visual settling, M4 ACK correlation, and M4 independently observed physical fader/PAN/MUTE/SOLO/MAIN readback itself. Those are pure domain rules and had no isolated contract tests; reviewing pending retransmits required walking many disparate UI callbacks.
Implemented — 4 scoped files
web/approved-channel-strip-view-model.js: purescalarIdentityMatches,scalarVisualSettlement,m4ScalarAckResult,m4ScalarReadbackSettlement. Each compares identity/revisions exactly as native supplied, requires native ACK + independent matching readback, does not optimize or mutate the installed mixer model. ChannelId/device epoch stays an opaque exact decimal string even >JS-safe integer.web/approved-native-bridge.js: existing only pending Maps, nativearMixActiontransport, subscriptions, timers and pending visual cap. Calls the pure decisions at 4 existing seams; rejects nonfinite fader/PAN gesture before queuing. Preserves per-channel M4 ACK timeout, last-writer-wins pointer gestures, 30ms coalescing, existing M4 native MAIN, exactly one callback. No new ViewModel/controller/parallel PCM/session store.tests/approved_scalar_view_model_contract.test.cjs: 9 deterministic contract tests for huge identities, stale channel/epoch, visual display-only readback, ACK matching and supersession, M4 routes/authority changes, per-channel fader/PAN tolerance, MUTE/SOLO booleans, MAIN original M4 revision, and single actual bridge transport..github/workflows/ui-smoke.yml: run new independent contracts in fast UI and full exact-HEAD Chromium, with trigger path, not a dead test file.Product invariants: one approved
/preview/, one JUCE native accepted ChannelId/EdgeId PCM/VST3 engine, no JS audio, no changes to hardware/device pin, JUCE/C++, ASIO/DSP, FX Rack design, .smix, HTML/CSS/PNG or installer. Native ACK never proves producer-installed fader; logical offline editor still persists only released scalar target.Status: KODE DIBUAT; draft until Fast UI/full Chromium/required merge gate. Windows installer and real ASIO hardware FAT NOT RUN. No owner action required.