Skip to content

refactor(mv9): pure scalar gesture, M4 ACK and installed readback Channel Strip VM - #787

Merged
masarray merged 1 commit into
mainfrom
refactor/mv9-scalar-control-readback-view-model-20261118
Nov 18, 2026
Merged

masarray merged 1 commit into
mainfrom
refactor/mv9-scalar-control-readback-view-model-20261118

Conversation

@masarray

Copy link
Copy Markdown
Owner

MV-9 — Channel Strip scalar transaction boundary, one native PCM owner

Base: main@8c8a87002b33d3fa2ffa9758fd3d6aa66f7ab23e (MV-8 #785 merged). Parallel active FX PR #786 changes separate FX functions and does not own this native scalar policy.

What was unsafe/hard to maintain

The 4k-line approved bridge still implemented exact native gesture identity, fader target visual settling, M4 ACK correlation, and M4 independently observed physical fader/PAN/MUTE/SOLO/MAIN readback itself. Those are pure domain rules and had no isolated contract tests; reviewing pending retransmits required walking many disparate UI callbacks.

Implemented — 4 scoped files

  • web/approved-channel-strip-view-model.js: pure scalarIdentityMatches, scalarVisualSettlement, m4ScalarAckResult, m4ScalarReadbackSettlement. Each compares identity/revisions exactly as native supplied, requires native ACK + independent matching readback, does not optimize or mutate the installed mixer model. ChannelId/device epoch stays an opaque exact decimal string even >JS-safe integer.
  • web/approved-native-bridge.js: existing only pending Maps, native arMixAction transport, subscriptions, timers and pending visual cap. Calls the pure decisions at 4 existing seams; rejects nonfinite fader/PAN gesture before queuing. Preserves per-channel M4 ACK timeout, last-writer-wins pointer gestures, 30ms coalescing, existing M4 native MAIN, exactly one callback. No new ViewModel/controller/parallel PCM/session store.
  • tests/approved_scalar_view_model_contract.test.cjs: 9 deterministic contract tests for huge identities, stale channel/epoch, visual display-only readback, ACK matching and supersession, M4 routes/authority changes, per-channel fader/PAN tolerance, MUTE/SOLO booleans, MAIN original M4 revision, and single actual bridge transport.
  • .github/workflows/ui-smoke.yml: run new independent contracts in fast UI and full exact-HEAD Chromium, with trigger path, not a dead test file.

Product invariants: one approved /preview/, one JUCE native accepted ChannelId/EdgeId PCM/VST3 engine, no JS audio, no changes to hardware/device pin, JUCE/C++, ASIO/DSP, FX Rack design, .smix, HTML/CSS/PNG or installer. Native ACK never proves producer-installed fader; logical offline editor still persists only released scalar target.

Status: KODE DIBUAT; draft until Fast UI/full Chromium/required merge gate. Windows installer and real ASIO hardware FAT NOT RUN. No owner action required.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui e8f3b5d

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: d4a5feb
Status:⚡️  Build in progress...

View logs

@masarray
masarray force-pushed the refactor/mv9-scalar-control-readback-view-model-20261118 branch from e8f3b5d to d4a5feb Compare November 18, 2026 07:44

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui d4a5feb

@masarray
masarray marked this pull request as ready for review November 18, 2026 07:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T08:04:06.267624Z d4a5feb Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray marked this pull request as draft November 18, 2026 08:02
@masarray
masarray marked this pull request as ready for review November 18, 2026 08:02
@masarray
masarray merged commit 040578e into main Nov 18, 2026
58 of 72 checks passed

Copy link
Copy Markdown
Owner Author

OWNER DELIVERY — MV-9 scalar Channel Strip ViewModel (2026-11-18)

HASIL BAGI OPERATOR: Fader/PAN interaction retains the most recent local visual target only until independently installed accepted PCM readback, not merely an ACK. Incorrect native ChannelId or device epoch drops the pending visual instead of controlling the wrong strip. Each M4 channel's fader/PAN/MUTE/SOLO and MAIN gain uses one correlated native requestId/epoch/routing revision, then waits for the matching installed readback. Invalid nonfinite gesture values cannot enter pending native scalar queue. Existing native 30ms coalesced/released gesture, per-channel M4 timeout, one control dispatcher, offline .smix scalar edit and approved GUI layout remain unchanged.

STATUS: MERGED MAIN. PR #787 squash commit 040578eb9c4aeaef507e4af667c58c0e6d69ba12; exact qualified PR HEAD d4a5feb6a385305372fde22394491f7849bb5a72. MV-9 was cleanly rebased on merged FX milestone #786 at main@7eca076486e9d95130d6e5b3f91e746cdccfee16 with its FX bridge hunks preserved. Four files changed: web/approved-channel-strip-view-model.js has pure scalar identity/visual/M4 ACK/readback policies; web/approved-native-bridge.js delegates the decisions (does NOT create a second controller/PCM graph/queue); tests/approved_scalar_view_model_contract.test.cjs adds 9 deterministic regressions; .github/workflows/ui-smoke.yml actually runs them in fast and full UI.

BUKTI: Fast UI PASS, Fast Native PASS, all 9 new scalar tests PASS, exact-HEAD Full Chromium #44261475739 PASS 109/109 steps, including Stage C screenshot CSS parity, WIRE/FX/GAIN/fader/device browser controls and Firefox smoke; required commit status ArSonMix / Required CI Merge Gate SUCCESS: All scoped checks passed on d4a5feb6a385305372fde22394491f7849bb5a72. Review threads resolved/none and no head lag. On the merged main, push UI run #44263930360 and native/fast run #44263930355 were IN PROGRESS at last check; postmerge pass has not yet been claimed.

AMAN DIPAKAI? YA for the source-GUI control policy qualified by tests and merged. BELUM as a freshly built Windows installer, a new public release, or physical ASIO/multi-interface hardware FAT (all NOT RUN). No UI layout/HTML/CSS/PNG, native JUCE DSP/PCM, plugin, or .smix changes. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA.

NEXT: continue scoped MVVM only where it removes real domain policy from the remaining GUI bridge (e.g. per-channel scalar coalescing/pending scheduling and device/identity lifecycle), without duplicate state stores, render authority or approved /preview/ drift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant