Repository navigation
refactor(mv9b): accepted global FX and M4 slot bypass ACK/readback ViewModel - #788
Conversation
|
/arsonmix-ci ui 1826bec |
|
@codex review Review MV-9B exact SHA |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1826becee9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Please re-review exact reconciled HEAD |
|
/arsonmix-ci ui f420d89 |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
MV-9B delivery checkpoint — 2026-11-18STATUS: MERGED MAIN · TESTED SOURCE — squash Owner-visible result
Exact-SHA proof
AMAN DIPAKAI? Yes as tested merged JS source; NOT an independently hardware-qualified installer. TINDAKAN USER: Nothing required. Next architecture direction: single-owned typed FX/scalar command/readback contracts, progressive native ConsoleWindow application-use-case separation and architecture fitness gates; never fork the audio graph or undo MV1–MV9. |
MV-9B — FX bypass transaction reliability / modular ownership
Builds on merged MV-8 #786 while leaving the concurrently open MV-9 Channel Strip #787 untouched.
User impact / implementation
web/approved-fx-rack-view-model.js. The bridge still uses one original JUCE dispatcher/PCM controller, but no longer decides if a raw incomingarMixConsoleSnapshotis authoritative.protocol.createController().state().currentonly. Correlate device epoch, graph or M4 route revision, native session authority, requestId and desired bypass.Scope and concurrency
Exactly 3 files:
web/approved-fx-rack-view-model.js,web/approved-native-bridge.js,tests/approved_native_m2_contract.test.cjs. #787 MERGED atmain@040578eb9c4aeaef507e4af667c58c0e6d69ba12. Reconciled seven disjoint FX hunks on the latest main tree with a two-parent commitf420d892...; verified that the Channel Strip scalar changes from #787 remain intact. Full Chromium and all checks run on this combined SHA. Keep the approved /preview/ HTML/CSS, native graph, .smix and JUCE C++ unchanged.Gates
Code and syntax verified. Review P1 concerning stale pre-ACK cache was fixed by invoking global settlement exclusively from the controller's
onAcceptedcallback, not raw snapshot listener; the exact race is exercised by the new native WebView integration test. Reviewer re-review completed with zero open findings. **Fast UI PASS, Fast Native PASS (227/227 relevant contracts), Required Merge Gate SUCCESS on reconciled SHAf420d892b87651311182ddf1e942ff98331f3053; Full native Chromium in progress (run #44264589025)**. Do not merge until verified. Physical ASIO FAT and Windows installer NOT RUN; no release/PCM performance claim.Next: Arch fitness / typed contracts around exact native controller, followed by bounded C++
ConsoleWindowuse-case extraction in epic #527 without duplicating existing native services.