Skip to content

refactor(mv9b): accepted global FX and M4 slot bypass ACK/readback ViewModel - #788

Merged
masarray merged 4 commits into
mainfrom
refactor/mv9b-fx-bypass-ack-readback-20261118
Nov 18, 2026
Merged

masarray merged 4 commits into
mainfrom
refactor/mv9b-fx-bypass-ack-readback-20261118

Conversation

@masarray

@masarray masarray commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

MV-9B — FX bypass transaction reliability / modular ownership

Builds on merged MV-8 #786 while leaving the concurrently open MV-9 Channel Strip #787 untouched.

User impact / implementation

  • Extract Global FX A/B eligibility + plan + ACK + accepted readback settlement into the existing pure web/approved-fx-rack-view-model.js. The bridge still uses one original JUCE dispatcher/PCM controller, but no longer decides if a raw incoming arMixConsoleSnapshot is authoritative.
  • Prevent stale/rejected native snapshots from settling a pending global FX switch: reconcile against protocol.createController().state().current only. Correlate device epoch, graph or M4 route revision, native session authority, requestId and desired bypass.
  • M4 per-slot bypass ACK is not proof the live effect has changed: keep pending locked until independent accepted M4 snapshot confirms exact FxInstance instanceId, channel, slot, device epoch, route revision and bypass value. On stale device/revision/replaced plugin, fail closed; late/unrelated ACKs cannot unlock a different FX slot.
  • Preserve global / channel rack / insert bypass as three independent gates; no change to saved insert bypass flags, PCM graph or plugin editor lifetime.
  • Five deterministic regression tests covering admission, M4/ChannelId, stale ACK, reconnect, mismatched graph/lease, source boundaries, and an integration reproduction of pre-ACK matching snapshot + ACK + invalid snapshot + accepted post-ACK snapshot.

Scope and concurrency

Exactly 3 files: web/approved-fx-rack-view-model.js, web/approved-native-bridge.js, tests/approved_native_m2_contract.test.cjs. #787 MERGED at main@040578eb9c4aeaef507e4af667c58c0e6d69ba12. Reconciled seven disjoint FX hunks on the latest main tree with a two-parent commit f420d892...; verified that the Channel Strip scalar changes from #787 remain intact. Full Chromium and all checks run on this combined SHA. Keep the approved /preview/ HTML/CSS, native graph, .smix and JUCE C++ unchanged.

Gates

Code and syntax verified. Review P1 concerning stale pre-ACK cache was fixed by invoking global settlement exclusively from the controller's onAccepted callback, not raw snapshot listener; the exact race is exercised by the new native WebView integration test. Reviewer re-review completed with zero open findings. **Fast UI PASS, Fast Native PASS (227/227 relevant contracts), Required Merge Gate SUCCESS on reconciled SHA f420d892b87651311182ddf1e942ff98331f3053; Full native Chromium in progress (run #44264589025)**. Do not merge until verified. Physical ASIO FAT and Windows installer NOT RUN; no release/PCM performance claim.

Next: Arch fitness / typed contracts around exact native controller, followed by bounded C++ ConsoleWindow use-case extraction in epic #527 without duplicating existing native services.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: d4eedb4
Status:⚡️  Build in progress...

View logs

@masarray
masarray marked this pull request as ready for review November 18, 2026 08:00

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 1826bec

Copy link
Copy Markdown
Owner Author

@codex review

Review MV-9B exact SHA 1826becee91b25c0101a781e63097adbae4ee45f for FX bypass Global A/B and M4 slot ACK/readback safety. In particular reject any unvalidated/stale snapshot as readback, ensure no GUI-owned DSP state, and verify M4 lease replacements/route revisions can't settle a bypass. Compare with open #787 Channel Strip scalar: both touch web/approved-native-bridge.js but disjoint function regions; no scalar code must be lost during eventual integration.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T08:22:13.270026Z f420d89 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1826becee9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/approved-native-bridge.js Resolved

Copy link
Copy Markdown
Owner Author

@codex review

Please re-review exact reconciled HEAD f420d892b87651311182ddf1e942ff98331f3053 against main 040578eb9c4aeaef507e4af667c58c0e6d69ba12. Prior P1 Global FX post-ACK invalid snapshot bug has been fixed by relocating settlement to the sole controller onAccepted callback, and a native WebView event-order regression now covers it. Check that merged MV-9 Channel Strip #787 remains byte-for-byte intact outside seven independently verified disjoint FX bridge segments, and that M4 bypass ACK retains instance lease pending until later accepted readback.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui f420d89

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: f420d892b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masarray
masarray marked this pull request as draft November 18, 2026 08:20
@masarray
masarray marked this pull request as ready for review November 18, 2026 08:20
@masarray
masarray merged commit e32982b into main Nov 18, 2026
43 of 56 checks passed

Copy link
Copy Markdown
Owner Author

MV-9B delivery checkpoint — 2026-11-18

STATUS: MERGED MAIN · TESTED SOURCE — squash main@e32982ba3bc33074098137fa4c388e581a9a7fe5, PR #788. Reconciled with already-merged MV-9 Channel Strip #787 on a two-parent branch commit f420d892b87651311182ddf1e942ff98331f3053.

Owner-visible result

  • Global FX A/B reads only canonical protocol.createController().state().current and may settle only from the same controller's newly accepted onAccepted callback — never from rejected incoming snapshots, click animation, or ACK alone.
  • Exact authority, epoch and ChannelId graph/M4 route revision are fenced in the existing pure FX Rack ViewModel.
  • M4 per-slot bypass remains pending until later independently accepted M4 FxInstance identity/bypass readback; stale epoch/route, changed lease or mismatched channel/slot fail closed. Global/rack/slot settings remain independent.
  • One native JUCE dispatcher, one PCM graph, original approved /preview/ DOM. No DSP/UI redesign, C++ changes, Windows installer, or .smix schema changes.

Exact-SHA proof

  • Fast Native PASS, 227/227 native GUI contract tests incl. five targeted MV-9B cases; Fast UI PASS.
  • Required CI Merge Gate SUCCESS.
  • Full native-assembled Chromium 109/109 completed steps, zero failed, SUCCESS: run #44264589025.
  • Codex review exact SHA completed, zero findings, prior P1 accepted/post-ACK snapshot race fixed and review thread resolved.
  • Post-merge push UI/native CI started at merge, run IDs 44266493038 / 44266488973; status was in_progress when this record was written. No physical ASIO field FAT performed.

AMAN DIPAKAI? Yes as tested merged JS source; NOT an independently hardware-qualified installer. TINDAKAN USER: Nothing required.

Next architecture direction: single-owned typed FX/scalar command/readback contracts, progressive native ConsoleWindow application-use-case separation and architecture fitness gates; never fork the audio graph or undo MV1–MV9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant