Repository navigation
refactor(mv10): identity-scoped fader/PAN scheduling and native dispatch policy - #789
Conversation
|
/arsonmix-ci ui abc2fd9 |
abc2fd9 to
713fe4e
Compare
|
/arsonmix-ci ui 713fe4e |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
OWNER DELIVERY — MV-10 identity-scoped scalar scheduling (2026-11-18)STATUS: MERGED MAIN. PR #789 squash commit WHY: The native bridge had been keeping WHAT: Pure TESTS: independent Postmerge: main Chromium #44268696444 QUEUED and main native #44268696499 PENDING at last inspection. Do not claim those passed until completed. No JUCE/C++/DSP/ASIO/.smix/HTML/CSS/PNG/installer changed. No physical ASIO FAT or new Windows installer qualification. Owner action: NONE. NEXT: preserve single authoritative bridge and pure ViewModels while addressing remaining bounded device lifecycle/gesture supersession policies; audit fresh main before any next change. |
MV-10 — Native scalar scheduler policy as a pure Channel Strip ViewModel decision
Initial base:
main@040578eb9c4aeaef507e4af667c58c0e6d69ba12(merged MV-9 #787). Existing FX-gating PR #788 is in parallel and must be preserved when main advances. No alternate GUI, DSP or transport.Verified maintenance and reliability gap
Native bridge kept a
lastNativeControlSentMap keyed only by local strip/parameter. Its raw timestamp survived device-reconnect, native ChannelId remapping, native graph rejection and strip reuse. That meant a newly admitted physical channel could inherit a short throttle from an unrelated prior native identity. Pure dispatch/coalescing rules were also still hard-coded in the 4,000-line bridge.Implementation — four files, no duplicate owner
web/approved-channel-strip-view-model.js: purescalarDispatchLease,scalarGestureFlushPlan,scalarDispatchPlan. Exact decimal-string 64-bit native device epoch/ChannelId/authority scopes every send-time throttle. Emits only decisions: SEND/QUEUE on pointermove, unconditional release flush, offline logical draft defer until release, REJECT/WAIT/M4/INTENT for actual live dispatch. No DOM/timer/PCM.web/approved-native-bridge.js: one existingpendingNativeControl,liveFaderVisualTargets,lastNativeControlSent,arMixActiontransport and one 32ms retry timer remain the only owners. Uses pure plans and stores time+exact identity instead of bare time. Clears stale throttle leases on lost/rejected graph, preserves 30ms coalescing, last-writer-wins, pointerup release, per-ChannelId ACK+readback, M4/MAIN and logical .smix workflow. Does not change existing native dispatch functions or repaint.tests/approved_scalar_scheduler_contract.test.cjs: 9 new deterministic contracts for huge IDs, reconnect/strip reuse, 30ms throttle boundary, clock jumps, pointerup, offline edits, two concurrent strips, rejected/blocked control transactions, M4/MAIN path, one bridge transport and zero ViewModel browser/PCM state..github/workflows/ui-smoke.yml: runs new contracts in both Fast UI and Full Chromium and triggers when the file changes.Invariants: one approved
/preview/GUI and one JUCE native ChannelId/EdgeId/VST3 PCM owner; no C++/JUCE/ASIO/DSP/.smix/HTML/CSS/PNG modifications. M4 compatibility remains secondary and cannot pretend to be ChannelId PCM. No installer/FAT claim.STATUS: CODE COMMITTED / DRAFT. Fast UI/native and exact-HEAD full Chromium plus Required Merge Gate must pass before merging; physical hardware/ASIO FAT and installer NOT RUN. No user action required.