Skip to content

refactor(mv11): channel appearance identity, preflight and native readback ViewModel - #790

Merged
masarray merged 5 commits into
mainfrom
refactor/mv11-channel-identity-readback-view-model-20261118
Nov 18, 2026
Merged

masarray merged 5 commits into
mainfrom
refactor/mv11-channel-identity-readback-view-model-20261118

Conversation

@masarray

Copy link
Copy Markdown
Owner

MV-11 — Native Channel Identity presentation and transaction ownership

Built on merged MV-9B main@e32982ba3bc33074098137fa4c388e581a9a7fe5. Parallel #789 owns Channel Strip fader/PAN scheduler, while MV-11 owns only cosmetic Channel Identity; both touch different functions in approved-native-bridge.js / approved-channel-strip-view-model.js. Reconcile exact latest main before merge.

Code change (not documentation-only)

  • Existing pure Channel Strip ViewModel now owns: identityReadback (single native appearance projection / exact 64-bit IDs), identityEditPlan (logical-only vs admitted/retained native request, unique names and editable fields), identityAckResult, identitySettlement (ACK AND subsequent accepted native same-lease readback), legacyIdentityDecision (one native-authorized migration at a time).
  • Thin bridge retains the original native event transport, legacy WebView import cleanup, local pending request, UI dialog and timer, one accepted v6 controller; removes duplicated validation, duplicate name checks and ACK/readback rules. Native durable identity remains exclusively NativeChannelAppearanceStore, no JS store or PCM owner.
  • Pending rename can never confirm across device epoch/graph/roster revision, unaccepted authority, changed channel identity or mismatched appearance revision. Legacy cache never overwrites a genuinely native edited channel; offline .smix rename uses the existing logical use case.
  • Six deterministic regression suites cover large uint64 ChannelIds, rejected/duplicate/forged edits, offline separation, stale epoch/roster and ACK, idempotent appearance revision, legacy native conflict and one transport owner.

Scope: 3 JS/test files, no JUCE / ASIO / C++ / DSP / .smix / CSS / HTML / PNG. Approved /preview/ remains unchanged. CI STATUS: PENDING; this is a draft, NOT merged and NOT a release installer. Fast UI/Native and the native-assembled Full Chromium exact-SHA lane must pass; review findings must be fixed before merge. No physical ASIO FAT.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: ab2b135
Status: ✅  Deploy successful!
Preview URL: https://6351b109.arsonmix.pages.dev
Branch Preview URL: https://refactor-mv11-channel-identi.arsonmix.pages.dev

View logs

@masarray
masarray marked this pull request as ready for review November 18, 2026 08:44

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui e991273

Copy link
Copy Markdown
Owner Author

@codex review

Please audit MV-11 exact reconciled HEAD e99127338c8ee07eeaf2445eedd6aff4823f12f9 against main cfa922e1eb30e258e193d6865b638d0d525b414b. Verify native-owned cosmetic identity is never an audio/PCM/JS authority; exact uint64 IDs, channel rename uniqueness, identity import trust, epoch/graph/roster/appearance revision, ACK and later accepted readback are correct; ensure merged MV-10 fader/PAN scheduler #789 remains intact and native UI operators /preview/ unchanged. Review invalid/retained/logical .smix and no premature success after stale snapshots.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T09:03:22.171591Z ab2b135 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: e99127338c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui ab2b135

Copy link
Copy Markdown
Owner Author

@codex review

Re-review exact final MV-11 HEAD ab2b13515169dd8982067077f8ed673b61ccbda6 against main@cfa922e1eb30e258e193d6865b638d0d525b414b. Additional change isolates offline .smix rename uniqueness from stale native appearance map, restores operator feedback and fail-closes absent native decimal decoder. Confirm existing MV-10 scalar scheduler still owned by old ViewModel; especially verify channel identity native ACK + new accepted readback, stale epoch/revision, legacy migration and no second controller/audio authority.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: ab2b135151

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@masarray
masarray marked this pull request as draft November 18, 2026 09:01
@masarray
masarray marked this pull request as ready for review November 18, 2026 09:01
@masarray
masarray merged commit d03da5b into main Nov 18, 2026
46 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant