Repository navigation
refactor(mvvm): one native Device Setup draft and selection ViewModel - #767
Conversation
… existing pure VM
…r logic from native bridge
…sks and one bridge
… of retired bridge logic
Deploying arsonmix with
|
| Latest commit: |
9b65335
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d09889f3.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-native-device-setup.arsonmix.pages.dev |
|
/arsonmix-ci ui 9b65335 |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CHECKPOINT MV-2 — 18 November 2026 — completed and mergedHASIL: Device Setup on the real bundled native STATUS: SUDAH MERGED KE MAIN. PR #767 original head AMAN DIPAKAI? YA untuk source di BUKTI: Fast Native and source regression PASS #44196046433; Fast UI PASS #44196046290; exact-head Full Chromium approved GUI and G1/G2 native I/O PASS #44196229867; latest PR Ready-for-Review fast native/UI and Required Merge Gate PASS #44198006393, #44198006382, #44198007099. C++ MSVC/CTest NOT RUN (C++ unchanged). Hardware FAT / installer build NOT RUN. Post-merge push CI on TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. Jangan mengganti installer untuk mengevaluasi MV-2: tidak ada installer baru pada PR ini. LANGKAH BERIKUTNYA: Continue MV-3 scoped consolidation of native read-model (without parallel |
MV-2: Device Setup draft + selectors in the existing /preview/ ViewModel
Extends MERGED #765 on current main. No new native device dispatcher/PCM renderer/GUI.
Before: the approved native bridge still mutated Device Setup
deviceChoice.backend/capture/playback/inputPins/outputPins/rate/buffer, constructed dropdown options and inferred enabled physical pins and Apply/MAIN/remap eligibility alongside DOM painting.Now:
web/approved-device-view-model.jsowns puresetupDraft,setupEditDraft,setupPresentationand shared endpoint matching. Immutable, validated draft transitions keep duplex names paired, allow output-only on separate backends, reject absent pins/rates and retain native readback.web/approved-native-bridge.jsonly forwards DOM choices, renders the VM projection, and submits via the samearMixAction:audioDeviceApply; prior mutable switch branches and duplicate eligibility logic are removed. The merged #765 ACK/negative ACK/timeout/readback state machine is unchanged.Safety: only approved bundled native
/preview/, schemaVersion=6 and nativesrc/NativeDeviceApplyCoordinator.h; no native C++ change, ASIO callback alteration, FIFO/ASRC, dual ASIO, second FX/VST3 graph, .smix mutation, GUI CSS/PNG, SonKu/ImmerSIB or installer change. Different thread work remains nonblocking.Contracts: four new deterministic Node regression cases in
tests/approved_native_m2_contract.test.cjs: initial verified selectors and pure inventory; backend/duplex/output-only switching; rates/buffer/MAIN pins/forged indices/rollback preserving installed masks; DOM bridge decoupling with exactly one native dispatch. Existing full schema-v6 and Chromium cold-start scripts remain.Exact branch HEAD when created:
d52822d6eede12fc3e3597ee77fbf60598af7d61; basemain@c8fd3a8480b4dac485ff0636caf41f52603883c3. Fast CI and exact-SHA full Chromium are PENDING until verified; hardware testing NOT RUN. C++ unchanged → native CTest not required for this presentation-only PR.Operator report: HASIL = pilih driver/input/output/rate/buffer/pin di native Device Setup sekarang lewat satu pure ViewModel, bukan logika duplikat bridge. STATUS = KODE DIBUAT (BELUM DIUJI). AMAN DIPAKAI? BELUM sebagai installer baru; source tidak menyentuh DSP. TINDAKAN ANDA = TIDAK PERLU MELAKUKAN APA-APA. LANGKAH BERIKUTNYA = fast Node/Python contracts, full native-assembled Chromium, exact SHA merge, then evaluate MV-3 read-model without creating a second authority.
Exact-SHA verification update (2026-11-18)
9b6533535021f99fcc700255e6f66c7b2b47ff22, based onmain@c8fd3a8480b4dac485ff0636caf41f52603883c3(refresh before merge).