Skip to content

FAST2 P0: one APPLY activates native device, patch and hardware output — remove START AUDIO - #259

Merged
masarray merged 11 commits into
mainfrom
fix/fast2-apply-verified
Oct 31, 2026
Merged

masarray merged 11 commits into
mainfrom
fix/fast2-apply-verified

Conversation

@masarray

Copy link
Copy Markdown
Owner

Operator-first live mixer milestone

One APPLY in AUDIO I/O now acts as the single explicit operator action. If hardware changed it MUTE-ACKs the prior output, commits real JUCE device, waits for the new generation and routing epoch, applies first-sound routing if needed, then ARM-ACKs native MAIN. Existing routing edits use a MUTE → ROUTE ACK → ARM chain; no duplicate audio engine or UI START AUDIO button. Emergency MUTE stays accessible. Device failure, stale epoch/revision, or rejected routing leave output safely muted.

Preserves merged #256 raw per-pin PCM truth, exact standalone/WebView JS mirroring, updates relevant Node operator contracts, and adds concise physical FAT instructions. Follows the official Studio Pro Audio I/O Setup → Apply operator pattern. 0FX crackle is not claimed solved: the operator's 23:33 WIB report shows 23 WASAPI capture discontinuity flags and zero callback overruns over 11,744 callbacks. #15 hardware A/B stays P0; experimental #251 de-click is not auto-enabled.

CI: Chromium UI and Windows native only on exact head. Hardware FAT needed before declaring live-ready.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T17:01:00.437302Z af49423 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af49423b75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/monitor.js
const d=state.dryRoutingLab||{};
if(fastAudioPending||patchPending||nativeShowBusy||liveSendPending.size)
return {ok:false,error:"Native transaction still pending."};
if(mixerDraftActive||rackFxDraft){

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Detect crosspoint drafts before choosing the arm-only path

If an operator edits an input crosspoint in the advanced PATCH matrix, closes that workspace, and presses the MIX toolbar's APPLY, the new wrapper skips the routing transaction. The patchGrid click handler changes draftRoutes without setting mixerDraftActive, so this condition remains false: an armed session returns OUTPUT ALREADY LIVE, while a muted session with an existing accepted input route arms the old routing instead. Previously the toolbar called __arMixApplyMixerDraft() unconditionally and submitted those edits. Detect actual routing differences here, or ensure every crosspoint edit sets the draft flag, so APPLY cannot silently retain and activate the wrong input.

Useful? React with 👍 / 👎.

Comment thread web/mixer-io.js Outdated
overlay.querySelector('[data-io-device-revert]').hidden=ioTab!=='device';
const deviceBlocker=deviceSwitchBlocker(s);
overlay.querySelector('[data-io-device-apply]').disabled=!deviceDirty()||!!deviceBlocker;
overlay.querySelector('[data-io-device-apply]').disabled=!!deviceBlocker||deviceBusy||applyMutePending||!!window.__arMixFastAudioState?.().pending||(!deviceDirty()&&(!hardwareReady(s)||!!lastStatus.monitor));

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Enable device-tab APPLY for pending routing edits while live

With physical output armed and no device-setting changes, editing MAIN/MONITOR crosspoints or channel routing in the DEVICE / DRIVER tab leaves its only APPLY button disabled because lastStatus.monitor is true. The separate APPLY PATCH button is now hidden throughout that tab, even though __arMixApplyAndActivate() explicitly supports muting, applying routing, and rearming. Consequently, the embedded matrix cannot complete the advertised one-APPLY workflow without manually muting first or switching tabs. Account for routing drafts when disabling this button rather than treating every unchanged-device, armed session as having nothing to apply.

Useful? React with 👍 / 👎.

…e main and preserve stereo metering regressions
@masarray
masarray force-pushed the fix/fast2-apply-verified branch from b89a1b5 to 0ce31ec Compare October 31, 2026 17:26
@masarray
masarray merged commit d457793 into main Oct 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant