Repository navigation
FAST2 P0: one APPLY activates native device, patch and hardware output — remove START AUDIO - #259
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af49423b75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const d=state.dryRoutingLab||{}; | ||
| if(fastAudioPending||patchPending||nativeShowBusy||liveSendPending.size) | ||
| return {ok:false,error:"Native transaction still pending."}; | ||
| if(mixerDraftActive||rackFxDraft){ |
There was a problem hiding this comment.
Detect crosspoint drafts before choosing the arm-only path
If an operator edits an input crosspoint in the advanced PATCH matrix, closes that workspace, and presses the MIX toolbar's APPLY, the new wrapper skips the routing transaction. The patchGrid click handler changes draftRoutes without setting mixerDraftActive, so this condition remains false: an armed session returns OUTPUT ALREADY LIVE, while a muted session with an existing accepted input route arms the old routing instead. Previously the toolbar called __arMixApplyMixerDraft() unconditionally and submitted those edits. Detect actual routing differences here, or ensure every crosspoint edit sets the draft flag, so APPLY cannot silently retain and activate the wrong input.
Useful? React with 👍 / 👎.
| overlay.querySelector('[data-io-device-revert]').hidden=ioTab!=='device'; | ||
| const deviceBlocker=deviceSwitchBlocker(s); | ||
| overlay.querySelector('[data-io-device-apply]').disabled=!deviceDirty()||!!deviceBlocker; | ||
| overlay.querySelector('[data-io-device-apply]').disabled=!!deviceBlocker||deviceBusy||applyMutePending||!!window.__arMixFastAudioState?.().pending||(!deviceDirty()&&(!hardwareReady(s)||!!lastStatus.monitor)); |
There was a problem hiding this comment.
Enable device-tab APPLY for pending routing edits while live
With physical output armed and no device-setting changes, editing MAIN/MONITOR crosspoints or channel routing in the DEVICE / DRIVER tab leaves its only APPLY button disabled because lastStatus.monitor is true. The separate APPLY PATCH button is now hidden throughout that tab, even though __arMixApplyAndActivate() explicitly supports muting, applying routing, and rearming. Consequently, the embedded matrix cannot complete the advertised one-APPLY workflow without manually muting first or switching tabs. Account for routing drafts when disabling this button rather than treating every unchanged-device, armed session as having nothing to apply.
Useful? React with 👍 / 👎.
…e main and preserve stereo metering regressions
b89a1b5 to
0ce31ec
Compare
…ed START controls
…tead of removed START button
…se-output routing transaction
Operator-first live mixer milestone
One APPLY in AUDIO I/O now acts as the single explicit operator action. If hardware changed it MUTE-ACKs the prior output, commits real JUCE device, waits for the new generation and routing epoch, applies first-sound routing if needed, then ARM-ACKs native MAIN. Existing routing edits use a MUTE → ROUTE ACK → ARM chain; no duplicate audio engine or UI START AUDIO button. Emergency MUTE stays accessible. Device failure, stale epoch/revision, or rejected routing leave output safely muted.
Preserves merged #256 raw per-pin PCM truth, exact standalone/WebView JS mirroring, updates relevant Node operator contracts, and adds concise physical FAT instructions. Follows the official Studio Pro
Audio I/O Setup → Applyoperator pattern. 0FX crackle is not claimed solved: the operator's 23:33 WIB report shows 23 WASAPI capture discontinuity flags and zero callback overruns over 11,744 callbacks. #15 hardware A/B stays P0; experimental #251 de-click is not auto-enabled.CI: Chromium UI and Windows native only on exact head. Hardware FAT needed before declaring live-ready.