Repository navigation
M3E RT: coherent lock-free stereo fader/PAN targets + real PCM extreme PAN regression - #260
Merged
Merged
Conversation
…nt lock-free stereo control
masarray
added a commit
that referenced
this pull request
Oct 31, 2026
…edger * docs(reconcile): establish current merged hardware/FX/dynamic status, open PR and CI gates * docs(reconcile): normalize Markdown code spans in authoritative main ledger * docs(agents): pin latest exact-main reconciled hardware / FX / dynamic / CI status * docs(reconcile): record completed exact-HEAD native CI for draft PR258 * docs(reconcile): record completed exact-HEAD native CI for draft PR258 * docs(reconcile): include new stacked M4 FX and M3E stereo PRs plus latest FAST2 CI failure * docs(agents): include live draft owners #260 and stacked #261 without claiming production parity
masarray
marked this pull request as ready for review
October 31, 2026 17:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native audio reliability — one substantive M3E DSP safety seam
Previously,
DynamicPreparedMixerBlockpublished the L/R coefficients of a fader + PAN event using TWO independentatomic<float>stores and the callback performed TWO independent loads. Concurrent reader/writer can observe a half-updated left/right pair even though each value is atomic; this can create transient stereo-image jumps during live control.Fix: pack both float32 coefficients into one
atomic<uint64_t>using C++20bit_cast, a single release store / acquire load, compile-timeis_always_lock_freeguard and existing audio-thread-only 64-sample ramps. No extra heap, lock, FX render, callback or refresh thread. Exact stereo tuple is always from one control event. Preserve stableChannelId, graph revision and independent FX Send/primary OUT semantics.Regression: native PCM tests now exercise extreme PAN L, R and center at fixed gain through one FX Return after muting exclusive GROUP; left/right outputs and graph revision verified under real prepared renderer. Existing graph, overlap and hardware tests remain intact.
Scope isolation: P0 FAST2 #259 and console meters #258 are working separately; this PR touches only prepared dynamic C++ DSP and its native tests, never ASIO device, GUI or legacy 10CH live renderer. Production cutover M3E still required; does not claim real-hardware crackle #15 resolved.
CI gate: one Windows native workflow, no extra matrix or fragile CI fanout.