Skip to content

M3E RT: coherent lock-free stereo fader/PAN targets + real PCM extreme PAN regression - #260

Merged
masarray merged 2 commits into
mainfrom
fix/m3e-atomic-stereo-fader-pan-target-20261101
Oct 31, 2026
Merged

masarray merged 2 commits into
mainfrom
fix/m3e-atomic-stereo-fader-pan-target-20261101

Conversation

@masarray

Copy link
Copy Markdown
Owner

Native audio reliability — one substantive M3E DSP safety seam

Previously, DynamicPreparedMixerBlock published the L/R coefficients of a fader + PAN event using TWO independent atomic<float> stores and the callback performed TWO independent loads. Concurrent reader/writer can observe a half-updated left/right pair even though each value is atomic; this can create transient stereo-image jumps during live control.

Fix: pack both float32 coefficients into one atomic<uint64_t> using C++20 bit_cast, a single release store / acquire load, compile-time is_always_lock_free guard and existing audio-thread-only 64-sample ramps. No extra heap, lock, FX render, callback or refresh thread. Exact stereo tuple is always from one control event. Preserve stable ChannelId, graph revision and independent FX Send/primary OUT semantics.

Regression: native PCM tests now exercise extreme PAN L, R and center at fixed gain through one FX Return after muting exclusive GROUP; left/right outputs and graph revision verified under real prepared renderer. Existing graph, overlap and hardware tests remain intact.

Scope isolation: P0 FAST2 #259 and console meters #258 are working separately; this PR touches only prepared dynamic C++ DSP and its native tests, never ASIO device, GUI or legacy 10CH live renderer. Production cutover M3E still required; does not claim real-hardware crackle #15 resolved.

CI gate: one Windows native workflow, no extra matrix or fragile CI fanout.

masarray added a commit that referenced this pull request Oct 31, 2026
masarray added a commit that referenced this pull request Oct 31, 2026
…edger

* docs(reconcile): establish current merged hardware/FX/dynamic status, open PR and CI gates

* docs(reconcile): normalize Markdown code spans in authoritative main ledger

* docs(agents): pin latest exact-main reconciled hardware / FX / dynamic / CI status

* docs(reconcile): record completed exact-HEAD native CI for draft PR258

* docs(reconcile): record completed exact-HEAD native CI for draft PR258

* docs(reconcile): include new stacked M4 FX and M3E stereo PRs plus latest FAST2 CI failure

* docs(agents): include live draft owners #260 and stacked #261 without claiming production parity
@masarray
masarray marked this pull request as ready for review October 31, 2026 17:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T17:24:28.887090Z 8198d3a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 08a011b into main Oct 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant