Skip to content

M3E LIVE: independent GROUP Bus in one production JUCE callback + native Console fader - #263

Closed
masarray wants to merge 27 commits into
mainfrom
milestone/m3e-live-bus-production-callback-20261101
Closed

masarray wants to merge 27 commits into
mainfrom
milestone/m3e-live-bus-production-callback-20261101

Conversation

@masarray

Copy link
Copy Markdown
Owner

M3E — real independent native GROUP live (not offline-only)

M3A–D published tested dynamic ChannelId DSP but did not connect it to the Windows audio callback. This milestone introduces a real new Group ChannelId to the existing single JUCE callback, with physical input→Group→verified MAIN output, and no borrowed input strip or double dry.

Backend: LiveDynamicBusSession.h validates actual native device/MAIN pin masks, input callback ordinals, accepted 10CH physical source ACK, zero existing FX/AUX/SEND/MONITOR (explicit safe pilot), all output disarmed, epoch/revision. It prepares and publishes 10 input ChannelIds + MAIN + newly created independent Group (12 IDs), then switches the existing LiveAudioEngine callback to the dynamic render INSTEAD of legacy (never alongside). Uses existing direct ASIO/WASAPI fence, input PCM evidence, master/mono, output de-click ramp, physical hardware mapping, metering and secondary PCM tap. Failed/hotplug/stale devices remain silent. STOP restores the original ACKed legacy route, not a new browser guess.

Operator Console: Ctrl/Shift select physical channel rows, + BUS FOR SELECTED issues a real native ACK transaction. A compact Bus rail displays native ID and exact Group fan-in, with actual smoothed native Group fader -60..+10 dB. JS and embedded standalone preview kept in parity, no WebAudio or DSP fakery.

Tests: Native 10 input→independent Group 2 source PCM, no extra dry, live -6 dB group gain, stale epoch fail-silent, output-armed rejection; existing PCM tests remain. New Node GUI/engine contract checks one-producer rule and native/standalone parity. One standard Windows native CI + Chromium UI smoke; no extra matrix.

Safety scope: 0FX dry pilot only. Existing vendor VST3/AUX/sends/monitor/Show structures are refused rather than lost. M4 unified FX instance leases (#261) must later migrate to ChannelId to enable EQ/compressor on GROUP and real FX Return. This PR is NOT complete Studio One parity and NOT physically FAT certified. No second audio callback, no DAW arranger, no OBS dependency.

Documentation: docs/M3E_LIVE_NATIVE_GROUP_CALLBACK_FAT_20261101.md. Related #192 #15. Benchmark https://fenderstudiopromanual.fender.com/en/Content/Mixing_Topics/Effects_Signal_Routing.htm

Merge gate: exact-head Windows native CTest + Chromium GUI parity + safety review.

…dware pins and single prepared PCM publisher
…isting JUCE callback with hardware MAIN/epoch/mute/fade

Copy link
Copy Markdown
Owner Author

Rekonsiliasi arsitektur setelah M4 #261 merged (main@cf05c5ff)

Owner requirement (1 Nov): CH1..CH-N is one runtime-configured, identical live channel model, with independently selectable MONO/STEREO processing format and physical/logical input, per-channel FX, sends, GROUP/AUX, meters, fader/PAN/MUTE/SOLO, native ACK, Show and user-selectable hardware/software output. Console workflow is inspired by Studio One/Fender Studio Pro and Adobe Audition, but product remains a real-time live mixer, NOT an arranger/DAW.

Audit of this PR: the new independent GROUP is real PCM inside the single JUCE callback (good), but LiveDynamicBusSession rejects an otherwise valid live mix containing existing VST3, AUX/sends, MONITOR or Show state. It creates only 1 dry GROUP while 10 legacy inputs remain the front-end. It does NOT deliver CH11+ input strips or dynamic mono/stereo/FX/group parity. Its dry-only pilot must not be represented as the finished Studio Console, and a Group created in a normal user mix must not require deleting existing processing. Keep this PR DRAFT / opt-in experimental until these boundaries are explicitly dealt with.

Mandatory integration order/gates before production merge:

  1. Reconcile/rebase against exact current main including FAST2 P0: one APPLY activates native device, patch and hardware output — remove START AUDIO #259 FAST2 + FAST3 one-APPLY output safety and merged M4 Native FX Console: unified CH1–CH10 ownership, multi-lane atomic draft and real-source gate #261 FX ownership. Re-run targeted tests locally before one Windows/Chromium CI pair; avoid duplicate expensive CI.
  2. Migrate native VST3 instance/editor/bypass state and plugin lease off callback into stable ChannelId nodes, eliminate CH1-only callback/fallback. Every CH1..N and Group/FX return uses the same prepared insert adapter, with actual negotiated MONO/STEREO VST3 bus layouts (otherwise explicit negative ACK and rollback).
  3. Preserve AUX PRE/POST, MONITOR, physical MAIN/secondary output, old Show and plugin state across graph cutover; no alternate dry-only live producer replacing a normally configured mixer. Exactly one authoritative graph/callback and stable immutable ID mapping.
  4. User-facing + CHANNEL (MONO/STEREO), + GROUP / + FX BUS and per-channel source/format independent of hardware pin count. Real time on CH1, CH11 and CH-N, not DOM-only bank strips. Adopt GUI virtualization/resource-budget admission; do not advertise mathematical infinite capacity or 0-ms physical latency.
  5. Native PCM acceptance: CH1 + CH11 identical mono/stereo/pan/fader/FX; Group no double-dry; stereo non-adjacent source pins; VST3 persistence across reorder/Show; sends/monitor/secondary output; stale epoch/revision, device restart, invalid layout, exceeded CPU/memory budget fail safely. Exact-head Windows native CTest and Chromium must pass; P0 — Crackling with 0 VST3: diagnose WASAPI clock/input/output buffering before engine expansion #15 physical 0-FX 30-minute FAT remains open.

Decision: Keep current #263 useful as a tightly scoped dry GROUP experiment, not the final shipping upgrade. No unguarded merge of #251 de-click either (default OFF A/B only). Next major milestone is an end-to-end production universal ChannelId graph retaining working M4 FX while enabling real MONO/STEREO +CH and +BUS.

Copy link
Copy Markdown
Owner Author

Architecture reconciliation — superseded, closing without merge. Dry-only one-Group production callback pilot rejects VST/AUX/sends/MONITOR/Show and modifies LiveAudioEngine/Main.cpp plus UI concurrently with canonical M-U1 #266 and R7 #265. It cannot satisfy live Group for an active normal session. Archive its group PCM tests as reference, but integrate Group ONLY after full M4 VST lease, monitor, Show and CH1 Orbit migration without loss; do not merge this divergent head.

Canonical PRD v5 / ARD v5. Active native graph #266, operator UI #265, issue #192. This historic branch/commit remains available for selective reference; no source deletion and no loss-of-working-audio merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant