Repository navigation
M1 integrated operator: custom ASIO/WASAPI setup + selected CHANNEL flow + live AUX master on one engine - #231
Conversation
…r with latest native ASIO/WASAPI setup
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12582f29e3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const ok=ack?.ok===true&&next.epoch===now.epoch&& | ||
| next.revision===now.revision&&next.acceptedRoute&&!patchPending&& | ||
| !mixerDraftActive; |
There was a problem hiding this comment.
Preserve FX drafts when acknowledging AUX master gain
If an operator stages a routed FX edit after requesting an AUX master gain change but before its ACK arrives, __arMixStageRackFx sets rackFxDraft without setting mixerDraftActive. This ACK therefore passes the guard and calls hydrateAcceptedRoute(), overwriting the newly edited draftRoutes with the previously accepted FX chain while leaving rackFxDraft present. The subsequent FX APPLY silently submits the old chain instead of the operator's selection. Include rackFxDraft in the hydration guard, or update only the acknowledged AUX gain rather than rehydrating the entire shared draft. This preserves the shared FX draft/ACK interface specified in AGENTS.md.
AGENTS.md reference: AGENTS.md:L55-L55
Useful? React with 👍 / 👎.
M1 integrated operator milestone, not competing parallel implementations
This is the conflict-resolved integration of completed DEVICE1 #228 with independently CI-proven M1B #226, based on latest
main@56adb305cef484ae9799068a87a20a38661ea2a8. Original #226 cannot merge directly after DEVICE1; this one integration PR maintains both through a controlled 13-file merge and native+Chromium CI.What operators can actually use
Integration specifics
Hard gates
Must pass exact-head Windows MSVC/CTest/ZIP and Chromium integrated operator smoke with source SHA
12582f29e3b8ebea442bab99eb2cffddf9e5dca2. After CI, real-device 0FX wired ASIO/WASAPI first, then audible MAIN/MONITOR→AUX master gain no-pop run. Do not claim ready for professional stage or complete eMotion LV1 parity without #15 hardware FAT, selected source click-flow hardware verification and plugin state tests. Original PR #226 is superseded by this integration PR; do not separately merge it. Operator FAT details.