Skip to content

M1B: selected CHANNEL native SOURCE→FX→SENDS→OUTPUT + realtime AUX master to MAIN/MONITOR - #226

Closed
masarray wants to merge 1 commit into
mainfrom
feat/m1b-channel-focus-live-aux-master-20261031
Closed

masarray wants to merge 1 commit into
mainfrom
feat/m1b-channel-focus-live-aux-master-20261031

Conversation

@masarray

Copy link
Copy Markdown
Owner

Integrated professional mixer operator milestone — actual native PCM, not fake controls

Rebases conceptually on merged #224 real ASIO/WASAPI device setup and muted SOURCE selection and merged #223 live CH→AUX POST sends. All changes in one prepared-graph/audio-owner integration and one CI run per platform.

One channel journey (operator)

  • Thin 35px selected-channel SOURCE→FX→SENDS→OUTPUT ribbon on the workbench, NOT squeezed into RAIL3: reflect native ACK acceptedRoute only, actual enumerated hardware pins, native inserted VST3 count / CH1 legacy lane, accepted AUX sends and physical MAIN destination.
  • SOURCE opens existing native CH input selection; FX opens the real channel rack; SEND opens that channel's actual AUX inspector; OUTPUT opens physical output routing. This navigates the same routing controller—no new graph, fake audio model, giant cards, blur, animation or periodic UI rebuild.
  • Real ASIO/WASAPI/64-pin selection from AUDIO M1: real ASIO/WASAPI 64-pin setup + native-ACK hardware SOURCE → mixer channel #224, output routing, VST3 instance/editor leases, Show, independent MONITOR/OUTPUT1, L2/RAIL3 visual geometry and MS5 flip remain.

Real new audible feature

  • AUX MASTER level is now genuinely live, distinct from CH→AUX send faders. In SENDS rail select AUX1-4, release/keyboard the AUX MASTER slider (-60..+6 dB), native routingAuxBusGain validates current epoch, graph revision, enabled AUX return and exact finite range, returns arMixAuxBusGainAck with authoritative status.
  • Single pre-allocated PreparedMixerBlock uses four atomic master targets; output coefficient interpolates within <=64 samples after AUX VST3, before feeding MAIN AND MONITOR in SAME callback. No plugin/realtime heap/lock, no graph rebuild, no manual global MUTE for gain and no auto-unmute.
  • Structural AUX enable, FX/bus changes, PRE/PAN, device/physical routing continue to require guarded MUTE→APPLY→ACK, fail closed on stale device. SOURCE switching while speakers ARMED is still refused until proper de-click/hardware gates.

Evidence and precise gates

  • Existing ARMixMixerRoutingTests: native PCM AUX return 1→2→0 gain, MAIN+MONITOR proportionality and 64-frame ramp, immutable graph fallback and invalid/missing AUX/NaN rejection.
  • Existing Chromium G1/G3/MS5 smoke: selected focus native readback, click-through SOURCE/FX and real AUX master request, readback only on positive native ACK, no new routingDryApply, original MAIN/FX rack DOM intact.
  • tests/mixer_io_operator_contract_test.mjs wires all native components; standalone HTML CSS/JS identical to modular sources.
  • Engineering + FAT gate and AGENTS precedence.
  • Draft until exact-head Windows MSVC/CTest/ZIP plus Chromium smoke SUCCESS. Hardware 0FX crackle P0 — Crackling with 0 VST3: diagnose WASAPI clock/input/output buffering before engine expansion #15 and 30-min direct ASIO/WASAPI FAT remain open. This is NOT a claim of full DAW/LV1 parity or a stage-certified release.

Copy link
Copy Markdown
Owner Author

Cross-thread PR merge guard — 2026-10-31: Canonical live PR ledger #229 records this PR as the ONLY owner of selected CHANNEL + realtime native AUX MASTER/PCM. New concurrent DEVICE1 #228 modifies overlapping src/Main.cpp, web/mixer-io.js/css, standalone HTML and operator tests. Your current head 325825a92cfcdb6e37813a78faf903f239ecbd5c has its own CI; older 4bee5c89 PASS must not qualify it. Do NOT merge based on a green old head or overwrite #228 custom device audioDeviceApply; after one PR merges, reconcile the other's same files against exact new main and rerun Windows native/Chromium at the integrated SHA. Preserve #223 live CH→AUX POST, #224 real device/SOURCE1, #227 custom setup contract, G5E Show/leases and single native graph. #15 hardware FAT remains open.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T03:13:03.167207Z 325825a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 325825a92c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/monitor.js
Comment on lines +1257 to +1262
const ok=ack?.ok===true&&next.epoch===now.epoch&&
next.revision===now.revision&&next.acceptedRoute&&!patchPending&&
!mixerDraftActive;
if(ok){
state.dryRoutingLab=next;
hydrateAcceptedRoute();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve pending rack edits when acknowledging AUX gain

If an FX Rack edit is staged while an AUX master request awaits its native ACK, this handler overwrites that edit: __arMixStageRackFx sets rackFxDraft without setting mixerDraftActive, so the guard passes and hydrateAcceptedRoute() replaces the staged draftRoutes[].fxIds with the previously accepted chain. rackFxDraft remains populated, but the subsequent __arMixApplyRackFx() submits the restored chain, silently losing the requested insert/remove/reorder. Check rackFxDraft before rehydrating, or merge only the acknowledged AUX gain without replacing unrelated drafts. This affects the shared FX draft/ACK interface specified in AGENTS.md.

AGENTS.md reference: AGENTS.md:L57-L57

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Superseded by merged integrated M1 PR #231 (main commit d3293af72eef029032a9138f26e6c71dc69967f7). Direct #226 became conflicted after DEVICE1 #228 changed the shared Main.cpp, mixer-io CSS/JS, standalone HTML and operator tests. #231 reapplied M1B's genuine AUX master DSP, selected-channel signal flow, UI/native ACK and PCM tests onto the current DEVICE1 baseline using safe hunk-level reconciliation and exact merged embedded assets. Integrated SHA 12582f29 has Windows MSVC/CTest/ZIP CI #41163412113 SUCCESS and Chromium #41163412112 SUCCESS, and was squash-merged. Do not merge #226 again; duplication risks undoing custom JUCE ASIO/WASAPI setup. Physical issue #15 remains OPEN. Please use #231 and its main build for further development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant