Repository navigation
Conversation
…atest device-setup product docs)
4bee5c8 to
325825a
Compare
|
Cross-thread PR merge guard — 2026-10-31: Canonical live PR ledger #229 records this PR as the ONLY owner of selected CHANNEL + realtime native AUX MASTER/PCM. New concurrent DEVICE1 #228 modifies overlapping |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 325825a92c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const ok=ack?.ok===true&&next.epoch===now.epoch&& | ||
| next.revision===now.revision&&next.acceptedRoute&&!patchPending&& | ||
| !mixerDraftActive; | ||
| if(ok){ | ||
| state.dryRoutingLab=next; | ||
| hydrateAcceptedRoute(); |
There was a problem hiding this comment.
Preserve pending rack edits when acknowledging AUX gain
If an FX Rack edit is staged while an AUX master request awaits its native ACK, this handler overwrites that edit: __arMixStageRackFx sets rackFxDraft without setting mixerDraftActive, so the guard passes and hydrateAcceptedRoute() replaces the staged draftRoutes[].fxIds with the previously accepted chain. rackFxDraft remains populated, but the subsequent __arMixApplyRackFx() submits the restored chain, silently losing the requested insert/remove/reorder. Check rackFxDraft before rehydrating, or merge only the acknowledged AUX gain without replacing unrelated drafts. This affects the shared FX draft/ACK interface specified in AGENTS.md.
AGENTS.md reference: AGENTS.md:L57-L57
Useful? React with 👍 / 👎.
|
Superseded by merged integrated M1 PR #231 (main commit |
Integrated professional mixer operator milestone — actual native PCM, not fake controls
Rebases conceptually on merged #224 real ASIO/WASAPI device setup and muted SOURCE selection and merged #223 live CH→AUX POST sends. All changes in one prepared-graph/audio-owner integration and one CI run per platform.
One channel journey (operator)
Real new audible feature
routingAuxBusGainvalidates current epoch, graph revision, enabled AUX return and exact finite range, returnsarMixAuxBusGainAckwith authoritative status.PreparedMixerBlockuses four atomic master targets; output coefficient interpolates within <=64 samples after AUX VST3, before feeding MAIN AND MONITOR in SAME callback. No plugin/realtime heap/lock, no graph rebuild, no manual global MUTE for gain and no auto-unmute.Evidence and precise gates
ARMixMixerRoutingTests: native PCM AUX return 1→2→0 gain, MAIN+MONITOR proportionality and 64-frame ramp, immutable graph fallback and invalid/missing AUX/NaN rejection.routingDryApply, original MAIN/FX rack DOM intact.tests/mixer_io_operator_contract_test.mjswires all native components; standalone HTML CSS/JS identical to modular sources.