Repository navigation
DEVICE1: real ASIO/WASAPI device selection inside existing custom Audio I/O Matrix - #228
Conversation
…back and muted rollback
…in existing IO matrix
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 389df72221
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| checked.inputChannels==before.inputChannels&& | ||
| checked.outputChannels==before.outputChannels&& | ||
| manager.getCurrentAudioDevice()!=nullptr&& | ||
| manager.getCurrentAudioDevice()->isOpen()&&engine_.finishManualAudioSetup(); |
There was a problem hiding this comment.
Restore the accepted mixer session during device rollback
When a device APPLY fails with an existing patched mix, rollback restores only the hardware configuration, not the working mixer session. The earlier beginManualAudioSetup() calls dryRoutingLab_.disable(), which clears the accepted route and unpublishes its FX graph; this call to finishManualAudioSetup() then creates an unpatched session with no sends or routed FX selections. Consequently, even RESTORED_MUTED leaves the operator's previous mix and routed plugin state lost. Retain the accepted session and FX leases before mutation, then restore them against the restored device epoch while keeping outputs muted.
AGENTS.md reference: AGENTS.md:L23-L23
Useful? React with 👍 / 👎.
| }else if(target.matches('.arIODevicePlayback')){ | ||
| deviceDraft.playbackDevice=target.value; | ||
| if(!deviceType(deviceDraft.backend)?.separate)deviceDraft.captureDevice=target.value; | ||
| }else if(target.matches('.arIODeviceCapture')){ | ||
| deviceDraft.captureDevice=target.value; |
There was a problem hiding this comment.
Reset endpoint-specific settings when changing devices
When an operator selects another capture or playback endpoint within the current backend, these handlers retain the previous endpoint's sample rate and buffer size. Since deviceSameEndpoint() becomes false, the form displays only AUTO for both fields, but deviceApply() still submits the retained nonzero values. For example, switching from a 48 kHz/128-sample endpoint submits those settings to the new device despite showing AUTO, potentially causing rejection and rollback when the new device does not support them. Reset endpoint-specific draft settings to AUTO when either endpoint changes, and hydrate the accepted settings when returning to the active endpoint.
Useful? React with 👍 / 👎.
|
Cross-thread PR merge guard — 2026-10-31: The new DEVICE1 code shares |
DEVICE1 — Physical FAT acceptance (execute ONLY on a verified main-build Windows ZIP)Release constraint: PR Windows workflow compiles/tests/packages but does not publish a ZIP. The artifact
PASS only when: same shipped EXE does real JUCE device APPLY/readback + native input/output routing/ACK + audible physical output; no automatic unmute, unexpected endpoint substitution, duplicate callback or unbounded freeze. Green CTest/Chromium alone is not physical qualification. Known limitation: ASIO vendor scan/open can synchronously stall inside third-party code on the JUCE device owner; WebView2 controls do not make vendor code interruptible. Record and isolate field cases rather than claiming hard no-freeze guarantees. |
Milestone — working custom JUCE DEVICE/DRIVER path
Implements the PRD/ARD/handoff merged in #227 without creating a second audio engine or new Audio Setup popup. Existing WebView2 AUDIO I/O matrix now contains real detected ASIO/WASAPI/DirectSound backend, capture/playback device selection, actual active device sample rates/buffer sizes and verified input/output pin checkboxes. Unsupported/new candidate capabilities remain AUTO until driver has opened; no phantom pins/rates.
Native: added
audioDeviceApplyon the existing JUCEAudioDeviceManager; validates reported backend/device names, duplex pairing, rate/buffer and same-active-device masks. Enforces outputs already MUTED including independent secondary; uses existing direct fence, opens the selected backend/device once, verifies native readback + production session, persists only success, and attempts previous-device rollback on failure. Returns requestId-keyed nativearMixAudioDeviceApplyAckwithACCEPTED_MUTED/RESTORED_MUTED/RECOVERY_REQUIREDstates; never auto-rearms output. Direct fallbackAudioDeviceSelectorComponentretained in C++ for engineering recovery, no longer in normal WebView DEVICE UI.WebView2: same existing 3-tab matrix and mixer/route controller. Compact premium no-blur controls, config draft & APPLY DEVICE, exact native ACK, no per-dropdown backend open. Standalone inline JS kept identical. Existing INPUT/OUTPUT PATCH, 10CH/4AUX, VST leases, MAIN/MONITOR/OUTPUT1, RAIL3 and SOURCE1 preserved.
Tests: enhanced operator contracts and Chromium fake-driver smoke (real selectors, one apply, stale ACK fencing, verified pin checkboxes, revert) plus existing native Windows CTest/package. Hardware FAT required for MAONO PS22/ASIO and WASAPI; driver scan/open operations are synchronous JUCE backend calls, so no claim of immunity to a wedged third-party ASIO driver. #15 zero-FX crackle remains separate release gate.
Review gates: must pass exact-head Chromium + Windows native compile/CTest before merge. No claim of physical test until measured.