Skip to content

DEVICE2: cached hardware inventory, guarded driver rescan and verified active I/O masks - #232

Closed
masarray wants to merge 1 commit into
mainfrom
feat/device2-safe-discovery-readback-20261031
Closed

masarray wants to merge 1 commit into
mainfrom
feat/device2-safe-discovery-readback-20261031

Conversation

@masarray

Copy link
Copy Markdown
Owner

One coherent reliability milestone (build on merged #231)

  • Fix GUI stalls from repeated ASIO/WASAPI scan: opening existing AUDIO I/O overlay now invokes a fast JUCE cached list/readback request. The new explicit REFRESH DEVICE LIST request is the only path calling AudioIODeviceType::scanForDevices() after startup. Native refuses scanning while MAIN or secondary OUTPUT1 is armed, during independent/diagnostic/FX/Show transitions; logs duration and returns SCANNED, BLOCKED_ARMED, SCAN_ERROR or CACHED to the same compact WebView2 matrix.
  • Stronger hardware readback: a successful setAudioDeviceSetup is not by itself physical acceptance; verify actual opened AudioIODevice input/output channel masks and actual rate/buffer against JUCE accepted setup and ensure >=1 enabled input and >=2 output channels before authorizing production.
  • Preserve single audio graph & UI parity: same manager and route controller, output remains muted through explicit APPLY/rollback, no worker or fake WebAudio pipeline, no blur or new I/O dialog. Standalone script byte parity preserved.
  • Regression: native/source operator tests assert cached vs explicit scan, fail-closed mask/rate and capped rescan; Chromium mock checks manual refresh only on operator click.

Pinned JUCE 8.0.15 setCurrentAudioDeviceType() can intentionally sleep ~1500ms during backend switching and vendor scanForDevices() may still block on malicious/buggy drivers; this PR eliminates unnecessary scans but does not falsely claim unconditional immunity to vendor hangs. MAONO/ASIO physical FAT and #15 crackle remain release evidence gates.

Gate: Chromium + native Windows CTest + packaging at one exact head. PR build does not upload; existing main FAT is available in run 41164371465. Merge only with green native/GUI checks.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T03:51:12.209954Z 0d75fce PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Superseded integration path (2026-10-31). GitHub refused direct merge of this old-head PR after selected-channel SOURCE2 #233 merged. This PR is now Draft to prevent accidental stale integration. All five DEVICE2 code/test patches were reapplied with unique exact-context matches onto main@a7fb6151 in #234 (152ae0bd6e0c760af52d3a1afc13ba82290c6b41), preserving the newer SOURCE picker. Chromium on #234 PASS, Windows native CI still running at posting. Review/merge #234 only after exact-head Windows gate passes; then close this PR as superseded. Hardware crackle issue #15 remains unqualified.

Copy link
Copy Markdown
Owner Author

Superseded, safely reconciled. The entire DEVICE2 cached JUCE inventory / explicit guarded driver scan / active pin-rate-buffer verification was selectively rebased over merged SOURCE2 (#233) in integration PR #234. #234 exact head 152ae0bd6e0c760af52d3a1afc13ba82290c6b41 passed Chromium run 41173141028 and Windows native CTest/packaging run 41173140873, and is merged to main at 7db4ab70a4c971487e0b921df5a4e8cc805f0183. Closing #232 without separately merging this old head prevents overwriting the newer SOURCE2 operator flow. Physical ASIO/WASAPI FAT and issue #15 crackle remain OPEN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant