Repository navigation
M1 integration: DEVICE2 guarded hardware scan + merged SOURCE2 operator flow - #234
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated operator reliability milestone
Converges DEVICE2 #232 (previous PR CI passed but merge rejected after main moved) with merged SOURCE2 #233 on
main@a7fb61511ffe27fdef1f9923695daf6899646dff. Every one of the five DEVICE2 patches was reapplied with unique exact-context matching, preserving the newer selected-channel SOURCE chooser.Native behavior: opening Audio I/O reads the cached JUCE hardware inventory, never repeats vendor ASIO/WASAPI scan; explicit operator REFRESH triggers a guarded scan only while all outputs are disarmed and no independent-clock, diagnostic, graph switch, Show or backup transition is active. Successful custom device apply additionally verifies opened device channel masks and actual sample rate/buffer against accepted JUCE setup, rejecting mismatches. No automatic unmute.
UI and regression: preserves SOURCE2 native muted source chooser with verified pins, native route ACK, live AUX faders, MAIN/MONITOR/OUTPUT1, VST3/Show, one JUCE device manager and graph. Changes are limited to
src/Main.cpp,web/mixer-io.js, matching standalone HTML, and two existing operator regression tests. No fake channels, WebAudio DSP, worker, second device API, or CSS-heavy controls.Gates: exact new PR-head Windows MSVC/CTest/package and Chromium must pass, then verify source/hardware integration and assess merging. Previous #232 CI was green on its own old head; not evidence that this combined head is green. Physical ASIO/WASAPI and zero-FX crackle issue #15 remain unqualified. Do not label full operator-ready release. Supersedes #232 once accepted.