Skip to content

M1 integration: DEVICE2 guarded hardware scan + merged SOURCE2 operator flow - #234

Merged
masarray merged 1 commit into
mainfrom
feat/m1-device2-source2-reconciled-20261031
Oct 31, 2026
Merged

masarray merged 1 commit into
mainfrom
feat/m1-device2-source2-reconciled-20261031

Conversation

@masarray

Copy link
Copy Markdown
Owner

Integrated operator reliability milestone

Converges DEVICE2 #232 (previous PR CI passed but merge rejected after main moved) with merged SOURCE2 #233 on main@a7fb61511ffe27fdef1f9923695daf6899646dff. Every one of the five DEVICE2 patches was reapplied with unique exact-context matching, preserving the newer selected-channel SOURCE chooser.

Native behavior: opening Audio I/O reads the cached JUCE hardware inventory, never repeats vendor ASIO/WASAPI scan; explicit operator REFRESH triggers a guarded scan only while all outputs are disarmed and no independent-clock, diagnostic, graph switch, Show or backup transition is active. Successful custom device apply additionally verifies opened device channel masks and actual sample rate/buffer against accepted JUCE setup, rejecting mismatches. No automatic unmute.

UI and regression: preserves SOURCE2 native muted source chooser with verified pins, native route ACK, live AUX faders, MAIN/MONITOR/OUTPUT1, VST3/Show, one JUCE device manager and graph. Changes are limited to src/Main.cpp, web/mixer-io.js, matching standalone HTML, and two existing operator regression tests. No fake channels, WebAudio DSP, worker, second device API, or CSS-heavy controls.

Gates: exact new PR-head Windows MSVC/CTest/package and Chromium must pass, then verify source/hardware integration and assess merging. Previous #232 CI was green on its own old head; not evidence that this combined head is green. Physical ASIO/WASAPI and zero-FX crackle issue #15 remain unqualified. Do not label full operator-ready release. Supersedes #232 once accepted.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T05:35:52.320620Z 152ae0b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant