Skip to content

docs(devlog): record dev release readiness and the raw-bun-test harness trap - #1783

Merged
lidge-jun merged 1 commit into
devfrom
codex/release-readiness-260815
Aug 15, 2026
Merged

docs(devlog): record dev release readiness and the raw-bun-test harness trap#1783
lidge-jun merged 1 commit into
devfrom
codex/release-readiness-260815

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Summary

Records that dev @ 4b95010 passes every repository gate, and documents a harness misuse that made the suite look broken when it was not.

An earlier full-suite run in this session invoked bun test directly and reported 122 failures. That count also appeared unchanged on the pre-session baseline, which is what first indicated it was not caused by any recent change.

bun test is not this suite's entry point. package.json maps test to scripts/test.ts, which builds an isolated environment per run — a mkdtemp root with HOME, USERPROFILE, OPENCODEX_HOME, and CODEX_HOME inside it, plus OCX_REAL_HOME captured before the rewrite. Run raw, none of that exists: suites that persist config resolved to the operator's real ~/.opencodex, and assertNotRealHomeUnderTest correctly refused the write. All 122 failures are that refusal surfacing downstream as empty usageRows(), a missing admissionKind, or a 503 where a 429 was expected.

The guard behaved exactly as designed. No product change was needed, and none is made here — this PR is documentation only.

Verification

Run on the Linux validation host against this exact head:

bun run test        12388 pass, 11 skip, 0 fail, 158046 expect() across 789 files (447.98s)
bun run typecheck   clean
bun run privacy:scan  Privacy scan passed
bun run build:gui   built, package prepared
bun run lint:gui    0 warnings, 0 errors

CI on 4b95010: ci, gates, test 1-4/4, macos, keyring (ubuntu/macos/windows), npm-global (ubuntu/macos/windows), storage policy, api usage — all success.

origin/dev, the local checkout, and the validation host all sit on 4b950101a1116d8bac4e479cb2dceca3bb80370e.

Corroboration that the failures were environmental: the same files pass in isolation, a six-file group of the heaviest offenders passes 216/216, and the full suite through the real entry point reports zero failures.

Checklist

  • Documentation only; no runtime code changed
  • Full suite, typecheck, privacy scan, GUI build and lint all green on this head
  • No credentials, request bodies, or account identifiers recorded
  • Makes no release claim — no version bump, tag, publish, or promotion

Summary by CodeRabbit

  • Documentation
    • Added a release-readiness record documenting successful validation across tests, type checking, privacy checks, builds, linting, and continuous integration.
    • Documented validation alignment and clarified test results from the supported isolated test environment.
  • Release Management
    • Confirmed that no release, version update, publication, or branch promotion was performed.

…ss trap

Every repository gate is green on dev @ 4b95010: full suite 12388 pass /
0 fail, typecheck, privacy scan, GUI build and lint, and CI across Linux,
macOS and Windows.

Also documents why a raw 'bun test' run reported 122 failures. That entry
point skips scripts/test.ts, so suites resolved OPENCODEX_HOME to the real
home and the write guard refused them. The guard was right; the harness was
missing.
@lidge-jun
lidge-jun merged commit 6df428d into dev Aug 15, 2026
6 of 7 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 15, 2026
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 380912e4-c27e-4ae6-89d5-4888de6eaf56

📥 Commits

Reviewing files that changed from the base of the PR and between 4b95010 and 188e021.

📒 Files selected for processing (1)
  • devlog/_plan/260815_roadmap_closeout/110_release_readiness.md

📝 Walkthrough

Walkthrough

The PR adds a release-readiness record for dev. It documents validation results, test-environment safeguards, commit alignment, and the absence of release promotion actions.

Changes

Release readiness

Layer / File(s) Summary
Release validation record
devlog/_plan/260815_roadmap_closeout/110_release_readiness.md
Documents test, typecheck, privacy, GUI, and CI gate results. It distinguishes bun run test from raw bun test, records isolated test-environment protections, confirms commit alignment, and states that no release promotion occurred.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: ingwannu, wibias

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/release-readiness-260815

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 188e0215cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +32 to +36
Run raw, none of that exists. Suites that persist config resolved to the operator's actual
`~/.opencodex`, where `assertNotRealHomeUnderTest` correctly refused the write. Every one of
the 122 failures is that refusal surfacing as a downstream assertion — empty `usageRows()`,
a missing `admissionKind`, a 503 where a 429 was expected. The guard did exactly its job; the
harness was simply absent.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Correct the raw bun test diagnosis

On this exact parent, a bare bun test still loads bunfig.toml, whose [test].preload points to tests/preload.ts; that preload calls createIsolatedTestEnvironment(), rewrites HOME, USERPROFILE, OPENCODEX_HOME, and CODEX_HOME, and arms the real-home guard (tests/preload.ts:14-34). The checked bun test --help describes the bare invocation as “Run all test files” and exposes no flag used here to bypass repository test configuration. Consequently, a normal raw invocation on this head cannot have resolved persistence to the operator's real home as claimed, so this record misattributes the 122 failures and could derail future triage. Correct the diagnosis or document the concrete invocation/environment that bypassed bunfig.toml.

Useful? React with 👍 / 👎.

@Wibias
Wibias deleted the codex/release-readiness-260815 branch August 15, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant