docs(devlog): record dev release readiness and the raw-bun-test harness trap - #1783
Conversation
…ss trap Every repository gate is green on dev @ 4b95010: full suite 12388 pass / 0 fail, typecheck, privacy scan, GUI build and lint, and CI across Linux, macOS and Windows. Also documents why a raw 'bun test' run reported 122 failures. That entry point skips scripts/test.ts, so suites resolved OPENCODEX_HOME to the real home and the write guard refused them. The guard was right; the harness was missing.
|
✅ Deterministic PR hygiene checks passed. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds a release-readiness record for ChangesRelease readiness
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 188e0215cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Run raw, none of that exists. Suites that persist config resolved to the operator's actual | ||
| `~/.opencodex`, where `assertNotRealHomeUnderTest` correctly refused the write. Every one of | ||
| the 122 failures is that refusal surfacing as a downstream assertion — empty `usageRows()`, | ||
| a missing `admissionKind`, a 503 where a 429 was expected. The guard did exactly its job; the | ||
| harness was simply absent. |
There was a problem hiding this comment.
Correct the raw
bun test diagnosis
On this exact parent, a bare bun test still loads bunfig.toml, whose [test].preload points to tests/preload.ts; that preload calls createIsolatedTestEnvironment(), rewrites HOME, USERPROFILE, OPENCODEX_HOME, and CODEX_HOME, and arms the real-home guard (tests/preload.ts:14-34). The checked bun test --help describes the bare invocation as “Run all test files” and exposes no flag used here to bypass repository test configuration. Consequently, a normal raw invocation on this head cannot have resolved persistence to the operator's real home as claimed, so this record misattributes the 122 failures and could derail future triage. Correct the diagnosis or document the concrete invocation/environment that bypassed bunfig.toml.
Useful? React with 👍 / 👎.
Summary
Records that
dev@ 4b95010 passes every repository gate, and documents a harness misuse that made the suite look broken when it was not.An earlier full-suite run in this session invoked
bun testdirectly and reported 122 failures. That count also appeared unchanged on the pre-session baseline, which is what first indicated it was not caused by any recent change.bun testis not this suite's entry point.package.jsonmapstesttoscripts/test.ts, which builds an isolated environment per run — amkdtemproot withHOME,USERPROFILE,OPENCODEX_HOME, andCODEX_HOMEinside it, plusOCX_REAL_HOMEcaptured before the rewrite. Run raw, none of that exists: suites that persist config resolved to the operator's real~/.opencodex, andassertNotRealHomeUnderTestcorrectly refused the write. All 122 failures are that refusal surfacing downstream as emptyusageRows(), a missingadmissionKind, or a 503 where a 429 was expected.The guard behaved exactly as designed. No product change was needed, and none is made here — this PR is documentation only.
Verification
Run on the Linux validation host against this exact head:
CI on 4b95010:
ci,gates,test 1-4/4,macos,keyring(ubuntu/macos/windows),npm-global(ubuntu/macos/windows),storage policy,api usage— all success.origin/dev, the local checkout, and the validation host all sit on4b950101a1116d8bac4e479cb2dceca3bb80370e.Corroboration that the failures were environmental: the same files pass in isolation, a six-file group of the heaviest offenders passes 216/216, and the full suite through the real entry point reports zero failures.
Checklist
Summary by CodeRabbit