-
Notifications
You must be signed in to change notification settings - Fork 755
docs(devlog): record dev release readiness and the raw-bun-test harness trap #1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+48
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
48 changes: 48 additions & 0 deletions
48
devlog/_plan/260815_roadmap_closeout/110_release_readiness.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # 110 — Release readiness for `dev` @ 4b950101a | ||
|
|
||
| ## Outcome | ||
|
|
||
| `dev` is release-ready. Every repository gate is green on the exact head, on the Linux | ||
| validation host and in CI across all three platforms. | ||
|
|
||
| | Gate | Result | | ||
| |------|--------| | ||
| | `bun run test` | 12388 pass, 11 skip, **0 fail**, 158046 expect() across 789 files (447.98s) | | ||
| | `bun run typecheck` | clean | | ||
| | `bun run privacy:scan` | passed | | ||
| | `bun run build:gui` | built, package prepared | | ||
| | `bun run lint:gui` | 0 warnings, 0 errors | | ||
| | CI @ 4b950101a | ci, gates, test 1-4/4, macos, keyring x3, npm-global x3, storage policy, api usage — all success | | ||
|
|
||
| `origin/dev`, the local checkout, and the remote validation host all sit on | ||
| `4b950101a1116d8bac4e479cb2dceca3bb80370e`. | ||
|
|
||
| ## The "122 failures" were a harness misuse, not a defect | ||
|
|
||
| An earlier run in this session invoked `bun test` directly and reported 122 failures. That | ||
| number was an artifact of the invocation, and the same 122 appeared on the pre-session | ||
| baseline, which is what first suggested it was not caused by any change here. | ||
|
|
||
| `bun test` is not the suite's entry point. `package.json` maps `test` to | ||
| `scripts/test.ts`, which builds an isolated environment per run: a `mkdtemp` root with | ||
| `HOME`, `USERPROFILE`, `OPENCODEX_HOME`, and `CODEX_HOME` pointed inside it, plus | ||
| `OCX_REAL_HOME` captured before the rewrite so the real-home write guard still knows which | ||
| path to protect. | ||
|
|
||
| Run raw, none of that exists. Suites that persist config resolved to the operator's actual | ||
| `~/.opencodex`, where `assertNotRealHomeUnderTest` correctly refused the write. Every one of | ||
| the 122 failures is that refusal surfacing as a downstream assertion — empty `usageRows()`, | ||
| a missing `admissionKind`, a 503 where a 429 was expected. The guard did exactly its job; the | ||
| harness was simply absent. | ||
|
|
||
| Confirmation: the same files pass in isolation and in groups (216/216 for the six heaviest), | ||
| and the full suite under `bun run test` reports 0 failures. | ||
|
|
||
| **Operational note:** run `bun run test` on this repository. Raw `bun test` writes to the real | ||
| home, is refused, and produces failures that look like product defects. | ||
|
|
||
| ## Not claimed here | ||
|
|
||
| This records that `dev` passes its gates. It is not a release: no version bump, tag, npm | ||
| publish, or promotion to `preview`/`main` was performed, and `scripts/release.ts` remains the | ||
| only authority for those. | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bun testdiagnosisOn this exact parent, a bare
bun teststill loadsbunfig.toml, whose[test].preloadpoints totests/preload.ts; that preload callscreateIsolatedTestEnvironment(), rewritesHOME,USERPROFILE,OPENCODEX_HOME, andCODEX_HOME, and arms the real-home guard (tests/preload.ts:14-34). The checkedbun test --helpdescribes the bare invocation as “Run all test files” and exposes no flag used here to bypass repository test configuration. Consequently, a normal raw invocation on this head cannot have resolved persistence to the operator's real home as claimed, so this record misattributes the 122 failures and could derail future triage. Correct the diagnosis or document the concrete invocation/environment that bypassedbunfig.toml.Useful? React with 👍 / 👎.