Skip to content

docs(devlog): correct the 122-failure root cause to the missing --isolate - #1787

Merged
lidge-jun merged 1 commit into
devfrom
codex/fix-110-rootcause
Aug 15, 2026
Merged

docs(devlog): correct the 122-failure root cause to the missing --isolate#1787
lidge-jun merged 1 commit into
devfrom
codex/fix-110-rootcause

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Aug 15, 2026

Copy link
Copy Markdown
Owner

Summary

Corrects the root cause recorded in #1783. That note blamed a missing sandbox from scripts/test.ts; that was wrong, and the correction matters because it pointed at the wrong defense.

tests/preload.ts is registered in bunfig.toml exactly so a bare bun test still gets a sandbox and an armed guard. That defense works — a bare bun test <file> on a single file passes.

The actual trigger is the missing --isolate. scripts/test.ts spawns bun test --isolate ./tests/; without it Bun shares one process across all 789 files. The preload runs once per process, so any suite that mutates process.env.OPENCODEX_HOME or restores a captured environment in afterEach can leave a later file pointing at the real home. The guard then correctly refuses, and the refusal surfaces as an unrelated downstream assertion.

Verification

Same host, same commit, same machine:

bun test                     67 refusals, 122 failures
bun test --isolate tests      0 refusals,   0 failures  (12388 pass / 11 skip)
bun run test                  0 refusals,   0 failures  (12388 pass / 11 skip)

The middle row isolates the variable: no wrapper, no sandbox hand-off, only --isolate plus the preload — and it is fully green. It is also the exact command scripts/release.ts runs in preflight, so the release gate is unaffected.

Checklist

  • Documentation only; no runtime code changed
  • Claim verified by controlled measurement rather than inference
  • No credentials or account identifiers recorded

Summary by CodeRabbit

  • Documentation
    • Clarified the cause of previously reported test failures.
    • Documented the differences between available test commands and their isolation behavior.
    • Updated operational guidance to recommend the standard test command for reliable results.

…late

The previous note blamed an absent sandbox. bunfig.toml preloads
tests/preload.ts for every bun test invocation, so the sandbox is always
present and a bare 'bun test <file>' passes.

The real trigger is process sharing: without --isolate all 789 files run in
one process behind a single preload, so a suite that mutates OPENCODEX_HOME
can leave a later file pointing at the real home. Measured: bun test = 67
refusals/122 fails, bun test --isolate tests = 0/0.
@lidge-jun
lidge-jun merged commit 9db1676 into dev Aug 15, 2026
6 of 7 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 15, 2026
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1bee2d28-256c-40f1-bee2-4fed07d1e3e8

📥 Commits

Reviewing files that changed from the base of the PR and between 6df428d and 7b7823a.

📒 Files selected for processing (1)
  • devlog/_plan/260815_roadmap_closeout/110_release_readiness.md

📝 Walkthrough

Walkthrough

The release-readiness document now attributes 122 test failures to running Bun without --isolate. It documents preload behavior, OPENCODEX_HOME leakage, measured command results, and recommends bun run test.

Changes

Release readiness documentation

Layer / File(s) Summary
Bun test isolation guidance
devlog/_plan/260815_roadmap_closeout/110_release_readiness.md:20-55
The document replaces the missing-harness explanation with process-sharing behavior. It records cross-file OPENCODEX_HOME leakage, downstream failures, command comparisons, measured results, and recommended test commands.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • lidge-jun/opencodex#1783: Both PRs update the same release-readiness document and explain the 122 raw bun test failures through test isolation behavior.

Suggested reviewers: ingwannu

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-110-rootcause

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Wibias
Wibias deleted the codex/fix-110-rootcause branch August 15, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant