Repository navigation
[Vulcan] Clarify parsed-part mutation and fixed dictionary rendering - #20
Merged
Merged
Conversation
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbstractPart::setValue()comment that incorrectly described all mapped parts as frozen. Ordinary name parts invalidate their camelcase cache, and initials read their current value; only pre-normalized dictionary parts retain constructor rendering.Name::setParts(), and retain awareness that part edits do not update source or rerun parsing.Verification
git diff --checkpassed.Smith→Jones, current-value initials, fixed salutation/suffix/surname-prefix/middle-prefix rendering after raw mutation, replacement suffixPhD, sharedgetParts()objects, and unchanged original source.34110f3310246d3c02a3c234f2f08c94982a2ee1matches the tested local tree, including every file and mode.No tests were added because this corrects documentation of existing behavior; the existing cache-invalidation and partner-isolation tests remain unchanged. PHP 8.3/8.5 and repository CI will be verified on this exact head.