Repository navigation
[Vulcan] Clarify custom nickname comma shielding limit - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changed parser outputs: none. This documents a current limitation; it does not fix parsing of long custom-delimiter rows.
Evidence and scope
Thirty exact BASE/HEAD probes cover 4,095 / 4,096 / 4,097 bytes, with and without nickname commas:
<</>>and Unicode«/»preserve them through 4,096 bytes, but treat them as structural above that point.Reviewed normalization, sanitization, both delimiter endpoints, shared structural splitting/masking, parser and confidence callers, and existing boundary coverage. Long custom-delimiter inputs remain subject to the documented limitation; nesting/comma caps and overall input limits are unchanged. Executable PHP tokens are identical to BASE in both changed PHP files. No runtime regression test was added to endorse the existing field loss.
Patch hunks are disjoint from open #20 and #21, including their README and changelog edits.
Verification
Base:
e93f6afa3d25baa7b0a8de74c7488aacfb03408eHead:
f865657c3a167bde71753a92c4e016a477b9b4f1Tree:
edddf78678aebb8d80bcc4f858c039821f0b3120