Repository navigation
[Vulcan] Document given-name loss in surname-particle chains - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Della van Bergincorrectly produces an empty first name when Della is the intended given name.van Berg, Della, including credential tails.Della Smith, MD/Van Smith, MD).This is documentation only, not a runtime fix. Changed parser outputs: none. Both modified PHP files have identical executable tokens to the base (comments/whitespace excluded). No new regression test is added to enshrine the known wrong interpretation.
Path sweep and remaining limitation
Della van Berg,Della van der Berg, andVan de Berg.Della (Bob) van Berg,(Bob) Della van Berg,Della van (Bob) Berg, andDella van Berg (Bob)retain the nickname but still lose the given-name field.Della van Berg, MDremains wrong.van Berg, Della,van der Berg, Della, and credential/nickname variants preserve the intended fields.Della Smith,Van Smith,van der Berg, and the established credential-tail cases remain unchanged.Verification
1b072166211c9f0287af61f3e471a547ebaeef56.Base:
e93f6afa3d25baa7b0a8de74c7488aacfb03408eHead:
0318172f6c1e8478aebc11981b8f4c678a9e1d80