Add qsonToADIF baseline tests for segment context handling - #207
Merged
sd merged 1 commit intoMay 8, 2026
Merged
Conversation
rwjblue
marked this pull request as ready for review
March 1, 2026 04:13
sd
approved these changes
Mar 1, 2026
rwjblue
force-pushed
the
rwjblue/add-qsontoadif-segment-context-tests
branch
3 times, most recently
from
March 1, 2026 19:10
d30d144 to
514d7f9
Compare
Contributor
Author
|
Rebased now that we have CI running jest tests, all green now. |
These tests establish baseline coverage before the section-context refactor so behavior changes in ADIF export are caught early. Coverage verifies how start/break events update export context, how combineSegmentRefs affects ref propagation, and that deleted segment events do not change the active context used for later QSOs.
rwjblue
force-pushed
the
rwjblue/add-qsontoadif-segment-context-tests
branch
from
March 25, 2026 19:05
514d7f9 to
5a35dfb
Compare
sd
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qsonToADIFsegment-context behavior before the section-context refactor lands.combineSegmentRefsbehavior for keeping original refs vs switching to segment refs.start/breakevents do not update active segment context.Why now
This is intended as a guardrail for the refactors in #204. The goal is to ensure behavior is fully tested before/after refactoring so we can detect any breakage confidently.
Test plan
npm test -- --runInBand src/tools/qsonToADIF.spec.jsDependencies
Stack