Add qsonTools tests before utility refactors - #206
Merged
Conversation
sd
requested changes
Mar 1, 2026
sd
left a comment
sd
left a comment
Contributor
There was a problem hiding this comment.
Needs a couple of minor additions
rwjblue
force-pushed
the
rwjblue/add-qson-tools-tests
branch
3 times, most recently
from
March 1, 2026 15:55
88335ba to
c62eac9
Compare
Contributor
Author
|
Thanks for the review, updated! |
rwjblue
force-pushed
the
rwjblue/add-qson-tools-tests
branch
2 times, most recently
from
March 1, 2026 19:10
cd79e30 to
395f10e
Compare
Contributor
Author
|
Rebased now that we have CI running jest tests. |
These tests lock in current qsonTools behavior before upcoming refactors to reduce the risk of accidental regressions. Coverage includes section context transitions via start/break events, default handling of event/deleted records, and near-dupe matching rules for call, timestamp ordering, UUID exclusion, and section constraints.
rwjblue
force-pushed
the
rwjblue/add-qson-tools-tests
branch
from
March 25, 2026 19:05
395f10e to
ff32a30
Compare
sd
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
qsonTools, covering bothfilterQSOsWithSectionRefsandfilterNearDupes.start/break), malformed/valid section refs, and default event/deleted filtering.Why now
I have refactors in flight in #204, and I want these tests in first so we can move faster there without accidentally changing existing utility behavior.
Test plan
npm test -- --runInBand src/tools/qsonTools.spec.jsStack