Skip to content

Use section timeline context for roving map QSO origins - #204

Open
rwjblue wants to merge 1 commit into
ham2k:mainfrom
rwjblue:rwjblue/section-timeline-roving-map-origins
Open

Use section timeline context for roving map QSO origins#204
rwjblue wants to merge 1 commit into
ham2k:mainfrom
rwjblue:rwjblue/section-timeline-roving-map-origins

Conversation

@rwjblue

@rwjblue rwjblue commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

Map lines and distance calculations were using the operation's final location, which made roving logs look like every contact came from the last stop.

This changes map rendering to follow the same section timeline model used elsewhere: we derive per-QSO origin context from start/break snapshots and render each contact from the location active at log time. The same shared timeline helper is now used by ADIF traversal as well, so segment behavior stays aligned instead of being reimplemented in separate places.

This also updates @ham2k/lib-qson-tools to 1.3.1 for the shared section-context helpers and CommonJS package export used by the current Jest setup.

Test plan

  • Create or load a multi-stop roving operation with start/break events and verify map lines originate from the location active when each QSO was logged.
  • Verify single-grid operations render map lines and distances as before.
  • Export ADIF for a segmented operation and confirm segment-based refs/grid behavior remains consistent.

Local validation

  • npm test -- --runInBand --watchman=false src/tools/qsonToADIF.spec.js
  • npx eslint src/tools/qsonToADIF.js src/screens/OperationBadgeScreen/OperationBadgeScreen.jsx src/screens/OperationScreens/OpMapTab/OpMapTab.jsx src/screens/OperationScreens/OpMapTab/components/MapWithQSOs.jsx src/screens/OperationScreens/OpMapTab/components/MapboxMapWithQSOs.jsx
  • npm test -- --runInBand --watchman=false
  • clean temp install with Node 22: npm ci && npm test -- --ci

Screenshots

Single point

2026-06-13 at 15 09 47

Multiple points

2026-06-13 at 15 07 49 2026-06-13 at 15 09 12

@rwjblue

rwjblue commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

I tried to run npm run lint, but it doesn't seem to be working at the moment (#205 starts working on that). I'll run prettier at least to make sure that formatting of the new files is right.

@rwjblue
rwjblue force-pushed the rwjblue/section-timeline-roving-map-origins branch 4 times, most recently from 05e703f to 4d68d0f Compare March 1, 2026 04:10
@rwjblue
rwjblue force-pushed the rwjblue/section-timeline-roving-map-origins branch 5 times, most recently from 0a761bd to c855eb0 Compare March 1, 2026 19:10
@rwjblue
rwjblue force-pushed the rwjblue/section-timeline-roving-map-origins branch from c855eb0 to 7fe1a3f Compare March 25, 2026 19:05
@rwjblue
rwjblue force-pushed the rwjblue/section-timeline-roving-map-origins branch from 7fe1a3f to 946e83e Compare May 11, 2026 16:31
@rwjblue
rwjblue force-pushed the rwjblue/section-timeline-roving-map-origins branch 4 times, most recently from 41073ca to 11595b3 Compare June 13, 2026 14:54
@rwjblue
rwjblue marked this pull request as ready for review June 13, 2026 14:56
@rwjblue
rwjblue force-pushed the rwjblue/section-timeline-roving-map-origins branch from 11595b3 to 25edbd3 Compare June 13, 2026 15:16
@rwjblue
rwjblue marked this pull request as draft June 13, 2026 16:40
@rwjblue

This comment was marked as resolved.

@rwjblue

This comment was marked as resolved.

@rwjblue
rwjblue force-pushed the rwjblue/section-timeline-roving-map-origins branch from 25edbd3 to f1d6bfa Compare June 13, 2026 19:10
@rwjblue
rwjblue marked this pull request as ready for review June 13, 2026 19:12
@rwjblue
rwjblue marked this pull request as draft June 13, 2026 19:34
@rwjblue
rwjblue force-pushed the rwjblue/section-timeline-roving-map-origins branch from f1d6bfa to dc6471a Compare June 13, 2026 19:46
@rwjblue
rwjblue marked this pull request as ready for review June 13, 2026 19:49
@rwjblue
rwjblue force-pushed the rwjblue/section-timeline-roving-map-origins branch from dc6471a to 59d2d28 Compare June 16, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant