Use section timeline context for roving map QSO origins - #204
Open
rwjblue wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
I tried to run |
rwjblue
force-pushed
the
rwjblue/section-timeline-roving-map-origins
branch
4 times, most recently
from
March 1, 2026 04:10
05e703f to
4d68d0f
Compare
rwjblue
force-pushed
the
rwjblue/section-timeline-roving-map-origins
branch
5 times, most recently
from
March 1, 2026 19:10
0a761bd to
c855eb0
Compare
rwjblue
force-pushed
the
rwjblue/section-timeline-roving-map-origins
branch
from
March 25, 2026 19:05
c855eb0 to
7fe1a3f
Compare
rwjblue
force-pushed
the
rwjblue/section-timeline-roving-map-origins
branch
from
May 11, 2026 16:31
7fe1a3f to
946e83e
Compare
rwjblue
force-pushed
the
rwjblue/section-timeline-roving-map-origins
branch
4 times, most recently
from
June 13, 2026 14:54
41073ca to
11595b3
Compare
rwjblue
marked this pull request as ready for review
June 13, 2026 14:56
rwjblue
force-pushed
the
rwjblue/section-timeline-roving-map-origins
branch
from
June 13, 2026 15:16
11595b3 to
25edbd3
Compare
rwjblue
marked this pull request as draft
June 13, 2026 16:40
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
rwjblue
force-pushed
the
rwjblue/section-timeline-roving-map-origins
branch
from
June 13, 2026 19:10
25edbd3 to
f1d6bfa
Compare
rwjblue
marked this pull request as ready for review
June 13, 2026 19:12
rwjblue
marked this pull request as draft
June 13, 2026 19:34
rwjblue
force-pushed
the
rwjblue/section-timeline-roving-map-origins
branch
from
June 13, 2026 19:46
f1d6bfa to
dc6471a
Compare
rwjblue
marked this pull request as ready for review
June 13, 2026 19:49
rwjblue
force-pushed
the
rwjblue/section-timeline-roving-map-origins
branch
from
June 16, 2026 21:51
dc6471a to
59d2d28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map lines and distance calculations were using the operation's final location, which made roving logs look like every contact came from the last stop.
This changes map rendering to follow the same section timeline model used elsewhere: we derive per-QSO origin context from
start/breaksnapshots and render each contact from the location active at log time. The same shared timeline helper is now used by ADIF traversal as well, so segment behavior stays aligned instead of being reimplemented in separate places.This also updates
@ham2k/lib-qson-toolsto1.3.1for the shared section-context helpers and CommonJS package export used by the current Jest setup.Test plan
start/breakevents and verify map lines originate from the location active when each QSO was logged.Local validation
npm test -- --runInBand --watchman=false src/tools/qsonToADIF.spec.jsnpx eslint src/tools/qsonToADIF.js src/screens/OperationBadgeScreen/OperationBadgeScreen.jsx src/screens/OperationScreens/OpMapTab/OpMapTab.jsx src/screens/OperationScreens/OpMapTab/components/MapWithQSOs.jsx src/screens/OperationScreens/OpMapTab/components/MapboxMapWithQSOs.jsxnpm test -- --runInBand --watchman=falsenpm ci && npm test -- --ciScreenshots
Single point
Multiple points