Skip to content

fix: docling stop relying on haystack.utils.base_serialization helpers#3562

Merged
davidsbatista merged 9 commits into
mainfrom
fix/docling-avoid-removed-serialization-helpers
Jul 8, 2026
Merged

fix: docling stop relying on haystack.utils.base_serialization helpers#3562
davidsbatista merged 9 commits into
mainfrom
fix/docling-avoid-removed-serialization-helpers

Conversation

@davidsbatista

@davidsbatista davidsbatista commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

  • Removes DoclingConverter's dependency on serialize_class_instance/deserialize_class_instance (being deleted from haystack-ai as dead code).
  • Now uses component_to_dict/deserialize_chatgenerator_inplace for the meta_extractor field, and BaseMetaExtractor.to_dict/from_dict use default_to_dict/default_from_dict.
  • Bumped minimum haystack-ai to 2.12.0 since deserialize_chatgenerator_inplace isn't available before that.

How did you test it?

  • Updated test_converter.py fixtures; unit tests, ruff, mypy all pass, including lowest-dependency CI.

Checklist

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Coverage report (docling)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/docling/src/haystack_integrations/components/converters/docling
  converter.py
Project Total  

This report was generated by python-coverage-comment-action

@davidsbatista davidsbatista marked this pull request as ready for review July 8, 2026 12:49
@davidsbatista davidsbatista requested a review from a team as a code owner July 8, 2026 12:49
@davidsbatista davidsbatista requested review from sjrl and removed request for a team July 8, 2026 12:49
@davidsbatista davidsbatista requested review from anakin87 and removed request for sjrl July 8, 2026 13:11
@davidsbatista davidsbatista merged commit 10019ff into main Jul 8, 2026
17 checks passed
@davidsbatista davidsbatista deleted the fix/docling-avoid-removed-serialization-helpers branch July 8, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants