Skip to content

feat: expose deserialize_component_inplace#11913

Merged
davidsbatista merged 3 commits into
mainfrom
feat/export-deserialize-component-inplace
Jul 9, 2026
Merged

feat: expose deserialize_component_inplace#11913
davidsbatista merged 3 commits into
mainfrom
feat/export-deserialize-component-inplace

Conversation

@davidsbatista

@davidsbatista davidsbatista commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes:

  • deserialize_chatgenerator_inplace is a thin wrapper around deserialize_component_inplace (the actual logic), but only the wrapper is exported in haystack.utils

  • 4 callers of deserialize_chatgenerator_inplace are deserializing something that isn't a chat generator:

    • opensearch/open_search_hybrid_retriever.py:344 (key="embedder")
    • elasticsearch/elasticsearch_hybrid_retriever.py:338 (key="embedder")
    • docling/converter.py:205 (key="meta_extractor")
    • langfuse/langfuse_connector.py:238 (key="span_handler")

How did you test it?

  • No new tests needed — this is a pure export of an already implemented and tested private function

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
haystack-docs Ready Ready Preview, Comment Jul 9, 2026 9:46am

Request Review

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/utils
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

@davidsbatista davidsbatista marked this pull request as ready for review July 8, 2026 13:51
@davidsbatista davidsbatista requested a review from a team as a code owner July 8, 2026 13:51
@davidsbatista davidsbatista requested review from bogdankostic and removed request for a team July 8, 2026 13:51
@davidsbatista davidsbatista added the ignore-for-release-notes PRs with this flag won't be included in the release notes. label Jul 9, 2026
@davidsbatista davidsbatista enabled auto-merge (squash) July 9, 2026 10:16
@davidsbatista davidsbatista merged commit 525f376 into main Jul 9, 2026
29 of 30 checks passed
@davidsbatista davidsbatista deleted the feat/export-deserialize-component-inplace branch July 9, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release-notes PRs with this flag won't be included in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants