chore!: removing deadcode#11905
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
julian-risch
left a comment
There was a problem hiding this comment.
Looks good to me in general but there are two integrations that use this code and we should update them before making changes in Haystack: docling and langfuse
https://github.com/search?q=org%3Adeepset-ai+serialize_class_instance+language%3APython&type=code&l=Python
https://github.com/search?q=org%3Adeepset-ai+deserialize_class_instance+language%3APython&type=code
If possible, we should make changes in the integrations in a way that the new releases of integrations are still compatible with Haystack 2.x
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
julian-risch
left a comment
There was a problem hiding this comment.
Looks good to me. It's a breaking change so it's fair that we have an upgrade section in release notes. Good that the two integrations were updated.
Related Issues
Proposed Changes:
serialize_class_instance/deserialize_class_instanceinutils/base_serialization.pyare dead code — not exported fromhaystack.utils, and no caller anywhere in the codebase besides their own unit tests.How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.