Skip to content

chore!: removing deadcode#11905

Merged
davidsbatista merged 5 commits into
mainfrom
chore/remove-de-serialize_class_instance-v3
Jul 8, 2026
Merged

chore!: removing deadcode#11905
davidsbatista merged 5 commits into
mainfrom
chore/remove-de-serialize_class_instance-v3

Conversation

@davidsbatista

Copy link
Copy Markdown
Contributor

Related Issues

Proposed Changes:

  • serialize_class_instance/deserialize_class_instance in utils/base_serialization.py are dead code — not exported from haystack.utils, and no caller anywhere in the codebase besides their own unit tests.

How did you test it?

  • Ran the full tests, all pass. Grepped the whole repo for any remaining reference to either function, none found.

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@davidsbatista davidsbatista requested a review from a team as a code owner July 7, 2026 15:59
@davidsbatista davidsbatista requested review from julian-risch and removed request for a team July 7, 2026 15:59
@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Jul 8, 2026 1:33pm

Request Review

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/utils
  base_serialization.py
Project Total  

This report was generated by python-coverage-comment-action

@julian-risch julian-risch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general but there are two integrations that use this code and we should update them before making changes in Haystack: docling and langfuse
https://github.com/search?q=org%3Adeepset-ai+serialize_class_instance+language%3APython&type=code&l=Python

https://github.com/search?q=org%3Adeepset-ai+deserialize_class_instance+language%3APython&type=code

If possible, we should make changes in the integrations in a way that the new releases of integrations are still compatible with Haystack 2.x

@claude

claude Bot commented Jul 8, 2026

Copy link
Copy Markdown

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

@davidsbatista

davidsbatista commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@davidsbatista davidsbatista changed the base branch from v3 to main July 8, 2026 13:20
@julian-risch julian-risch changed the title chore: removing deadcode chore!: removing deadcode Jul 8, 2026

@julian-risch julian-risch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It's a breaking change so it's fair that we have an upgrade section in release notes. Good that the two integrations were updated.

@davidsbatista davidsbatista enabled auto-merge (squash) July 8, 2026 13:44
@davidsbatista davidsbatista merged commit d4d1872 into main Jul 8, 2026
26 checks passed
@davidsbatista davidsbatista deleted the chore/remove-de-serialize_class_instance-v3 branch July 8, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:tests type:documentation Improvements on the docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants