Skip to content

fix(lint): remove unfulfilled async trait expectations - #573

Closed
forhappy wants to merge 1 commit into
codex/capsule-snapshot-lifecyclefrom
codex/staging-lint-expectations
Closed

forhappy wants to merge 1 commit into
codex/capsule-snapshot-lifecyclefrom
codex/staging-lint-expectations

Conversation

@forhappy

Copy link
Copy Markdown
Contributor

Strict Clippy rejects eight unfulfilled double_must_use expectations on async traits in the capsule branch stack. Remove those expectations so the normal strict checks pass. The async_trait attributes, generated must-use behavior, trait signatures and runtime code remain unchanged.

Stacked on #572. Five files, 32 lines removed; no dependency, lockfile or storage-format changes. The two requested large-file push audit reports are excluded.

Validation:

  • cargo clippy -p crab-staging -p crab-auth --locked --all-targets --features crab-auth/crab-auth-client --jobs 2 -- -D warnings passes (3m26s), without lint exceptions.
  • Formatting checks for coordination, staging and auth pass; git diff --check passes.
  • Runtime/provider qualification is unchanged by this annotation-only cleanup; the parent PR remains a draft with failing CI gates.

Evidence: the original strict run reports these eight unfulfilled expectations; the exact source change passes the same strict command. Traits and implementations retain their existing contracts. The expectations were introduced in the capsule stack and are absent from current origin/main.

Is this the best fix? Removing stale expectations restores strict lint enforcement without suppressing warnings or changing the shared trait contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant