Repository navigation
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strict Clippy rejects eight unfulfilled
double_must_useexpectations on async traits in the capsule branch stack. Remove those expectations so the normal strict checks pass. Theasync_traitattributes, generated must-use behavior, trait signatures and runtime code remain unchanged.Stacked on #572. Five files, 32 lines removed; no dependency, lockfile or storage-format changes. The two requested large-file push audit reports are excluded.
Validation:
cargo clippy -p crab-staging -p crab-auth --locked --all-targets --features crab-auth/crab-auth-client --jobs 2 -- -D warningspasses (3m26s), without lint exceptions.git diff --checkpasses.Evidence: the original strict run reports these eight unfulfilled expectations; the exact source change passes the same strict command. Traits and implementations retain their existing contracts. The expectations were introduced in the capsule stack and are absent from current origin/main.
Is this the best fix? Removing stale expectations restores strict lint enforcement without suppressing warnings or changing the shared trait contracts.