Skip to content

fix(lint): remove unfulfilled async trait expectations #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
forhappy wants to merge 1 commit into from
Closed

fix(lint): remove unfulfilled async trait expectations #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions crates/crab-coordination/src/cosmosdb_coordinator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,6 @@ pub struct CosmosDbCreateCoordinatorAccount {
}

/// Minimal Cosmos DB control-plane client needed by Crab-owned coordinator setup.
#[expect(
clippy::double_must_use,
reason = "async_trait marks boxed futures must-use; Result is also must-use"
)]
#[async_trait]
pub trait CosmosDbCoordinatorControlPlaneClient {
async fn describe_account(
Expand Down
4 changes: 0 additions & 4 deletions crates/crab-coordination/src/dynamodb_coordinator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ pub type DynamoDbRepoState = CoordinatorRepoState;
pub type DynamoDbTransactionRecord = CoordinatorTransactionRecord;

/// DynamoDB data-plane client for one serialized repo authority item.
#[expect(
clippy::double_must_use,
reason = "async_trait marks boxed futures must-use; Result is also must-use"
)]
#[async_trait]
pub trait DynamoDbWriteCoordinatorClient {
async fn read_repo_state(
Expand Down
4 changes: 0 additions & 4 deletions crates/crab-coordination/src/spanner_coordinator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,6 @@ pub struct SpannerCreateCoordinator {
}

/// Minimal Spanner control-plane client needed by Crab-owned coordinator setup.
#[expect(
clippy::double_must_use,
reason = "async_trait marks boxed futures must-use; Result is also must-use"
)]
#[async_trait]
pub trait SpannerCoordinatorControlPlaneClient {
async fn describe_instance(
Expand Down
12 changes: 0 additions & 12 deletions crates/crab-coordination/src/write_coordinator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,10 +373,6 @@ pub struct CoordinatorControlPlaneStatus {
}

/// Management backend for a linearizable active-active coordinator.
#[expect(
clippy::double_must_use,
reason = "async_trait marks boxed futures must-use; Result is also must-use"
)]
#[async_trait]
pub trait CoordinatorControlPlaneBackend: Send + Sync {
fn provider(&self) -> ManagedCoordinatorProvider;
Expand Down Expand Up @@ -605,10 +601,6 @@ fn coordinator_base_action(action: &str) -> &str {
}

/// Versioned CAS storage contract for managed coordinator data planes.
#[expect(
clippy::double_must_use,
reason = "async_trait marks boxed futures must-use; Result is also must-use"
)]
#[async_trait]
pub trait VersionedCoordinatorStateStore: Send + Sync {
async fn read_repo_state(
Expand Down Expand Up @@ -653,10 +645,6 @@ where
}

/// Linearizable authority for active-active repository writes.
#[expect(
clippy::double_must_use,
reason = "async_trait marks boxed futures must-use; Result is also must-use"
)]
#[async_trait]
pub trait WriteCoordinator: Send + Sync {
async fn health(&self) -> Result<CoordinatorHealth>;
Expand Down
8 changes: 0 additions & 8 deletions crates/crab-staging/src/add_push_plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ pub struct AddPushPlanSummary {
}

/// Looks up already-uploaded chunk placements for staged chunks.
#[expect(
clippy::double_must_use,
reason = "async_trait marks boxed futures must-use; Result is also must-use"
)]
#[async_trait]
pub trait ExistingChunkLookup: Send + Sync {
async fn lookup_existing_candidates(
Expand All @@ -55,10 +51,6 @@ pub trait ExistingChunkLookup: Send + Sync {
}

/// Adds local prepared-xorb candidates to the staging cache.
#[expect(
clippy::double_must_use,
reason = "async_trait marks boxed futures must-use; Result is also must-use"
)]
#[async_trait]
pub trait LocalXorbCandidateLookup: Send + Sync {
async fn load_candidates(
Expand Down
Loading