Repository navigation
Conversation
This was referenced Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clone that diverges after another writer advances the remote cannot force-push unless it first fetches the discarded remote tip. Capsule admission rejects missing local ancestry as stale info; visibility construction also requires that old tip.
Allow unavailable ancestry for an explicit force or matched lease only when receive policy permits rewrites. Preserve lease checks, hard probe errors and the conditional old-ref publication boundary. Proven fast-forwards and rewrites with locally available old tips retain incremental visibility; rewrites missing their old tip use the existing complete replacement-closure format so discarded objects lose authorization without reading old history. Pack and LFS exclusions already use only locally available tips.
Stacked on #573. Draft; no merges requested. No format, dependency, lockfile or configuration changes. Requested benchmark audit reports are excluded.
Validation:
Evidence map: native CLI
cmd/push.rsand remote helper both callcapsule_push::run; admission callsis_ancestorand sharedcheck_ref_update; visibility calls the canonical bounded object walk and metadata-owned replacement encoder. Read-side readiness validates transaction old/new identity and applies replacement authorization. Pack and LFS publication independently filter unavailable remote exclusions. The retired legacy pipeline also permits forced non-fast-forwards; current origin/main has no capsule push module, so it cannot establish this v2 behavior.Is this the best fix? The shared capsule owner now separates force authorization from optional local ancestry and uses the existing replacement representation. Fetching discarded history solely to authorize its removal would preserve the bug's unnecessary dependency. Broad CI, the full current-source RustFS canary and final-source 10-GiB qualification remain required.
Updated-source qualification is pinned to
f6c35dcc9ca61389c5bdab18f336f77e26a75cc2. The first dispatched provider run was cancelled while queued because its source was superseded by the known-tip delta correction. No terminal test failure is claimed from that cancellation.Current CI: protocol/unit and cross-platform run and full RustFS provider/canary run are queued at the updated source. The earlier Git-current parent failure is separately traced to
mirror_lfs_discovery_checkreading an assumed loose object path that does not exist; it is repaired separately in draft #576 without waiving the checksum assertion.