Repository navigation
Add optional delay for blunderbuss - #530
Conversation
Signed-off-by: Kat Cosgrove <kat.cosgrove@gmail.com>
c178ebe to
ee783ce
Compare
|
/kind feature |
ee783ce
|
Retain only the focused dependency changes from cncf#546 and regenerate the bundle from a clean install. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
Keep package-lock.json identical to main after cncf#546, leaving this PR focused on the feature. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
|
Maintainer cleanup: #546 has merged separately. The updated branch now has no package-lock.json delta against main; unrelated dependency churn and its generated bundle changes were removed. Reviewed the remaining feature/source changes and the sensitive-path alert that was triggered solely by the lockfile. Removing sentinel-alert for the reviewed head; updated CI must pass before merge. |
🔒 Hold-gate integrity: branch changed while hold-gated — fresh review requiredThis PR's branch moved while it sat hold-gated: the head recorded when the hold was applied was Commits not present in the hold-time snapshot (2):
Authors not in the hold-time author set: A human should review the FULL diff at the current head — a rebase or force-push renames every commit, so everything above needs eyes even if it looks familiar. Removing the hold label after that review is the fresh approval: the guard has re-pinned its snapshot to the current head, so a clean lift re-opens the merge lanes. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org>
mrbobbytables
left a comment
There was a problem hiding this comment.
Maintainer-authorized Copilot review: dependency churn is removed and the feature retains its intended deferred-review semantics. Added 17 bundle scenarios for the new delay paths; after integrating reviewed main, build, bundle freshness, lint, unit coverage and full bundle coverage all pass. Latest GitHub build-test and e2e-coverage also pass. The DCO app has not emitted a check on this head; independently verified author-matching Signed-off-by trailers on all five commits unique to this PR. No protection or failing check is overridden. Releasing the hold for this reviewed head.
Description
Adds an optional
blunderbuss.delayduration so maintainers have time to request specific reviewers before automatic reviewer selection. Theopenedandready_for_reviewhandlers defer automatic requests to the scheduled sweep, which requests reviewers once the delay has elapsed only if no reviewer/team has been requested and no review exists./auto-ccremains immediate.Includes configuration documentation and tests. The sweep extends its listing window to find untouched PRs whose delay has elapsed; older PRs receive only the delayed-reviewer step.
The first authorized e2e run exposed missing bundle coverage for the new delay paths. Added
__tests__/bundle/blunderbussDelay.test.tsto exercise delayed event handling, due-window requests, manual-review/draft exclusions, ready-for-review timing, configuration validation, and refusal behavior through the bundle. Coverage floors remain unchanged.Dependency cleanup: #546 is the canonical Vite/PostCSS/Nano ID update and has merged. This branch incorporates that update;
package-lock.jsonnow matchesmainexactly. Unrelated dependency upgrades and their bundled output were removed, anddist/index.jswas rebuilt from a clean install.Related: #516 adds independent assertions for the existing sweep window and
ignore_authorsbehavior. No issue is auto-closed by this feature PR.Testing
npx vitest run __tests__/cronJobTest/sweep.test.ts __tests__/plugins/blunderbuss.test.ts __tests__/configurationDocs.test.ts __tests__/docsYamlExamples.test.ts __tests__/utils/config.test.ts— passed: 5 files, 281 passed / 75 skipped.npm ci --quiet && npm run build && npm run pack— passed; bundle regenerated using the focused dependency lockfile.npm run lint— passed with zero errors; the existingsrc/issueComment/cc.ts:81JSDoc warning remains.git diff --exit-code upstream/main -- package-lock.json— passed after incorporating chore(deps-dev): bump vite from 8.3.1 to 8.3.4 #546.npm test -- __tests__/bundle/blunderbussDelay.test.ts— passed: 17 new delay scenarios.npm run build && npm run pack && git diff --exit-code -- dist/ && npm run lint && npm run test:coverage && npm run test:coverage:e2e— passed on the feature combined with the reviewed main changes. Unit suite: 167 files, 2330 passed / 75 skipped; 99.91% lines and 99.35% branches. Bundle suite: 86 files, 528 passed; 100% lines/statements/functions and 99.46% branches.The full CI jobs must pass on the updated head before merging; earlier fork workflow runs were awaiting maintainer approval.
Checklist
npm run allto lint and build my code — the explicit build/lint/pack and focused test commands above were used instead, avoiding unrelated lint autofixes.npm run packand committeddist/