Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This was referenced Oct 8, 2026
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 8, 2026 04:36
a93327c to
f36fa01
Compare
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 8, 2026 12:02
f36fa01 to
3adb90e
Compare
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 8, 2026 14:19
3adb90e to
b426eed
Compare
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 8, 2026 20:40
b426eed to
55b313f
Compare
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 8, 2026 20:45
55b313f to
e54b8b5
Compare
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 8, 2026 20:49
e54b8b5 to
a0da184
Compare
mikepitre
added this pull request to stack #1053
October 8, 2026 22:12
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 9, 2026 01:04
a0da184 to
5558f6b
Compare
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
2 times, most recently
from
October 9, 2026 03:57
f699ca9 to
026ffb2
Compare
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 9, 2026 05:23
026ffb2 to
ce42c02
Compare
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 9, 2026 14:52
ce42c02 to
184115f
Compare
`attach` posted the video and screenshots of a run as a pull request comment. It now writes them into the description with `gh pr edit --attach`, in one block between two HTML comments that name the platform. A later `attach` replaces the block, so the description holds the latest run. Everything outside the block is passed back as it was read. `attach` reads the description again just before it writes. If the description changed, it rebuilds on the new text once, and fails if it changed again. It refuses a description whose markers are doubled, halved, or out of order. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mikepitre
force-pushed
the
mike/verify-borrowed-device-android
branch
from
October 9, 2026 19:17
184115f to
663183b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
upstarts a session on a GitHub Actions runner, and the CLI drives the emulator there through a tunnel, with the same verbs, tests, and evidence.e2e-tests/, and theverify-clerk-androidskill is the instructions that point an agent at it.--backend remoteondoctor,up, andrunforces the remote backend. With no flag the CLI picks the local backend where the machine can run the emulator and the remote one anywhere else, and its first line says which and why..github/workflows/verify-remote.ymlruns one session. It builds the pushed commit, never the working tree, boots the emulator, records the video, and ends ondown, after 15 idle minutes, or at 60 minutes.--runner <label>names the runner for a new session. The default isubuntu-24.04.doctorchecks that git can fetch and push the branch, that GitHub has HEAD, and that this machine reaches GitHub, the tunnel host, and Clerk. It starts nothing without--live.doctor --livestarts one short session and stops it.downends the runner job, anddown --stalealso ends a session that a crashed run of the same checkout left running.ghcannot attach files,attachhands the video and screenshots to the session's runner through the tunnel, and the runner keeps them as the artifactverify-evidence.references/remote.mdis new andSKILL.mddescribes the remote backend. Outside it ande2e-tests/, the PR addsverify-remote.ymland one line inandroid-test.yml, and it changes one sentence inAGENTS.md.To try it, on any machine with Node 24.8 or newer, the team's Clerk Platform API key, and a GitHub token that can push to this repository and start a workflow in it:
On a machine that cannot run the emulator, leave out
--backend remote. Allow about ten minutes for the firstup, most of it the first Gradle build.What to focus on
Five commits, in dependency order.
attachwrite a run's video and screenshots into the pull request description, in one block that a laterattachreplaces. In #1046 it posts a comment.Commit 1 has its own unit tests. The unit tests for commits 2 and 3 arrive in commit 4.
Everything under
e2e-tests/src/core/ande2e-tests/specs/support/, and most of the unit tests, are the same files, byte for byte, in clerk/clerk-ios#661 and clerk/javascript#10131.src/core/MANIFESTlists every shared file with its hash, and a unit test fails when one drifts. Review them once.Not proven:
doctor --live, the idle stop, and the 60-minute cap, at this head.What limits the risk:
workflow_dispatchonly, so it takes write access to start one and a fork cannot. The workflow has nopushorpull_requesttrigger and uses no repository or environment secret. Its onepermissionsblock iscontents: read, and no job has a write permission. The step that reads the request uses the job's own read-only token to check the requested commit. A session starts only for the commit the run was dispatched on, or for a later commit of that branch.e2e-tests/.verify/remote/on the machine that started the session. The workflow gets only its SHA-256.downdeletes the throwaway Clerk application.ubuntu-24.04label. A Blacksmith label is billed by the minute.attach, the new code runs only when the CLI picks the remote backend. The release gate in ci: run the end-to-end tests in the release workflow, and remove the Trailblaze suite #1052 does not use it.npm test --prefix e2e-testspasses 665 of 665 at this head with no network, key, or emulator, andnpm run typecheck --prefix e2e-testsreports nothing.Screenshots / video
None attached.
🤖 Generated with Claude Code