Skip to content

fix(migrations): renumber agent_task_queue_context to clear duplicate prefix 627 (CHE-1824) - #290

Merged
congvc-dev merged 4 commits into
mainfrom
agent/x99-claude-sonnet/che-1824-migration-627
Oct 17, 2026
Merged

congvc-dev merged 4 commits into
mainfrom
agent/x99-claude-sonnet/che-1824-migration-627

Conversation

@congvc-bot-x99

@congvc-bot-x99 congvc-bot-x99 Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Status: Ready for Cheese's review and merge. Fresh current-target CI: PASS. Repair for the duplicate migration prefix 627 on main. main now holds three 627 migrations. Current base 5a0ad9516afbdd143a2ba7361602ccf1dec535a0, head e52d3a3b20afbf3bff72ba58356c9b742accee8c. It blocks CHE-1727 PR #254 CI. It is not a change to wakeups.

Conditions:

  • Only Cheese merges. No deploy. No production migration was run. PR feat(wakeups): workspace-wide switch to pause wakeup firing (CHE-1727) [squash] #254 stays draft until verified repair merge and its required fresh final-pair verification.
  • Independent source review: PASS, no P0/P1 findings, signed by x99-codex-luna (gpt-6-luna, Codex/OpenAI), independent of author x99-claude-sonnet (Anthropic). Comment 01a1453a-8793-7aaa-b787-b6e866fc1638 on CHE-1824 covers this exact base/head. Its OCR receipt passes the pinned schema checker. Native selection and direct review cover all 15 raw-tree paths through two previews: 9 selected and 6 excluded. The range preview uses merge base a736250c26b9ba25cef9e0c13af6bc7ee1e7aa19; the separate intervening-main preview completes coverage. It is not one raw-range OCR selection. A changed base/head requires fresh applicable verification.
  • Historical test-first gate: WAIVED for head e52d3a3b20afbf3bff72ba58356c9b742accee8c only by Cheese comment 01a144d7-04c1-7f15-82eb-f545479c6953. Original behavioral-red evidence remains NOT-RUN, not PASS. The first commit of this PR (96d1464b5) mixed the compatibility test, the README and the rename. The unchanged uniqueness test failed on main: https://github.com/cheese-work/multica/actions/runs/38854767783. The history is not rebuilt. New tests added later do not clear that gap. No other check or merge gate is waived.
  • Later current-main correction: retrospective tests-only commit bc2dc1fbc precedes the fix commit e52d3a3b2.
  • A separate script-checks failure on main (a Helm download, run https://github.com/cheese-work/multica/actions/runs/38877201171) is not part of this PR. A migration fix alone is not an all-main CI PASS.

Change:

Evidence:

  • Red on the merged tree, before the fix commit: TestMigrationNumericPrefixesAreUnique fails with migrations 627_notification_channel_preference and 627_unpin_archived_chat_sessions share numeric prefix 627. The new test TestUnpinArchivedChatSessionsRenumberKeepsTheData fails at bc2dc1fbc because 653_unpin_archived_chat_sessions.up.sql does not exist. That second failure is a missing-file failure, not behavioral-red evidence.
  • Green at e52d3a3b2, on a task-owned pgvector/pgvector:pg17 container (DSN verified as loopback, not 5432): go test ./internal/migrations passes. go test ./cmd/migrate passes in full (53 s), including both renumber tests, each for a fresh and a previously applied database, run twice. go run ./cmd/migrate up on an empty database applies 627, 628, 629, 630 and 653 in order, and a second run skips them. go vet is clean. golangci-lint run --new-from-merge-base=origin/main reports 0 issues.
  • Fresh current-target CI: PASS, https://github.com/cheese-work/multica/actions/runs/38932599920. All 11 non-skipped jobs succeeded, including backend-tests, backend-agent-tests and the backend aggregate. GitHub skipped the remaining 7 jobs. None failed or remain pending. The separate Changelog line check also passes. Closing and reopening the draft PR refreshed the recorded base without changing its head or commits. GitHub merge candidate b69eaf6b45c1405b770cda0010c425fdf8c023a9 has this exact base/head as parents and tree e79b04ab5f1681d096f6616383ab54eae8dc8702.
  • Local CI-equivalent integration: commit 7eb28c6dbab1512d79f349567e9343b43a63a6b9 has the same parents and tree as the GitHub candidate. Race build, tagged vet, migrations, lifecycle checks, sqlc, vulnerability scan and lint pass. The regular and agent suites FAIL on X99. Matching pristine-main controls fail in execenv, governance/receipt and the Codex deadline test. Wecom fails intermittently on both trees. These local suite results remain FAIL, not green, and do not substitute for GitHub CI. The earlier CLI-package path artifact disappears outside the Multica workdir. All database services were task-owned and removed. No shared or production database access occurred.

Writing lint: the three passive-voice warnings are true positives retained for negative restrictions. The semicolon warning is a true positive retained for OCR-scope separation. The long-sentence warning is a true positive retained for migration-number reservations. The synonym warning is a false positive because "fix commit" identifies the implementation commit.

Changelog: none

Closes CHE-1824

…e duplicate 627 prefix (CHE-1824)

627_agent_task_queue_context and 627_unpin_archived_chat_sessions share a
numeric prefix, which fails TestMigrationNumericPrefixesAreUnique on main. The
later-merged migration is renumbered to 630; 628 and 629 stay free for open
pull requests. Versions are file basenames, so a database that applied the old
name reruns the identical idempotent ADD COLUMN IF NOT EXISTS and records the new
version; the legacy row stays. The SQL bytes are unchanged.
@congvc-bot-x99

Copy link
Copy Markdown
Author

Cross-link: #289 (an alternative 628 rename) is closed without merging. This PR is the sole repair lane. #285 (A3) merges this head 96d1464b556fa1f32518e90e54495a6c3c52dcbf unchanged and keeps its own compaction migration 629.

congvc-bot-x99 Bot pushed a commit that referenced this pull request Oct 16, 2026
…31-636 (CHE-1199)

main now holds 627-629 and PR #290 (CHE-1824) takes 630 and 653.
@congvc-bot-x99 congvc-bot-x99 Bot closed this Oct 16, 2026
@congvc-bot-x99 congvc-bot-x99 Bot reopened this Oct 16, 2026
@congvc-bot-x99
congvc-bot-x99 Bot marked this pull request as ready for review October 16, 2026 16:46
@congvc-dev
congvc-dev merged commit 2b13539 into main Oct 17, 2026
40 checks passed
@congvc-dev
congvc-dev deleted the agent/x99-claude-sonnet/che-1824-migration-627 branch October 17, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant