Skip to content

design(jev-governance-tab): Jev / Governance settings tab design, rev-1 to rev-4 [squash] - #268

Merged
congvc-dev merged 9 commits into
mainfrom
design/jev-governance-tab
Oct 17, 2026
Merged

congvc-dev merged 9 commits into
mainfrom
design/jev-governance-tab

Conversation

@congvc-bot-x99

@congvc-bot-x99 congvc-bot-x99 Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Status
Ready for Cheese's design review and merge. Design only: the Jev / Governance settings tab, revisions rev-1 to rev-4. No product code. Cheese selected direction C. A selection is not an approval: the design is approved only when Cheese merges this PR.

Current pair
Head c8aefdf6eca9df29e81f16e920a419e14de5b257. Base main at 2b135399996d8072c5a99deb88ef55edb62f49b4 (PR #290 merged). Merge-base 2b135399996d8072c5a99deb88ef55edb62f49b4. The PR contains design/jev-governance-tab/ (rev-1 to rev-4, README) and DESIGN.md: 46 files, no other file.

Conditions

  • Cheese approves by merging this PR. Agents never merge.
  • Mock data only. No live workspace setting or credential changes.
  • Merging this PR approves the design. It does not admit implementation by itself. Build admission needs the merged design path and merge commit.
  • Screen reader pass, real keyboard run and live behaviour are NOT-RUN.

Change

  • Selection record: DESIGN.md approved-revisions table has a row for jev-governance-tab, rev-4, direction C, PR 268, revision commit a32ec00a3ee38cbdf9336c3c953f7cf840ace38b. The wakeups-pause row from PR 255 is kept. The topic README status reads selected — approved when PR #268 merges. Cheese's words: "C is direction" (03:18 ICT, 16 Oct 2026, CHE-1780 comment 01a14136-ef91-73e1-867f-41c3747e6ad7).
  • Main merge: merge commit 0155f4ba8 merges repaired main. There were no conflicts.
  • Earlier on this branch: rev-1 (three directions), rev-2 (answers the rev-1 verdict, adds DESIGN.md), rev-3 (removes B's implementation note), rev-4 (revision labels), and a recompression of the six rev-1 PNGs.
  • Cheese's decision (12:35 ICT, 16 Oct 2026, CHE-1777 comment 01a14333-9494-763d-8d94-f687daf02b59) allows a one-off exception: recompress only the six rev-1 PNGs, with no recapture, dimension, UI-content or HTML change. The exception is not an image-budget waiver, and the PR carries no exemption line.

Evidence

  • Independent verification of this exact pair: PASS, signed corrected verdict by x99-agy-gemini (Google, Gemini 3.8 Flash High), independent non-author versus the designer x99-claude-sonnet (Anthropic). Signed 09:14 ICT, 17 Oct 2026. 0 P0 findings and 0 P1 findings in the inspected candidate.
  • Scope of that PASS: artifact equivalence, the direction-C selection record, the preserved main rules, the image budget and the selected design (rev-4/C.html, shared.css, DESIGN.md). OCR disposition: OER-1 governs PR-linked code, and this PR is design-only. ocr delegate preview selected 16 HTML and CSS files. The reviewer inspected rules and source for Direction C, shared.css and DESIGN.md only. The reviewer did not review all 16 files, and no OCR receipt exists. This is not a clean OCR result.
  • Disclosed omission: DESIGN.md replaced the main-side save-state sentence that named idle with a component table (SettingsSaveState: saving, saved, error) and a required-states list. The replacement text omits the state idle. This is disclosed, not a waiver of any implementation save-state requirement.
  • Current CI on this head: GitHub reports 12 SUCCESS check runs, 8 SKIPPED, 0 FAILURE and 0 PENDING. gh pr checks lists 11 passing checks because two runs share a name. backend-tests, backend and image-budget pass.
  • Budget: node scripts/check-image-budget.mjs --base origin/main exits 0. All 24 PNGs under design/jev-governance-tab/ are at most 307200 bytes. Historical: before the recompression, image-budget failed on the six rev-1 PNGs (512.0 KB to 927.9 KB). That failure is resolved. The originals stay in history at fc94732af43b146aac2abb16e1ecfc26d1bef3a9.
  • Unchanged artifacts: the rev-1, rev-2, rev-3 and rev-4 directory tree IDs at this head equal those at d9c533fb2fd626bef0c4d068c80b620db95f7b47. rev-2, rev-3 and rev-4 also equal their trees at a32ec00a3ee38cbdf9336c3c953f7cf840ace38b. Against fc94732af43b146aac2abb16e1ecfc26d1bef3a9, the only changed rev-1 files are the six PNGs.
  • Earlier verdicts: Luna's signed PASS (CHE-1777 comment 01a14376-c616-7ac2-91fc-f8cbafb9585f) covers the earlier head d9c533fb2fd626bef0c4d068c80b620db95f7b47 only. It is historical evidence.

Closes CHE-1780
Refs CHE-1777

CHE-1780 is the design slice this PR delivers, so Closes CHE-1780 is the close intent. CHE-1777 is the umbrella feature: its implementation layers follow after the design merges, so this PR does not close it.

Changelog: none

@congvc-bot-x99 congvc-bot-x99 Bot changed the title design(jev-governance-tab): rev-1 — Jev / Governance settings tab directions design(jev-governance-tab): Jev / Governance settings tab design, rev-1 to rev-4 [squash] Oct 17, 2026
@congvc-bot-x99
congvc-bot-x99 Bot marked this pull request as ready for review October 17, 2026 02:39
@congvc-dev
congvc-dev merged commit 968d0ea into main Oct 17, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant