Repository navigation
design(jev-governance-tab): Jev / Governance settings tab design, rev-1 to rev-4 [squash] - #268
Merged
Merged
Conversation
added 4 commits
October 16, 2026 00:35
…vernance settings tab
…b semantics, image budget; add DESIGN.md
This was referenced Oct 15, 2026
Merged
added 5 commits
October 16, 2026 12:54
…mage budget (Cheese exception; same captures)
# Conflicts: # DESIGN.md
…(selection, not approval)
10 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Ready for Cheese's design review and merge. Design only: the Jev / Governance settings tab, revisions rev-1 to rev-4. No product code. Cheese selected direction C. A selection is not an approval: the design is approved only when Cheese merges this PR.
Current pair
Head
c8aefdf6eca9df29e81f16e920a419e14de5b257. Basemainat2b135399996d8072c5a99deb88ef55edb62f49b4(PR #290 merged). Merge-base2b135399996d8072c5a99deb88ef55edb62f49b4. The PR containsdesign/jev-governance-tab/(rev-1 to rev-4, README) andDESIGN.md: 46 files, no other file.Conditions
Change
DESIGN.mdapproved-revisions table has a row forjev-governance-tab, rev-4, direction C, PR 268, revision commita32ec00a3ee38cbdf9336c3c953f7cf840ace38b. Thewakeups-pauserow from PR 255 is kept. The topic README status readsselected — approved when PR #268 merges. Cheese's words: "C is direction" (03:18 ICT, 16 Oct 2026, CHE-1780 comment01a14136-ef91-73e1-867f-41c3747e6ad7).0155f4ba8merges repairedmain. There were no conflicts.DESIGN.md), rev-3 (removes B's implementation note), rev-4 (revision labels), and a recompression of the six rev-1 PNGs.01a14333-9494-763d-8d94-f687daf02b59) allows a one-off exception: recompress only the six rev-1 PNGs, with no recapture, dimension, UI-content or HTML change. The exception is not an image-budget waiver, and the PR carries no exemption line.Evidence
rev-4/C.html,shared.css,DESIGN.md). OCR disposition: OER-1 governs PR-linked code, and this PR is design-only.ocr delegate previewselected 16 HTML and CSS files. The reviewer inspected rules and source for Direction C,shared.cssandDESIGN.mdonly. The reviewer did not review all 16 files, and no OCR receipt exists. This is not a clean OCR result.DESIGN.mdreplaced the main-side save-state sentence that namedidlewith a component table (SettingsSaveState: saving, saved, error) and a required-states list. The replacement text omits the stateidle. This is disclosed, not a waiver of any implementation save-state requirement.gh pr checkslists 11 passing checks because two runs share a name.backend-tests,backendandimage-budgetpass.node scripts/check-image-budget.mjs --base origin/mainexits 0. All 24 PNGs underdesign/jev-governance-tab/are at most 307200 bytes. Historical: before the recompression,image-budgetfailed on the six rev-1 PNGs (512.0 KB to 927.9 KB). That failure is resolved. The originals stay in history atfc94732af43b146aac2abb16e1ecfc26d1bef3a9.rev-1,rev-2,rev-3andrev-4directory tree IDs at this head equal those atd9c533fb2fd626bef0c4d068c80b620db95f7b47.rev-2,rev-3andrev-4also equal their trees ata32ec00a3ee38cbdf9336c3c953f7cf840ace38b. Againstfc94732af43b146aac2abb16e1ecfc26d1bef3a9, the only changedrev-1files are the six PNGs.01a14376-c616-7ac2-91fc-f8cbafb9585f) covers the earlier headd9c533fb2fd626bef0c4d068c80b620db95f7b47only. It is historical evidence.Closes CHE-1780
Refs CHE-1777
CHE-1780 is the design slice this PR delivers, so
Closes CHE-1780is the close intent. CHE-1777 is the umbrella feature: its implementation layers follow after the design merges, so this PR does not close it.Changelog: none