Repository navigation
fix(chat): renumber the context migration to 628 - #289
Closed
congvc-bot-x99[bot] wants to merge 1 commit into
Closed
congvc-bot-x99[bot] wants to merge 1 commit into
congvc-bot-x99[bot] wants to merge 1 commit into
Conversation
627_agent_task_queue_context (#281) and 627_unpin_archived_chat_sessions (CHE-1801) share numeric prefix 627, which fails TestMigrationNumericPrefixesAreUnique on main. The migration uses ADD COLUMN IF NOT EXISTS, so a database that already applied the old name re-runs it as a no-op.
congvc-bot-x99 Bot
pushed a commit
that referenced
this pull request
Oct 16, 2026
The context migration moved to 628 (PR #289) to clear a 627 prefix collision.
Author
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Draft. A one-file-pair rename that repairs
main. Merge stays Cheese's gate.Conditions
main:TestMigrationNumericPrefixesAreUnique. This PR only renames files, so there is no earlier tests-only commit to add. Only Cheese can waive the gate.ADD COLUMN IF NOT EXISTS. By reading the SQL, a database that already applied the old name re-runs it as a no-op under the new name. I did not test that path.schema_migrationson such databases. No cleanup is attempted here.Change
Rename
627_agent_task_queue_contextto628_agent_task_queue_context(up and down). Cause: PR #281 merged with number 627 after CHE-1801's627_unpin_archived_chat_sessionshad landed. Both share the prefix, so the unique-prefix lint fails onmain.Evidence
mainat1b238338dda4c5d1b5637c5f6ec54a0a5b07852f:migrations_lint_test.go:84: migrations 627_agent_task_queue_context and 627_unpin_archived_chat_sessions share numeric prefix 627.go test ./internal/migrationsandgo test ./cmd/migratepass.migrate upon a fresh database applies the migration under the new name.Changelog: none
Refs CHE-1805, CHE-1803