Skip to content

fix(chat): renumber the context migration to 628 - #289

Closed
congvc-bot-x99[bot] wants to merge 1 commit into
mainfrom
fix-che-1805-migration-number
Closed

congvc-bot-x99[bot] wants to merge 1 commit into
mainfrom
fix-che-1805-migration-number

Conversation

@congvc-bot-x99

Copy link
Copy Markdown

Status

Draft. A one-file-pair rename that repairs main. Merge stays Cheese's gate.

Conditions

  • Test-First Gate: NOT-RUN as a tests-only first commit. The check that fails already exists on main: TestMigrationNumericPrefixesAreUnique. This PR only renames files, so there is no earlier tests-only commit to add. Only Cheese can waive the gate.
  • The migration uses ADD COLUMN IF NOT EXISTS. By reading the SQL, a database that already applied the old name re-runs it as a no-op under the new name. I did not test that path.
  • The old name stays recorded in schema_migrations on such databases. No cleanup is attempted here.

Change

Rename 627_agent_task_queue_context to 628_agent_task_queue_context (up and down). Cause: PR #281 merged with number 627 after CHE-1801's 627_unpin_archived_chat_sessions had landed. Both share the prefix, so the unique-prefix lint fails on main.

Evidence

  • Red on main at 1b238338dda4c5d1b5637c5f6ec54a0a5b07852f: migrations_lint_test.go:84: migrations 627_agent_task_queue_context and 627_unpin_archived_chat_sessions share numeric prefix 627.
  • Green on this branch: go test ./internal/migrations and go test ./cmd/migrate pass. migrate up on a fresh database applies the migration under the new name.

Changelog: none

Refs CHE-1805, CHE-1803

627_agent_task_queue_context (#281) and 627_unpin_archived_chat_sessions
(CHE-1801) share numeric prefix 627, which fails
TestMigrationNumericPrefixesAreUnique on main. The migration uses
ADD COLUMN IF NOT EXISTS, so a database that already applied the old name
re-runs it as a no-op.
congvc-bot-x99 Bot pushed a commit that referenced this pull request Oct 16, 2026
The context migration moved to 628 (PR #289) to clear a 627 prefix collision.
@congvc-bot-x99

Copy link
Copy Markdown
Author

Closed without merging. PR #290 (CHE-1824, migration 630 with upgrade-compatibility coverage) is the sole repair lane for the duplicate 627 migration prefix. #285 now contains the #290 head 96d1464b556fa1f32518e90e54495a6c3c52dcbf and no longer carries this PR's 628 rename.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants