Skip to content

fix(cli,db): scaffold secrets, compose hardening, workspace add, UTCDateTime render (#440–#445) - #446

Merged
antosubash merged 4 commits into
mainfrom
fix/issue-batch-440-445
Oct 13, 2026
Merged

antosubash merged 4 commits into
mainfrom
fix/issue-batch-440-445

Conversation

@antosubash

@antosubash antosubash commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

Fixes the six issues filed from scaffolding a real app with simple_module_cli 0.0.35.

Changes

Docs updated: the installation guide, the project-structure guide, the workspace README template and the CHANGELOG. The CHANGELOG entry tells apps that already committed a generated .env.example to rotate those secrets.

Verification

  • make lint: green.
  • make test-py: 3961 passed, 11 skipped, 1 xfailed.
  • make migrations-roundtrip-pg on a disposable local DB: green. This repo already runs sqlmodel 0.0.48, and alembic check shows no type drift after the UTCDateTime change.
  • Scaffolded smpy new demo-app --db postgres by hand:
    • docker compose config accepts the generated .env. With no env it fails with set POSTGRES_PASSWORD in .env.
    • uv lock resolves playwright 1.63.0, pyee 13.0.1 and pytest-playwright 0.10.0.
  • On a scaffold with smpy create-module + smpy add ../modules/forest_plots --path host, uv lock succeeds.
  • Not run: make test-js and e2e (no frontend changes); a full uv sync + boot of a scaffolded app.

Review follow-ups (/ship)

  • Optimize pass, net −19 lines: shared env_values parser, _set_source helper, dead guard and unused return removed.
  • Code review fixes:
    • A placeholder on the last line with no trailing newline is now filled.
    • .env is written with mode 0600.
    • An existing .env keeps its POSTGRES_PASSWORD and DB URL together; one is never replaced without the other.
    • make docker-up prints which secrets to set when it creates .env from the template.
    • The create-module hint wording is fixed.
  • Second review pass: clean.
  • Re-verified at 9962a3e5: make lint green; make test-py 3963 passed, 11 skipped, 1 xfailed; make test-js green.
  • Pipeline report: https://claude.ai/artifact/2AShoztBZ67hLsNhpH8LBJ (private Claude Artifact; share it from claude.ai if reviewers need access)

Closes #440, closes #441, closes #442, closes #443, closes #444, closes #445

https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4

…ateTime render

- db: render sqlmodel UTCDateTime as sa.DateTime(timezone=True) and import
  sqlmodel for any other sqlmodel type (#440)
- cli: generated secrets go to gitignored .env, .env.example keeps
  placeholders (#441)
- cli: smpy add writes { workspace = true } for uv workspace members; cwd
  fallback for relative paths; create-module prints the add command (#442)
- cli: smpy (not sm) in templates, commit uv.lock, snake_case DB name (#443)
- cli: compose Postgres password from POSTGRES_PASSWORD, Postgres/Redis
  bound to 127.0.0.1 (#444)
- cli: floor playwright>=1.45 in scaffold dev groups (#445)

Closes #440, #441, #442, #443, #444, #445

Claude-Session: https://claude.ai/code/session_01M9neheZZEe3sVpDi2S3zT4
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-13T10:13:15.903085Z a4f86ee PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Deploying simple-module-python with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9962a3e
Status: ✅  Deploy successful!
Preview URL: https://c3a5e8c0.simple-module-python.pages.dev
Branch Preview URL: https://fix-issue-batch-440-445.simple-module-python.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment