OneDrive: support token in path for deltas and fix pseudonymizing delta link when listing user drives - #1402
Conversation
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
|
Mark draft, need to check couple of things |
| InvocationExample.of(baseEndpoint + "/drives/" + driveId + "/root/delta?token=abcXYZ123&", "get_drive_delta.json"), | ||
| // the OTHER real continuation shape, from this fixture's own captured @odata.nextLink | ||
| // (an OData function-call path segment -- rules must accept both) | ||
| InvocationExample.of(baseEndpoint + "/drives/" + driveId + "/root/delta(token=1230919asd190410jlka)", "get_drive_delta.json"), |
There was a problem hiding this comment.
mmmm ... OK; so I can see why this would need to be a regex; f'ing msft.
still possibly as a template the following would work?
pathTemplate: "/v1.0/drives/{driveId}/root/{deltaExpression}"
then could add paramSpec for deltaExpression that enforces pattern just against that portion - which may be simpler. something like ^delta\(token=\D+\)$?
but nice-to-have imho.
might require a second endpoint spec for the other case:
pathTemplate: "/v1.0/drives/{driveId}/root/delta" as before
I think duplication preferable to single regex that is hard to read (and thus hard to be certain that it's obviously correct)
There was a problem hiding this comment.
The funny thing is that while doing onedrive I've never faced the delta in path, that's something spotted while doing tests on #1401. And it is not clear why in the docs it says that delta is part of the path meanwhile it says that it could be a parameter https://learn.microsoft.com/en-us/graph/api/driveitem-delta?view=graph-rest-1.0&tabs=http#example-3-retrieving-the-current-deltalink, which it makes sense (besides that this what I see in the graph tests I have) because it is how it works ALL endpoints in graph.
aperez-worklytics
left a comment
There was a problem hiding this comment.
Split rules endpoint
From https://github.com/Worklytics/evalengin/pull/9014
Fixes
Features
Psoxy update
Logistics
Change implications
CHANGELOG.mdanything that will show up interraform plan/applythat isn'tobviously a no-op?
alpha, requires major versionchange