Skip to content

OneDrive: support token in path for deltas and fix pseudonymizing delta link when listing user drives - #1402

Merged
eschultink merged 7 commits into
rc-v0.6.10from
fix_onedrive_rules
Sep 1, 2026
Merged

eschultink merged 7 commits into
rc-v0.6.10from
fix_onedrive_rules

Conversation

@aperez-worklytics

@aperez-worklytics aperez-worklytics commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

From https://github.com/Worklytics/evalengin/pull/9014

  • Support delta token in path, apart from query parameter
  • Pseudonymizing delta link when listing user drives

Fixes

paste links to issues/tasks in project management

Features

Psoxy update

Logistics

paste links to issues/tasks in project management

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes?
    • NOTE in CHANGELOG.md anything that will show up in terraform plan/apply that isn't
      obviously a no-op?
    • breaking changes? if in module/example that is NOT marked alpha, requires major version
      change

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.

Tip: disable this comment in your organization's Code Review settings.

@aperez-worklytics aperez-worklytics changed the title Fix onedrive rules OneDrive: support token in path for deltas Aug 28, 2026
@aperez-worklytics
aperez-worklytics marked this pull request as draft August 28, 2026 13:16
@aperez-worklytics

Copy link
Copy Markdown
Contributor Author

Mark draft, need to check couple of things

@aperez-worklytics
aperez-worklytics marked this pull request as ready for review August 28, 2026 15:46
@aperez-worklytics aperez-worklytics changed the title OneDrive: support token in path for deltas OneDrive: support token in path for deltas and fix pseudonymizing delta link when listing user drives Aug 28, 2026
Comment thread docs/sources/microsoft-365/msft-onedrive/msft-onedrive.yaml Outdated
Comment thread docs/sources/microsoft-365/msft-onedrive/msft-onedrive_no-app-ids.yaml Outdated
InvocationExample.of(baseEndpoint + "/drives/" + driveId + "/root/delta?token=abcXYZ123&", "get_drive_delta.json"),
// the OTHER real continuation shape, from this fixture's own captured @odata.nextLink
// (an OData function-call path segment -- rules must accept both)
InvocationExample.of(baseEndpoint + "/drives/" + driveId + "/root/delta(token=1230919asd190410jlka)", "get_drive_delta.json"),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmm ... OK; so I can see why this would need to be a regex; f'ing msft.

still possibly as a template the following would work?

pathTemplate: "/v1.0/drives/{driveId}/root/{deltaExpression}"

then could add paramSpec for deltaExpression that enforces pattern just against that portion - which may be simpler. something like ^delta\(token=\D+\)$?

but nice-to-have imho.

might require a second endpoint spec for the other case:

pathTemplate: "/v1.0/drives/{driveId}/root/delta" as before

I think duplication preferable to single regex that is hard to read (and thus hard to be certain that it's obviously correct)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The funny thing is that while doing onedrive I've never faced the delta in path, that's something spotted while doing tests on #1401. And it is not clear why in the docs it says that delta is part of the path meanwhile it says that it could be a parameter https://learn.microsoft.com/en-us/graph/api/driveitem-delta?view=graph-rest-1.0&tabs=http#example-3-retrieving-the-current-deltalink, which it makes sense (besides that this what I see in the graph tests I have) because it is how it works ALL endpoints in graph.

@aperez-worklytics aperez-worklytics left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split rules endpoint

@eschultink
eschultink merged commit 2a187f3 into rc-v0.6.10 Sep 1, 2026
119 checks passed
@eschultink
eschultink deleted the fix_onedrive_rules branch September 1, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants