Skip to content

MSFT rules update - #1401

Draft
aperez-worklytics wants to merge 22 commits into
rc-v0.7.1from
msft_rules_update
Draft

MSFT rules update#1401
aperez-worklytics wants to merge 22 commits into
rc-v0.7.1from
msft_rules_update

Conversation

@aperez-worklytics

@aperez-worklytics aperez-worklytics commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

IN DRAFT UNTIL FURTHER TESTING

Parent PR is #1402

Java rules for MSFT dropped and using the ones generated from https://github.com/Worklytics/evalengin/pull/9018. For that:

  • YAML files have been updated / replaced
  • Added more tests to ensure all query parameters we need are covered by rules through InvocationExamples
  • Updated spec in psoxy-test for MSFT; also supporting pagination and links between calls

Fixes

paste links to issues/tasks in project management

Features

Psoxy update

Logistics

paste links to issues/tasks in project management

Change implications

  • dependencies added/changed? yes (explain) / no
  • something important to note in future release notes?
    • NOTE in CHANGELOG.md anything that will show up in terraform plan/apply that isn't
      obviously a no-op?
    • breaking changes? if in module/example that is NOT marked alpha, requires major version
      change

@aperez-worklytics aperez-worklytics self-assigned this Aug 27, 2026
"application":{
"id":"fb8d773d-7ef8-4ec0-a117-179f88add510",
"applicationIdentityType":"bot"
"id":"fb8d773d-7ef8-4ec0-a117-179f88add510"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think applicationIDentityType seems useful

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this in draft yet

- "$..onPremisesImmutableId"
- "$..identities[*].issuerAssignedId"
encoding: "URL_SAFE_TOKEN"
- pathTemplate: "/beta/copilot/users/{id}/interactionHistory/getAllEnterpriseInteractions"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to have a consistent yaml style here to maintain readibility of diffs. let's be consistent

@aperez-worklytics aperez-worklytics left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First revision

…k (no-app-ids)

Graph resolves the users/{userId}/drives nextLink to the raw AAD user id, which
otherwise blocks a client following the link under the no-app-ids variant's
reversible-pseudonym userId path requirement. Mirrors evalengin PR 9014, minus
its delta pathTemplate->pathRegex change (reverted here per review: driveId
isn't a userId, so that endpoint doesn't need this fix).
# Conflicts:
#	docs/sources/microsoft-365/msft-onedrive/msft-onedrive_no-app-ids.yaml
#	java/core/src/test/java/co/worklytics/psoxy/rules/msft/OneDriveTests.java
#	java/core/src/test/java/co/worklytics/psoxy/rules/msft/OneDrive_NoAppIds_Tests.java
@aperez-worklytics
aperez-worklytics changed the base branch from rc-v0.6.10 to fix_onedrive_rules August 28, 2026 19:52
Base automatically changed from fix_onedrive_rules to rc-v0.6.10 September 1, 2026 17:01
Base automatically changed from rc-v0.6.10 to main September 3, 2026 17:40
@eschultink
eschultink changed the base branch from main to rc-v0.7.1 September 3, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants