-
Notifications
You must be signed in to change notification settings - Fork 6
OneDrive: support token in path for deltas and fix pseudonymizing delta link when listing user drives #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b809a97
Rules update
aperez-worklytics b27cac2
Added tests cases
aperez-worklytics c5cbd23
Test update
aperez-worklytics 3afed94
Updated rules
aperez-worklytics 5822563
Updated sample files
aperez-worklytics feb8e37
Updated sample files
aperez-worklytics 450fec1
Merge branch 'rc-v0.6.10' into fix_onedrive_rules
aperez-worklytics File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
46 changes: 46 additions & 0 deletions
46
...ources/microsoft-365/msft-onedrive/example-api-responses/original/list_groups_drives.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| { | ||
| "@odata.nextLink": "https://graph.microsoft.com/v1.0/groups/6257b47d-9e87-418b-9ac2-031f09397de7/drives?$top=1&$skiptoken=aWQ9OUZCRjU2OUEtN0UwOC00RDFELTlFREMtMkY3ODg3MTUzNjY3", | ||
| "value": [ | ||
| { | ||
| "id": "b!-RIj2DuyvEyV1T4NlOaMHk8XkS_I8MdFlUCq1BlcjgmhRfAj3-Z8RY2VpuvV_tpd", | ||
| "driveType": "documentLibrary", | ||
| "createdDateTime": "2017-07-27T02:41:36Z", | ||
| "createdBy": { | ||
| "user": { | ||
| "id": "CE251278-EF9E-4FE5-833C-1D89EEAE68E0", | ||
| "displayName": "Ryan Gregg", | ||
| "email": "ryan@contoso.com" | ||
| } | ||
| }, | ||
| "lastModifiedDateTime": "2018-03-27T07:34:38Z", | ||
| "lastModifiedBy": { | ||
| "user": { | ||
| "id": "9a8b7c6d-5e4f-3a2b-1c0d-9e8f7a6b5c4d", | ||
| "displayName": "Dana Lee", | ||
| "email": "dana@contoso.com" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id": "b!kjtJnMGCeEeNkZsY18PtOiNjCV0Z9s9Fqyly8jKvPEB2kal9T5pOT5y7TXClirlE", | ||
| "driveType": "documentLibrary", | ||
| "system": {}, | ||
| "createdDateTime": "2017-07-27T02:41:36Z", | ||
| "createdBy": { | ||
| "user": { | ||
| "id": "CE251278-EF9E-4FE5-833C-1D89EEAE68E0", | ||
| "displayName": "Ryan Gregg", | ||
| "email": "ryan@contoso.com" | ||
| } | ||
| }, | ||
| "lastModifiedDateTime": "2017-07-27T02:41:36Z", | ||
| "lastModifiedBy": { | ||
| "user": { | ||
| "id": "CE251278-EF9E-4FE5-833C-1D89EEAE68E0", | ||
| "displayName": "Ryan Gregg", | ||
| "email": "ryan@contoso.com" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
1 change: 1 addition & 0 deletions
1
...e-api-responses/original/list_drives.json → ...-responses/original/list_user_drives.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
...urces/microsoft-365/msft-onedrive/example-api-responses/sanitized/list_groups_drives.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "@odata.nextLink":"https://graph.microsoft.com/v1.0/groups/6257b47d-9e87-418b-9ac2-031f09397de7/drives?$top=1&$skiptoken=aWQ9OUZCRjU2OUEtN0UwOC00RDFELTlFREMtMkY3ODg3MTUzNjY3", | ||
| "value":[ | ||
| { | ||
| "id":"b!-RIj2DuyvEyV1T4NlOaMHk8XkS_I8MdFlUCq1BlcjgmhRfAj3-Z8RY2VpuvV_tpd", | ||
| "driveType":"documentLibrary", | ||
| "createdDateTime":"2017-07-27T02:41:36Z", | ||
| "createdBy":{ | ||
| "user":{ | ||
| "id":"CE251278-EF9E-4FE5-833C-1D89EEAE68E0", | ||
| "email":"t~rhHXsIpQCoOYdgzj6URY4x8oUcvnLMLR5d71_wRuVAA@contoso.com" | ||
| } | ||
| }, | ||
| "lastModifiedDateTime":"2018-03-27T07:34:38Z", | ||
| "lastModifiedBy":{ | ||
| "user":{ | ||
| "id":"9a8b7c6d-5e4f-3a2b-1c0d-9e8f7a6b5c4d", | ||
| "email":"t~1ECTeY42RlWDU6D4DtrXKyFmVrUHbEEpdYzI34l0y9Q@contoso.com" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id":"b!kjtJnMGCeEeNkZsY18PtOiNjCV0Z9s9Fqyly8jKvPEB2kal9T5pOT5y7TXClirlE", | ||
| "driveType":"documentLibrary", | ||
| "system":{ }, | ||
| "createdDateTime":"2017-07-27T02:41:36Z", | ||
| "createdBy":{ | ||
| "user":{ | ||
| "id":"CE251278-EF9E-4FE5-833C-1D89EEAE68E0", | ||
| "email":"t~rhHXsIpQCoOYdgzj6URY4x8oUcvnLMLR5d71_wRuVAA@contoso.com" | ||
| } | ||
| }, | ||
| "lastModifiedDateTime":"2017-07-27T02:41:36Z", | ||
| "lastModifiedBy":{ | ||
| "user":{ | ||
| "id":"CE251278-EF9E-4FE5-833C-1D89EEAE68E0", | ||
| "email":"t~rhHXsIpQCoOYdgzj6URY4x8oUcvnLMLR5d71_wRuVAA@contoso.com" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
1 change: 1 addition & 0 deletions
1
...-api-responses/sanitized/list_drives.json → ...responses/sanitized/list_user_drives.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...ses/sanitized_no-app-ids/list_drives.json → ...itized_no-app-ids/list_groups_drives.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
...rosoft-365/msft-onedrive/example-api-responses/sanitized_no-app-ids/list_user_drives.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| { | ||
| "@odata.nextLink":"https://graph.microsoft.com/v1.0/users/p~G-O6qnggmabXX7oVLICcae1h1B_h3yud3zcNymQoGVqSOg0H9jqiKau9wvs7oToujvTK_Woudb8vCT95nqMWc89UQSbrUBZGukrZoydhHl8/drives?$top=1&$skiptoken=aWQ9OUZCRjU2OUEtN0UwOC00RDFELTlFREMtMkY3ODg3MTUzNjY3", | ||
| "value":[ | ||
| { | ||
| "id":"b!-RIj2DuyvEyV1T4NlOaMHk8XkS_I8MdFlUCq1BlcjgmhRfAj3-Z8RY2VpuvV_tpd", | ||
| "driveType":"documentLibrary", | ||
| "createdDateTime":"2017-07-27T02:41:36Z", | ||
| "createdBy":{ | ||
| "user":{ | ||
| "id":"t~jL-PZwZ7AqMLlWzY4F0nkDdSpci8cF1GzIzZC51Y9Rg", | ||
| "email":"t~rhHXsIpQCoOYdgzj6URY4x8oUcvnLMLR5d71_wRuVAA@contoso.com" | ||
| } | ||
| }, | ||
| "lastModifiedDateTime":"2018-03-27T07:34:38Z", | ||
| "lastModifiedBy":{ | ||
| "user":{ | ||
| "id":"t~DTbvYdTNRIQXAF1SvLNyAIENog0-Dy0dxTEB2Yoo5Ys", | ||
| "email":"t~1ECTeY42RlWDU6D4DtrXKyFmVrUHbEEpdYzI34l0y9Q@contoso.com" | ||
| } | ||
| } | ||
| }, | ||
| { | ||
| "id":"b!kjtJnMGCeEeNkZsY18PtOiNjCV0Z9s9Fqyly8jKvPEB2kal9T5pOT5y7TXClirlE", | ||
| "driveType":"documentLibrary", | ||
| "system":{ }, | ||
| "createdDateTime":"2017-07-27T02:41:36Z", | ||
| "createdBy":{ | ||
| "user":{ | ||
| "id":"t~jL-PZwZ7AqMLlWzY4F0nkDdSpci8cF1GzIzZC51Y9Rg", | ||
| "email":"t~rhHXsIpQCoOYdgzj6URY4x8oUcvnLMLR5d71_wRuVAA@contoso.com" | ||
| } | ||
| }, | ||
| "lastModifiedDateTime":"2017-07-27T02:41:36Z", | ||
| "lastModifiedBy":{ | ||
| "user":{ | ||
| "id":"t~jL-PZwZ7AqMLlWzY4F0nkDdSpci8cF1GzIzZC51Y9Rg", | ||
| "email":"t~rhHXsIpQCoOYdgzj6URY4x8oUcvnLMLR5d71_wRuVAA@contoso.com" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmmm ... OK; so I can see why this would need to be a regex; f'ing msft.
still possibly as a template the following would work?
pathTemplate: "/v1.0/drives/{driveId}/root/{deltaExpression}"
then could add paramSpec for
deltaExpressionthat enforces pattern just against that portion - which may be simpler. something like^delta\(token=\D+\)$?but nice-to-have imho.
might require a second endpoint spec for the other case:
pathTemplate: "/v1.0/drives/{driveId}/root/delta" as before
I think duplication preferable to single regex that is hard to read (and thus hard to be certain that it's obviously correct)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The funny thing is that while doing onedrive I've never faced the delta in path, that's something spotted while doing tests on #1401. And it is not clear why in the docs it says that delta is part of the path meanwhile it says that it could be a parameter https://learn.microsoft.com/en-us/graph/api/driveitem-delta?view=graph-rest-1.0&tabs=http#example-3-retrieving-the-current-deltalink, which it makes sense (besides that this what I see in the graph tests I have) because it is how it works ALL endpoints in graph.