Skip to content

fix(kit): name the real service, not "Notion API" or the sample, and pin cli-core 0.696.0 - #186

Merged
leemour merged 1 commit into
mainfrom
fix/notion-service-name
Nov 17, 2026
Merged

leemour merged 1 commit into
mainfrom
fix/notion-service-name

Conversation

@leemour

@leemour leemour commented Nov 17, 2026

Copy link
Copy Markdown
Member

Task

Notion's official OpenAPI description (makenotion/notion-mcp-server@cf16e5c, 24 operations), made with @wirecat/cli-template 0.27.0, showed generator bugs.

Why

What

  • serviceOf drops a trailing " API" from the title; the README, api group, skill and MCP texts now say "Notion".
  • SERVICE moves from src/sample/transport.ts to src/identity.ts; new writes the real name there. The sample comments group keeps "Example Comments".
  • new --spec-url rewrites the "its one service is a sample" sentence in docs/index.md, docs/security.md and the skill.
  • Seed src/api.test.ts: leaves out a required parameter with a default; typechecks for a spec without securitySchemes (PokeAPI failed pnpm bootstrap on this).
  • Pins cli-core 0.696.0 and cli-base 0.116.0.

Testing

  • vitest run: 224 passed; kit/test/spec-url.test.ts covers the name, SERVICE and the pages. Lint, typecheck, docs:check pass.
  • Packed this branch and ran new + pnpm bootstrap + pnpm test:
    • Notion (--sign-in token): 128 passed, 11 files. No "API API"; "Example Comments" only in the sample comments group.
    • PokeAPI d19c710 (--sign-in none): 205 passed, 1 skipped.

🤖 Generated with Claude Code

…pin cli-core 0.696.0

Notion's OpenAPI description exposed three gaps in a CLI made with --spec-url:
- the service name kept the title's trailing "API": "the raw Notion API API";
- session, MCP and offline texts said "Example Comments", the sample's name;
- a required Notion-Version header with a default was still demanded
  (fixed in cli-core 0.696.0; the seed api test now leaves such a flag out).

SERVICE moves to src/identity.ts, and new writes the service's name there
and into docs/index.md, docs/security.md and the skill. The seed api test
also typechecks for a spec without securitySchemes (PokeAPI).
Pins cli-core 0.696.0 and cli-base 0.116.0 (GET /me is named -get).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​wirecat/​cli-base@​0.114.0 ⏵ 0.116.098100100 +19670
Updated@​wirecat/​cli-core@​0.695.0 ⏵ 0.696.098 +1100100 +19670

View full report

@leemour
leemour merged commit 009795e into main Nov 17, 2026
16 checks passed
@leemour
leemour deleted the fix/notion-service-name branch November 17, 2026 22:57
leemour added a commit that referenced this pull request Nov 18, 2026
…ig wiring over both sources

valueAt from @wirecat/cli-core/manifest replaces the seed's own copy. After the rebase over the tracker category
(#190) and the real service name (#186): withConfigRunScope moves to config-wiring.ts and takes both sources,
users list|show only for a CRM source, and the sample-free context and program keep identity.js's SERVICE.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour added a commit that referenced this pull request Nov 18, 2026
…ot the sample (#194)

* fix(kit): a CLI from a config with a token check starts on the API, not the sample

From the Attio pilot (source-manifest.md section 10):
- FIND-2753: new --from-config with auth.verify leaves the sample out and rewrites context, program, harness and the
  api, mcp and run-scope tests to the API and its fake; OAuth hosts from the description join hosts.
- FIND-2754: a function in source stops pnpm generate instead of vanishing in JSON.
- FIND-2761 (template half): auth.verify.active must be true, else session start says to sign in again.
- FIND-2763: source.users mounts users list|show.
- FIND-2765: the seed's sync test reads rows from crmManifestFake, which pages to the end; over fakeServiceApi an
  offset list never ended and the test timed out.

Checked by generating a CRM CLI from a config in a scratch folder: lint, typecheck, contracts:check, docs:check and
its 105 tests pass, the sync test in 5 s instead of 183 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(kit): the seed's session check uses cli-core's valueAt; config wiring over both sources

valueAt from @wirecat/cli-core/manifest replaces the seed's own copy. After the rebase over the tracker category
(#190) and the real service name (#186): withConfigRunScope moves to config-wiring.ts and takes both sources,
users list|show only for a CRM source, and the sample-free context and program keep identity.js's SERVICE.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant