Repository navigation
fix(kit): name the real service, not "Notion API" or the sample, and pin cli-core 0.696.0 - #186
Merged
Merged
Conversation
…pin cli-core 0.696.0 Notion's OpenAPI description exposed three gaps in a CLI made with --spec-url: - the service name kept the title's trailing "API": "the raw Notion API API"; - session, MCP and offline texts said "Example Comments", the sample's name; - a required Notion-Version header with a default was still demanded (fixed in cli-core 0.696.0; the seed api test now leaves such a flag out). SERVICE moves to src/identity.ts, and new writes the service's name there and into docs/index.md, docs/security.md and the skill. The seed api test also typechecks for a spec without securitySchemes (PokeAPI). Pins cli-core 0.696.0 and cli-base 0.116.0 (GET /me is named -get). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
leemour
added a commit
that referenced
this pull request
Nov 18, 2026
…ig wiring over both sources valueAt from @wirecat/cli-core/manifest replaces the seed's own copy. After the rebase over the tracker category (#190) and the real service name (#186): withConfigRunScope moves to config-wiring.ts and takes both sources, users list|show only for a CRM source, and the sample-free context and program keep identity.js's SERVICE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
added a commit
that referenced
this pull request
Nov 18, 2026
…ot the sample (#194) * fix(kit): a CLI from a config with a token check starts on the API, not the sample From the Attio pilot (source-manifest.md section 10): - FIND-2753: new --from-config with auth.verify leaves the sample out and rewrites context, program, harness and the api, mcp and run-scope tests to the API and its fake; OAuth hosts from the description join hosts. - FIND-2754: a function in source stops pnpm generate instead of vanishing in JSON. - FIND-2761 (template half): auth.verify.active must be true, else session start says to sign in again. - FIND-2763: source.users mounts users list|show. - FIND-2765: the seed's sync test reads rows from crmManifestFake, which pages to the end; over fakeServiceApi an offset list never ended and the test timed out. Checked by generating a CRM CLI from a config in a scratch folder: lint, typecheck, contracts:check, docs:check and its 105 tests pass, the sync test in 5 s instead of 183 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(kit): the seed's session check uses cli-core's valueAt; config wiring over both sources valueAt from @wirecat/cli-core/manifest replaces the seed's own copy. After the rebase over the tracker category (#190) and the real service name (#186): withConfigRunScope moves to config-wiring.ts and takes both sources, users list|show only for a CRM source, and the sample-free context and program keep identity.js's SERVICE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Notion's official OpenAPI description (makenotion/notion-mcp-server@cf16e5c, 24 operations), made with
@wirecat/cli-template0.27.0, showed generator bugs.Why
api --helpsaid "the raw Notion API API": the service name came frominfo.titleas is.session --helpsaid "keep this profile's Example Comments token": session, MCP and the offline refusal read the sample transport's name.required option '--notion-version <value>' not specified(fixed in cli-core 0.696.0, fix(cli): a required api parameter with a spec default is sent with it, not demanded cli-core#3093).GET /v1/users/mewasusers-me-list(fixed in cli-base 0.116.0, fix(codegen)!: name a GET of /me as one item, -get, not -list cli-base#636).What
serviceOfdrops a trailing " API" from the title; the README,apigroup, skill and MCP texts now say "Notion".SERVICEmoves fromsrc/sample/transport.tstosrc/identity.ts;newwrites the real name there. The samplecommentsgroup keeps "Example Comments".new --spec-urlrewrites the "its one service is a sample" sentence indocs/index.md,docs/security.mdand the skill.src/api.test.ts: leaves out a required parameter with a default; typechecks for a spec withoutsecuritySchemes(PokeAPI failedpnpm bootstrapon this).Testing
vitest run: 224 passed;kit/test/spec-url.test.tscovers the name,SERVICEand the pages. Lint, typecheck,docs:checkpass.new+pnpm bootstrap+pnpm test:--sign-in token): 128 passed, 11 files. No "API API"; "Example Comments" only in the samplecommentsgroup.--sign-in none): 205 passed, 1 skipped.🤖 Generated with Claude Code