Skip to content

fix(kit): a CLI from a config with a token check starts on the API, not the sample - #194

Merged
leemour merged 2 commits into
mainfrom
fix/attio-pilot-gaps
Nov 18, 2026
Merged

leemour merged 2 commits into
mainfrom
fix/attio-pilot-gaps

Conversation

@leemour

@leemour leemour commented Nov 18, 2026

Copy link
Copy Markdown
Member

Task

Close the gaps the Attio pilot found in new --from-config, on cli-core 0.698.0 and cli-base 0.117.0.

Why

A CLI made from a config with auth.verify still imported the template's sample, so remove-sample refused it until about 30 lines were rewritten by hand. Attio answers a revoked key with 200 and active: false, which session start reported as provider_error. The seed's sync test timed out over fakeServiceApi (382 pages), and a function in source was dropped silently.

What

Testing

  • cli-template: typecheck, lint, docs check, 229 tests.
  • An Attio CLI made with this kit from the pilot's config (with verify.active): no src/sample/; after setting readingPosts: true in its scripts/generate.ts (Attio's query POSTs only read), lint, contracts check, docs check and 209 tests pass. kit:e2e does not cover --from-config with a token check, so this was the only check of that path.

🤖 Generated with Claude Code

leemour and others added 2 commits November 18, 2026 09:46
…ot the sample

From the Attio pilot (source-manifest.md section 10):
- FIND-2753: new --from-config with auth.verify leaves the sample out and rewrites context, program, harness and the
  api, mcp and run-scope tests to the API and its fake; OAuth hosts from the description join hosts.
- FIND-2754: a function in source stops pnpm generate instead of vanishing in JSON.
- FIND-2761 (template half): auth.verify.active must be true, else session start says to sign in again.
- FIND-2763: source.users mounts users list|show.
- FIND-2765: the seed's sync test reads rows from crmManifestFake, which pages to the end; over fakeServiceApi an
  offset list never ended and the test timed out.

Checked by generating a CRM CLI from a config in a scratch folder: lint, typecheck, contracts:check, docs:check and
its 105 tests pass, the sync test in 5 s instead of 183 s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ig wiring over both sources

valueAt from @wirecat/cli-core/manifest replaces the seed's own copy. After the rebase over the tracker category
(#190) and the real service name (#186): withConfigRunScope moves to config-wiring.ts and takes both sources,
users list|show only for a CRM source, and the sample-free context and program keep identity.js's SERVICE.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leemour
leemour force-pushed the fix/attio-pilot-gaps branch from bc31e08 to 633800f Compare November 18, 2026 08:47
@leemour
leemour merged commit bc37c4f into main Nov 18, 2026
16 checks passed
@leemour
leemour deleted the fix/attio-pilot-gaps branch November 18, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant