Repository navigation
fix(kit): a CLI from a config with a token check starts on the API, not the sample - #194
Merged
Merged
Conversation
…ot the sample From the Attio pilot (source-manifest.md section 10): - FIND-2753: new --from-config with auth.verify leaves the sample out and rewrites context, program, harness and the api, mcp and run-scope tests to the API and its fake; OAuth hosts from the description join hosts. - FIND-2754: a function in source stops pnpm generate instead of vanishing in JSON. - FIND-2761 (template half): auth.verify.active must be true, else session start says to sign in again. - FIND-2763: source.users mounts users list|show. - FIND-2765: the seed's sync test reads rows from crmManifestFake, which pages to the end; over fakeServiceApi an offset list never ended and the test timed out. Checked by generating a CRM CLI from a config in a scratch folder: lint, typecheck, contracts:check, docs:check and its 105 tests pass, the sync test in 5 s instead of 183 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ig wiring over both sources valueAt from @wirecat/cli-core/manifest replaces the seed's own copy. After the rebase over the tracker category (#190) and the real service name (#186): withConfigRunScope moves to config-wiring.ts and takes both sources, users list|show only for a CRM source, and the sample-free context and program keep identity.js's SERVICE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
force-pushed
the
fix/attio-pilot-gaps
branch
from
November 18, 2026 08:47
bc31e08 to
633800f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Close the gaps the Attio pilot found in
new --from-config, on cli-core 0.698.0 and cli-base 0.117.0.Why
A CLI made from a config with
auth.verifystill imported the template's sample, soremove-samplerefused it until about 30 lines were rewritten by hand. Attio answers a revoked key with 200 andactive: false, whichsession startreported asprovider_error. The seed's sync test timed out overfakeServiceApi(382 pages), and a function insourcewas dropped silently.What
auth.verifyand a spec, the CLI starts without the sample: context, program, harness and theapi,mcpandrun-scopetests reach the API and its fake. OAuth sign-in hosts joinhosts.auth.verify.active: a field that must betrue, otherwise "sign in again".source.usersmountsusers list|show.crmManifestFake; a function insourcestopspnpm generate.valueAtfrom@wirecat/cli-core/manifestinstead of its own copy.withConfigRunScopemoves tokit/src/config-wiring.tsand takes both sources;usersonly for a CRM source.Testing
verify.active): nosrc/sample/; after settingreadingPosts: truein itsscripts/generate.ts(Attio's query POSTs only read), lint, contracts check, docs check and 209 tests pass.kit:e2edoes not cover--from-configwith a token check, so this was the only check of that path.🤖 Generated with Claude Code