Repository navigation
feat(manifest): signIn.methods, so Desktop signs an own tool in in its window - #645
Merged
Merged
Conversation
…s window
An own tool's manifest could only say what its sign-in asks for, so WireCat Desktop
offered nothing but "sign in in a terminal". ManifestIdentity.signIn now takes an
optional methods list of { id, label, words, stdin? }, written to
desktop.signIn.methods: the subset Desktop accepts from a tool it did not build.
buildManifest refuses words that do not start with {profile}, that name no command
of the CLI, or that fill any other slot. A manifest without methods stays byte for
byte as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
force-pushed
the
feat/signin-methods
branch
from
November 17, 2026 23:35
28a177b to
21f208d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
WireCat Desktop should sign in to beeline-cli (an own tool, added from its npm manifest) inside the app window. Today it only offers a terminal.
Why
The manifest's
signInheld onlygivesandasks, so a tool could not say how it signs in. Desktop's built-in catalog entries already describe this withsignIn.methods.What
ManifestIdentity.signIn.methods?: a list of{ id, label, words, stdin? }, written todesktop.signIn.methods. Only this subset: Desktop does not take a password variable, client file, OAuth words or address from a tool it did not build.buildManifestrefuses words that don't start with{profile}(or a CLI without a profile list), that name no command of the CLI, or that fill another slot. Plain-word rules apply as for every array.Desktop side: WireCatLabs/wirecat-desktop PR (shows a token field for a
stdinmethod, checks the methods for own tools). beeline adopts it after the release.Testing
pnpm typecheck,vitest run src/wcat/(new test: passes through only when declared; refuses missing{profile}, an unknown command, another slot, shell syntax, an extrapasswordkey),biome,docs:check,markdownlint-cli2.🤖 Generated with Claude Code