Skip to content

feat(manifest): signIn.methods, so Desktop signs an own tool in in its window - #645

Merged
leemour merged 1 commit into
mainfrom
feat/signin-methods
Nov 17, 2026
Merged

leemour merged 1 commit into
mainfrom
feat/signin-methods

Conversation

@leemour

@leemour leemour commented Nov 17, 2026

Copy link
Copy Markdown
Member

Task

WireCat Desktop should sign in to beeline-cli (an own tool, added from its npm manifest) inside the app window. Today it only offers a terminal.

Why

The manifest's signIn held only gives and asks, so a tool could not say how it signs in. Desktop's built-in catalog entries already describe this with signIn.methods.

What

  • ManifestIdentity.signIn.methods?: a list of { id, label, words, stdin? }, written to desktop.signIn.methods. Only this subset: Desktop does not take a password variable, client file, OAuth words or address from a tool it did not build.
  • buildManifest refuses words that don't start with {profile} (or a CLI without a profile list), that name no command of the CLI, or that fill another slot. Plain-word rules apply as for every array.
  • Left out when not declared, so every other CLI's manifest stays byte for byte the same.
  • CHANGELOG under Unreleased, REFERENCE manifest table.

Desktop side: WireCatLabs/wirecat-desktop PR (shows a token field for a stdin method, checks the methods for own tools). beeline adopts it after the release.

Testing

  • pnpm typecheck, vitest run src/wcat/ (new test: passes through only when declared; refuses missing {profile}, an unknown command, another slot, shell syntax, an extra password key), biome, docs:check, markdownlint-cli2.

🤖 Generated with Claude Code

…s window

An own tool's manifest could only say what its sign-in asks for, so WireCat Desktop
offered nothing but "sign in in a terminal". ManifestIdentity.signIn now takes an
optional methods list of { id, label, words, stdin? }, written to
desktop.signIn.methods: the subset Desktop accepts from a tool it did not build.

buildManifest refuses words that do not start with {profile}, that name no command
of the CLI, or that fill any other slot. A manifest without methods stays byte for
byte as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant