Repository navigation
feat(desktop): the manifest says how Desktop signs beeline in, in its window - #41
Merged
Merged
Conversation
… window WireCat Desktop offered only "sign in in a terminal" for beeline. With cli-base 0.117.0 the manifest declares signIn.methods: the token method runs `beeline <profile> session start --json` with the API token as its whole stdin, which session start already reads (checked with the built CLI and empty stdin: it answers validation_error "no token was given", without the network). Bumps @wirecat/cli-base 0.104.0 → 0.117.0 and regenerates contracts/wirecat.json; nothing else in it changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
WireCat Desktop should sign in to beeline (an own tool) inside the app window, not only at a terminal.
Why
cli-base 0.117.0 (WireCatLabs/cli-base#645) lets the manifest declare
desktop.signIn.methods. Desktop runs such a method in its window (WireCatLabs/wirecat-desktop#422).What
DESKTOP.signIn.methods:{ id: "token", label: "API token", words: ["{profile}", "session", "start", "--json"], stdin: true }.@wirecat/cli-base0.104.0 → 0.117.0;contracts/wirecat.jsonregenerated (onlysignIn.methodschanges).changes/feat-signin-methods.md.Testing
DBUS_SESSION_BUS_ADDRESS=disabled:, no sign-in:beeline work session start --json --credential-storage file </dev/nulland with whitespace on stdin both answer{"error":{"code":"validation_error","reason":"input.invalid","message":"no token was given",...}}, exit 2, with no network call. So it reads the token from stdin under--json.pnpm typecheck,lint,lint:commands,docs:check,standards:check,test:matrix:check,vitest(139 passed),pnpm generate.Do not release yet: it needs the owner's live check, and Desktop 0.7.1 already reads
signIn.methodsbut shows no token field for it, so the window sign-in only works with a Desktop that has #422.🤖 Generated with Claude Code