Repository navigation
feat(own-tools): an own tool signs in in the window from its manifest's signIn.methods - #422
Merged
Merged
Conversation
…'s signIn.methods
An own tool (beeline-cli) could only be signed in at a terminal, though cli-base 0.117.0
lets its manifest describe the sign-in as signIn.methods.
- community.rs: a community or own tool's methods hold only id, label, words and stdin.
The words start with {profile} and fill no other slot; password, clientId, clientFile,
address, oauth, portal and appId are refused, since none is reviewed.
- The window shows a token field for any stdin method, not only pbx's, and will not start
without it; a tool WireCat has no texts for shows its own signIn.asks.
- The own-tool review says the tool signs in in this window and names each way. An update
that changes the methods is already listed as a changed sign-in; a test covers it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
leemour
force-pushed
the
feat/signin-methods
branch
from
November 18, 2026 08:33
d6d3c46 to
0ba5566
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
WireCat Desktop should sign in to beeline-cli (
@wirecat/beeline-cli, an own tool added from its npm manifest) inside the app window. Today it only offers a terminal.Why
cli-base 0.117.0 (WireCatLabs/cli-base#645) lets a manifest declare
desktop.signIn.methods:{ id, label, words, stdin? }. Desktop already parsedsignIn.methodsfor own tools, but:stdinand nopassword(only pbx's flow asked for it), so the run failed with "This sign-in needs the password";community.rsdid not limit which method keys a tool we did not build may set (passwordnames a variable Desktop sets,clientIda setting it writes).What
community.rs: a community or own tool'ssignIn.methodshold onlyid(plain lower-case),label(one line, at most 40 characters),wordsandstdin. Words start with{profile}and fill no other slot; plain words as before. Any other key is refused.stdinmethod; Start asks for it before the run. A tool with no texts in WireCat (an own tool) shows its ownsignIn.asks.OwnSignIn.here, bindings updated). An update that changes the methods is already listed as a changed sign-in (wholesignIncompared); a Rust test now covers it.docs/dev/cli-registry.mdupdated. No release notes file: this repo writesdocs/releases/<version>.mdat release time.Testing
cargo test --lib(953 passed, run with a throwaway HOME. Locally, five existing tests fail because they read the real app-dataextra-tools.json; all pass with a throwaway HOME. Not checked on main),cargo clippy --all-targets -D warnings,cargo fmt --check.pnpm typecheck,biome, vitest on signin, tools, shared and domain (1039 passed). New tests: own-tool sign-in asks for the token and sends it on stdin; review shows the window sign-in; community refusals.docs:spellreportsKommoindocs/releases/0.7.1.md, already on main.Not merged on purpose: the owner merges after Desktop 0.7.1.
🤖 Generated with Claude Code