Skip to content

feat(own-tools): an own tool signs in in the window from its manifest's signIn.methods - #422

Merged
leemour merged 1 commit into
mainfrom
feat/signin-methods
Nov 18, 2026
Merged

leemour merged 1 commit into
mainfrom
feat/signin-methods

Conversation

@leemour

@leemour leemour commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Task

WireCat Desktop should sign in to beeline-cli (@wirecat/beeline-cli, an own tool added from its npm manifest) inside the app window. Today it only offers a terminal.

Why

cli-base 0.117.0 (WireCatLabs/cli-base#645) lets a manifest declare desktop.signIn.methods: { id, label, words, stdin? }. Desktop already parsed signIn.methods for own tools, but:

  • the window showed no token field for a method with stdin and no password (only pbx's flow asked for it), so the run failed with "This sign-in needs the password";
  • community.rs did not limit which method keys a tool we did not build may set (password names a variable Desktop sets, clientId a setting it writes).

What

  • community.rs: a community or own tool's signIn.methods hold only id (plain lower-case), label (one line, at most 40 characters), words and stdin. Words start with {profile} and fill no other slot; plain words as before. Any other key is refused.
  • Sign-in window: a token field for any stdin method; Start asks for it before the run. A tool with no texts in WireCat (an own tool) shows its own signIn.asks.
  • Own-tool review: "It signs in here, in this window: API token." (OwnSignIn.here, bindings updated). An update that changes the methods is already listed as a changed sign-in (whole signIn compared); a Rust test now covers it.
  • docs/dev/cli-registry.md updated. No release notes file: this repo writes docs/releases/<version>.md at release time.

Testing

  • cargo test --lib (953 passed, run with a throwaway HOME. Locally, five existing tests fail because they read the real app-data extra-tools.json; all pass with a throwaway HOME. Not checked on main), cargo clippy --all-targets -D warnings, cargo fmt --check.
  • pnpm typecheck, biome, vitest on signin, tools, shared and domain (1039 passed). New tests: own-tool sign-in asks for the token and sends it on stdin; review shows the window sign-in; community refusals.
  • docs:spell reports Kommo in docs/releases/0.7.1.md, already on main.

Not merged on purpose: the owner merges after Desktop 0.7.1.

🤖 Generated with Claude Code

…'s signIn.methods

An own tool (beeline-cli) could only be signed in at a terminal, though cli-base 0.117.0
lets its manifest describe the sign-in as signIn.methods.

- community.rs: a community or own tool's methods hold only id, label, words and stdin.
  The words start with {profile} and fill no other slot; password, clientId, clientFile,
  address, oauth, portal and appId are refused, since none is reviewed.
- The window shows a token field for any stdin method, not only pbx's, and will not start
  without it; a tool WireCat has no texts for shows its own signIn.asks.
- The own-tool review says the tool signs in in this window and names each way. An update
  that changes the methods is already listed as a changed sign-in; a test covers it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@leemour
leemour force-pushed the feat/signin-methods branch from d6d3c46 to 0ba5566 Compare November 18, 2026 08:33
@leemour
leemour merged commit 5003ab7 into main Nov 18, 2026
7 checks passed
@leemour
leemour deleted the feat/signin-methods branch November 18, 2026 08:50
@leemour leemour mentioned this pull request Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant