Repository navigation
Hardening: held-out seed guards, local build hygiene, claims matched to evidence - #309
Merged
Merged
Conversation
…anches from the issue id .dockerignore did not exclude .sandcastle/.env, and the Dockerfile ends with COPY . ., so a local build copied the sandbox tokens into a layer. The Sandcastle planner's free-text branch went into shell blocks of the review prompt; it is now built from a numeric issue id. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- EuRoC and TUM VI: replace "Not verified here" with the rights statement and licence the pages already quote; point the README licence section at ADR-0042 and #278, say some files also hold TUM VI rows and no rights-holder answer is recorded. - FAQ: per-frame rows are committed (vo_errors.csv), not only aggregates. - Site footer: the MIT licence is the code's; EuRoC-derived results are non-commercial. - README: PRs through CI are the practice, not an enforced rule; some commits went to main directly and Sandcastle merges its own PRs. - UrbanNav: the gate section no longer names multipath as the measured cause. - urbannav_imposed docstring: it does write a CSV with --csv. - ADR-0010 amendment: the streams-only comparison sentence covers the three vision cases and the two metrics it was read on. No number, table, CSV or golden is changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… pushes The Main ruleset targets refs/heads/Main, so main enforces only deletion and non-fast-forward, and the sandbox token is an admin token. The prompt's guard stays; only the false reason is gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… config seeds are checked - `navkit gate b1` accepted seeds from 125, the ADR-0030 blocks of the candidate gate, without any flag, and `--held-out` accepted any seeds. Both the parser and run_gate now go through b1_gate.check_seeds: development seeds, or exactly the ADR-0028 set with --held-out. - `navkit run --config` used the YAML's own GNSS, vision and camera-drop seeds unchecked when --seed was absent. run_case now refuses held-out configured seeds when no seed replaces them, and navkit run checks every selected case before the first one runs. Test-first. Every new refusal test stops at a monkeypatched sentinel before any run, so a red phase cannot draw a held-out seed. The test that asserted 125-149 is accepted without the flag now asserts the refusal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 7, 2026
Telschow
marked this pull request as ready for review
November 7, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-remediation hardening from the 2026-11-07 review of
bee838d. Part of #250.What changes
Held-out seeds (fix, test-first)
navkit gate b1accepted seeds from 125 (the ADR-0030 blocks of the candidate gate) without a flag, and--held-outaccepted any seeds. The parser andrun_gatenow shareb1_gate.check_seeds: development seeds, or exactly 100 to 124 with--held-out.navkit run --configused a YAML's own stream seeds unchecked when--seedwas absent.run_casenow refuses held-out configured seeds when noseedreplaces them.navkit runchecks every selected case before the first one runs.125-149is accepted now asserts the refusal.Local build and automation hygiene
.dockerignorekeeps.envfiles,node_modulesand the Sandcastle logs and worktrees out of the build context. The Dockerfile ends withCOPY . .. A test checks the patterns.mainrejects its pushes. It doesn't today (see below).Claims that the evidence did not support
vo_errors.csv) are committed, not only aggregates.urbannav_imposeddocstring says it writes a CSV with--csv.No number, table, generated CSV or golden snapshot changes.
Evidence
pytest -n auto, local, macOS, at320e1ec).make docs-fast(763 passed) are clean.Not in this PR (maintainer decisions)
Mainruleset targetsrefs/heads/Main, somainenforces only deletion and non-fast-forward. Repository settings: for the maintainer.CLAUDE.md:31still says the sandbox token cannot push tomain.gate b1 --held-outshould be refused outright now that the set is spent.🤖 Generated with Claude Code