Migrate all tests to native Effect Rstest and enforce native interfaces by BleedingDev · Pull Request #501 · TechsioCZ/ontos

BleedingDev · 2026-09-07T21:14:38Z

Native Rstest and Effect throughout OntOS

Consolidates the migration in #501. #502 is closed. This PR remains open and non-draft; no merge is authorized.

Replace Node test-runner suites and owned Promise runners with Rstest and native effect-rstest APIs. Synchronous tests stay plain it; Effect programs use it.effect, it.live, and it.layer.
Delete runEffectTestPromise, makeEffectTestCallback, and runEffectTestSync. Adapt actual foreign Promise APIs only at their real boundaries; no owned Effect → Promise → Effect round trips or fake native wrappers.
Delete all 27 vendored adapter files. Six consumers use Rstest 0.11.11 and the immutable upstream 79abbf684c7b150ee5f32694129a7caf969903bc canary, with no local package alias.
Carry one focused, temporary 214-line pnpm patch, changing only upstream runtime source and its built entrypoint. Equality, Schema properties, success-value discarding, and scoped lifetime fixes are submitted in ScriptedAlchemy/effect-rstest#4, commit 1026323. Installed patched runtime bytes match that contribution.
TechsioCZ/ontos#507, assigned to the requester, tracks adopting a merged and published upstream package and deleting the patch. Upstream CI/publication still requires maintainer approval. OntOS remains on its existing Effect beta.107 override; the separate Effect/UltraModern upgrade is not folded into this work. Upstream fixes were tested on Effect rc.112.
Enforce native interfaces and import/alias-aware rejection of recognizable Promise round trips, source instanceof, and manual _tag discrimination. Retain exact native-hook provenance, inherited/applied generic Promise ports, assertion payloads, negative controls, and all deployment boundaries.

Cleanup reconciliation and simplification

Merged TechsioCZ/ontos#504 without restoring deleted code or weakening its quality gates. Also retained current main deployment/PostgreSQL 18 updates through abc3a1d3.

Decompose the two native-interface lint rules into focused operations: 16 complexity findings → 0. Independent differential checks preserve all 302 diagnostics across the original 102 fixtures, plus 101 diagnostics across 105 additional edge-case probes. All 208 rule tests pass. This is strong regression evidence, not an exhaustive AST proof.
Remove fixture clones through small, ownership-local helpers—not a new testing framework. Native scoped acquisition reuses the existing Core pool resource; subprocess outputs are collected concurrently; fixture cleanup uses Effect.acquireUseRelease.
Model real Rstest, compiler, and lint-plugin consumers for Knip instead of adding ignores. Preserve compile-time assertions without exporting unused test-only API.
Preserve the deduplicated Shell layout. Add 19 resource interaction cases using the real browser runtime, including disabled, pending, double-click, success, typed failure, and retry states. The alleged delayed-pending behavior was refuted: all 19 cases also pass against the original component. The small adjustment aligns runtime ownership with sibling controls; it is not presented as a demonstrated timing fix.
Every blocking quality category is zero: Knip, token clones, strict clones, and control-flow health. Semantic similarity remains explicitly advisory. Primary-checkout analysis initially rejected ignored generated remnants of deleted packages; these were inspected and preserved outside the active workspace, not hidden through exclusions.

Parallelism and resource ownership

Rstest native N−1 workers throughout; no Core single-worker override. Local stress uses nine workers, with no random-order proof claimed.
Playwright fully parallel, N−1 workers, zero retries. Workers own UUID-isolated identities and exact authorization relationships. Effect owns acquisition deadlines and finalizers, while real database/authorization deadlines stay enabled.
Browser tests use observable hydration/portal readiness. Native route models compose with actual runtime Fibers, typed failures, AbortSignal propagation, and interruption/finalizer assertions.
Party fixture mutation and readback remain tenant/entity-qualified, with witness rows protecting the other fixture tenant.
Adapter finalizers settle before subsequent sequential tests and suite release. Native afterEach runs earlier and is outside that guarantee; infinite uninterruptible finalizers may hold completion. Suite teardown retains its hook timeout. No process-kill-safe or universal bounded-cleanup guarantee is claimed.

Current checkpoint and diff

Pushed head: dfe49e6d7c32d39aaa03d62902c77c4aa6037bca. GitHub reports it mergeable with current main. Working tree is clean.

Package adoption alone: +604 / −2,663 = net −2,059 lines.
Full reconciled PR against current main, explicit Myers diff: +48,737 / −42,537 = net +6,200 lines, 393 files. This includes migration, native-interface rules/regressions, and reconciliation—not just the adapter.

Local validation

Full pnpm check passes, including formatting, rule types/tests, zero repository lint errors, Effect-aware application typechecking, architecture/contracts, readiness, and the zero-blocker quality gate.
Combined cleanup tree: 1,505 non-service tests passed, zero skips: 1,065 unit/component + 316 scripts + 124 generators. 64 service integration tests passed. All 208 lint-rule tests also passed.
After the latest eight-file main update: full pnpm check, 316 scripts, 124 generators, and the deployment regression were rerun successfully.
Authenticated browsers on the final tree: 13/13 in 7.6s, nine workers, zero retries; the prior combined-tree run also passed 13/13 in 21.5s. The final run reused parent-owned review servers; server reuse is not a retry or lower-concurrency override.
Installed-package smoke tests cover equality/native fallback, tuple/record Schema properties, and discarded hostile success values. Separate subprocess probes cover layer setup interruption and test-finalizer ordering.
Historical adoption integration had three outbox matching/claim failures with zero deliveries. Their cause remains unconfirmed. Repeated complete/in-file runs passed; new matcher-batch diagnostics retain evidence for recurrence. No speculative global cleanup, serialization, or product-isolation rewrite was added.

Migration delivered; all CI passed; final review pending

The previous checkpoint 46c7bfa6 passed all 19 workspace gates and artifact proofs plus Quality Audit: 20 substantive checks green, including fresh-service integrations and authenticated parallel zero-retry browsers. These are prior-head results, not claimed as CI validation of the newer fixes.
Previous-head workspace gates and Quality Audit both passed at 06d58ee4: all 20 substantive checks green, including both artifact proofs and fresh-service integration; authenticated browsers passed 13/13 using three N−1 workers, zero retries. Stage deployment was intentionally skipped.
Codex's two final-checkpoint findings are fixed in separate commits: ddaa97c0 models static Rstest project environments with pinned-Knip differential controls; 06d58ee4 resolves proven asymmetric expected-value matchers. Both threads are answered and resolved: all 20 existing review threads are resolved. The subsequent expect.not finding is fixed in dfe49e6d: one net implementation line with ten failing-before positive cases and negative controls. All 21 existing threads are answered and resolved. Full local pnpm check passes on the new head. Its final CI passed all 20 substantive checks; final Codex review is still pending. No final-head review approval is claimed yet.
The model omission was real, but the alleged actual repository unused-dependency failure did not reproduce. Its new tests fail before the fix, and retain an adjacent unused dependency as a negative control. The tag rule adds 23 regression diagnostics with all 158 previous manual-tag diagnostics unchanged; shadowed, mutated and foreign helper controls stay silent.
Current-head workspace gates and Quality Audit both passed on exact head dfe49e6d: all 20 substantive checks green, including both artifact proofs, fresh-service integrations, and authenticated browsers 13/13 using three N−1 workers, zero retries. No stage deployment occurred. No additional broad implementation or cleanup is planned.
After fixing seven new fixture lint findings, current-head full pnpm check passes, with all 208 rule tests and every blocking audit category at zero. 318 script tests passed at nine workers; the edited model suite was rerun afterward and passed 8/8.
Independent Opus 5 High and Sonnet 5 Medium browser reviews completed in separate named sessions. EN/CS authentication, guarded resources, and narrow/mobile layouts were exercised. Ready media-attachment behavior has component evidence only; no unreachable browser state is claimed covered.
Parent verification in a single stable Chromium process refuted the reported stuck-menu behavior: listbox keyboard highlighting, Escape and outside-click dismissal all work, including the account menu. Reviewer browser-process restarts make intermittent session-loss reports inconclusive.
A real current-app limitation was reproduced: Czech /cs/hledat and /cs/zdroje/... throw active-route-match invariants. Search source, both localized metadata files, generated metadata, framework config and router package/patch blocks are unchanged from main; the Resource loader hook is also unchanged. This is not established as a migration regression, and a full separate-main browser baseline was not run. Reproduction was shared with the Effect/UltraModern upgrade owner rather than expanding this PR into unrelated locale work. No blanket UI approval is claimed.
The synthetic review fixture finalized normally, its credential file was removed, and both owned review servers were stopped.
Earlier Fable review attempts exhausted quota and produced no approval. CodeRabbit's success status is not substantive approval when it skips the oversized PR. Stage deployment is intentionally not run for this PR.

Upstream contribution local gates passed: 51 runtime tests / five intentional skips, 11 type tests / 15 assertions, typecheck, build, and strict publint. Baseline-before-fix regression probes fail as expected. Those results do not claim upstream CI approval or publication.

No PR merge is authorized.

🤖 Generated with Claude Code

semanticdiff-com · 2026-09-07T21:14:41Z

Review changes with

chatgpt-codex-connector · 2026-09-07T21:14:52Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-08T16:26:43.535944Z	`dfe49e6`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-09-07T21:14:53Z

Important

Review skipped

Too many files!

This PR contains 392 files, which is 292 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

Usage-priced reviews support at most 300 files.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 64e3b550-85e4-41e0-bb08-74be04280b3e

📥 Commits

Reviewing files that changed from the base of the PR and between abc3a1d and dfe49e6.

⛔ Files ignored due to path filters (1)

app/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (392)

.github/workflows/ultramodern-workspace-gates.yml
app/apps/shell-super-app/api/auth/service.ts
app/apps/shell-super-app/api/modules/installed-module-catalog.ts
app/apps/shell-super-app/package.json
app/apps/shell-super-app/playwright.config.ts
app/apps/shell-super-app/rstest.config.ts
app/apps/shell-super-app/src/routes/[lang]/login/page.tsx
app/apps/shell-super-app/src/routes/[lang]/modules/[moduleId]/page.data.ts
app/apps/shell-super-app/src/routes/[lang]/modules/[moduleId]/page.tsx
app/apps/shell-super-app/src/routes/[lang]/page.data.ts
app/apps/shell-super-app/src/routes/[lang]/resources/[moduleId]/[resourceType]/[resourceId]/page.data.ts
app/apps/shell-super-app/src/routes/[lang]/resources/[moduleId]/[resourceType]/[resourceId]/page.tsx
app/apps/shell-super-app/src/routes/[lang]/search/page.data.ts
app/apps/shell-super-app/src/routes/use-shell-controls.ts
app/apps/shell-super-app/src/runtime/browser-effect-runtime.ts
app/apps/shell-super-app/tests/e2e/auth-fixture.ts
app/apps/shell-super-app/tests/e2e/login.spec.ts
app/apps/shell-super-app/tests/e2e/worker-fixture-lifetime.spec.ts
app/apps/shell-super-app/tests/integration/auth-runtime.test.ts
app/apps/shell-super-app/tests/integration/generated-owner-fixture.ts
app/apps/shell-super-app/tests/integration/generated-owner-isolation.test.ts
app/apps/shell-super-app/tests/integration/identity-modes-runtime.test.ts
app/apps/shell-super-app/tests/integration/module-catalog-runtime.test.ts
app/apps/shell-super-app/tests/integration/module-federation-i18n-runtime.test.ts
app/apps/shell-super-app/tests/integration/stage-demo-bootstrap.test.ts
app/apps/shell-super-app/tests/support/impersonation-service-doubles.ts
app/apps/shell-super-app/tests/unit/api-index.test.ts
app/apps/shell-super-app/tests/unit/auth-boundary.test.ts
app/apps/shell-super-app/tests/unit/auth-config.test.ts
app/apps/shell-super-app/tests/unit/auth-contract.test.ts
app/apps/shell-super-app/tests/unit/auth-db-client.test.ts
app/apps/shell-super-app/tests/unit/auth-schema.test.ts
app/apps/shell-super-app/tests/unit/browser-effect-runtime.test.ts
app/apps/shell-super-app/tests/unit/configuration-provider.test.ts
app/apps/shell-super-app/tests/unit/deployment-allowlist.test.ts
app/apps/shell-super-app/tests/unit/gateway-issuer.test.ts
app/apps/shell-super-app/tests/unit/identity-lifecycle.test.ts
app/apps/shell-super-app/tests/unit/impersonation-service.test.ts
app/apps/shell-super-app/tests/unit/installed-module-catalog.test.ts
app/apps/shell-super-app/tests/unit/installed-outbox-matcher.test.ts
app/apps/shell-super-app/tests/unit/installed-verticals.test.ts
app/apps/shell-super-app/tests/unit/layout.test.tsx
app/apps/shell-super-app/tests/unit/legal-entity-selection.test.ts
app/apps/shell-super-app/tests/unit/module-entrypoint-loader.test.ts
app/apps/shell-super-app/tests/unit/routes/authenticated-shell-fixture.ts
app/apps/shell-super-app/tests/unit/routes/home/loader.test.ts
app/apps/shell-super-app/tests/unit/routes/home/page.test.tsx
app/apps/shell-super-app/tests/unit/routes/login/locales.test.ts
app/apps/shell-super-app/tests/unit/routes/login/page.test.tsx
app/apps/shell-super-app/tests/unit/routes/modules/loader.test.ts
app/apps/shell-super-app/tests/unit/routes/modules/page.test.tsx
app/apps/shell-super-app/tests/unit/routes/resources/page.test.tsx
app/apps/shell-super-app/tests/unit/shell-composition.test.ts
app/apps/shell-super-app/tests/unit/shell-governed-read-schemas.test.ts
app/apps/shell-super-app/tests/unit/shell-resources.test.ts
app/apps/shell-super-app/tests/unit/stage-demo-bootstrap.test.ts
app/docs/architecture/EFFECT_V4_ANTIPATTERN_AUDIT.md
app/docs/architecture/EFFECT_V4_LINT_ENFORCEMENT.md
app/oxlint.config.ts
app/package.json
app/packages/core-runtime/package.json
app/packages/core-runtime/rstest.config.ts
app/packages/core-runtime/src/actions/repository.ts
app/packages/core-runtime/src/outbox/runtime.ts
app/packages/core-runtime/src/testing/actions.ts
app/packages/core-runtime/src/testing/effect-runtime.ts
app/packages/core-runtime/src/testing/live-operations.ts
app/packages/core-runtime/tests/integration/action-permission.test.ts
app/packages/core-runtime/tests/integration/action-runtime.test.ts
app/packages/core-runtime/tests/integration/contacts-identity-migration.test.ts
app/packages/core-runtime/tests/integration/context-access.test.ts
app/packages/core-runtime/tests/integration/identity-runtime.test.ts
app/packages/core-runtime/tests/integration/legal-entity-context.test.ts
app/packages/core-runtime/tests/integration/module-state-gate.test.ts
app/packages/core-runtime/tests/integration/outbox-runtime.test.ts
app/packages/core-runtime/tests/integration/pool-deadlines.test.ts
app/packages/core-runtime/tests/integration/principal-management.test.ts
app/packages/core-runtime/tests/integration/principal-resolver.test.ts
app/packages/core-runtime/tests/integration/read-runtime.test.ts
app/packages/core-runtime/tests/integration/search-persistence.test.ts
app/packages/core-runtime/tests/integration/search-worker-snapshot.test.ts
app/packages/core-runtime/tests/integration/tenant-isolation.test.ts
app/packages/core-runtime/tests/integration/tenant-module-state.test.ts
app/packages/core-runtime/tests/support/database.ts
app/packages/core-runtime/tests/support/effect-runtime.ts
app/packages/core-runtime/tests/unit/action-authorization-rollout.test.ts
app/packages/core-runtime/tests/unit/action-collector.test.ts
app/packages/core-runtime/tests/unit/action-definition.test.ts
app/packages/core-runtime/tests/unit/action-errors.test.ts
app/packages/core-runtime/tests/unit/action-http-runner.test.ts
app/packages/core-runtime/tests/unit/action-identity.test.ts
app/packages/core-runtime/tests/unit/action-permission.test.ts
app/packages/core-runtime/tests/unit/action-policy.test.ts
app/packages/core-runtime/tests/unit/action-public-surface.test.ts
app/packages/core-runtime/tests/unit/action-runtime.test.ts
app/packages/core-runtime/tests/unit/action-testing-harness.test.ts
app/packages/core-runtime/tests/unit/application-composition.test.ts
app/packages/core-runtime/tests/unit/catalog-contract.test.ts
app/packages/core-runtime/tests/unit/commit-recovery-metadata.test.ts
app/packages/core-runtime/tests/unit/config.test.ts
app/packages/core-runtime/tests/unit/context-access.test.ts
app/packages/core-runtime/tests/unit/database-driver-failure.test.ts
app/packages/core-runtime/tests/unit/entrypoint-classification.test.ts
app/packages/core-runtime/tests/unit/fixture-cleanup.test.ts
app/packages/core-runtime/tests/unit/governed-read-http.test.ts
app/packages/core-runtime/tests/unit/http-principal-authentication.test.ts
app/packages/core-runtime/tests/unit/legal-entity-context.test.ts
app/packages/core-runtime/tests/unit/module-catalog.test.ts
app/packages/core-runtime/tests/unit/module-manifest.test.ts
app/packages/core-runtime/tests/unit/module-state-gate.test.ts
app/packages/core-runtime/tests/unit/native-transaction-context.test.ts
app/packages/core-runtime/tests/unit/native-transaction.test.ts
app/packages/core-runtime/tests/unit/operation-context.test.ts
app/packages/core-runtime/tests/unit/outbox-definition.test.ts
app/packages/core-runtime/tests/unit/outbox-errors.test.ts
app/packages/core-runtime/tests/unit/outbox-health.test.ts
app/packages/core-runtime/tests/unit/outbox-poller.test.ts
app/packages/core-runtime/tests/unit/outbox-process.test.ts
app/packages/core-runtime/tests/unit/outbox-runtime.test.ts
app/packages/core-runtime/tests/unit/permission-client.test.ts
app/packages/core-runtime/tests/unit/pool-configuration.test.ts
app/packages/core-runtime/tests/unit/principal-management.test.ts
app/packages/core-runtime/tests/unit/principal-resolver.test.ts
app/packages/core-runtime/tests/unit/read-definition.test.ts
app/packages/core-runtime/tests/unit/read-runtime.test.ts
app/packages/core-runtime/tests/unit/schema-contract.test.ts
app/packages/core-runtime/tests/unit/scoped-transaction.test.ts
app/packages/core-runtime/tests/unit/search-ingestion.test.ts
app/packages/core-runtime/tests/unit/search-projection.test.ts
app/packages/core-runtime/tests/unit/search-schema.test.ts
app/packages/core-runtime/tests/unit/search-worker-snapshot.test.ts
app/packages/core-runtime/tests/unit/service-public-surface.test.ts
app/packages/core-runtime/tests/unit/shell-contribution.test.ts
app/packages/core-runtime/tests/unit/spicedb-client.test.ts
app/packages/core-runtime/tests/unit/spicedb-database-bootstrap.test.ts
app/packages/core-runtime/tests/unit/stage-context-bootstrap.test.ts
app/packages/core-runtime/tests/unit/system-principal-context.test.ts
app/packages/core-runtime/tests/unit/tenant-module-state.test.ts
app/packages/gateway-principal-verifier/package.json
app/packages/gateway-principal-verifier/rstest.config.ts
app/packages/gateway-principal-verifier/tests/unit/gateway-principal-verifier.test.ts
app/packages/shared-contracts/package.json
app/packages/shared-contracts/rstest.config.ts
app/packages/shared-contracts/src/operation-gateway.type-test.ts
app/packages/shared-contracts/tests/unit/client-runtime.test.ts
app/packages/shared-contracts/tests/unit/effect-bff-runtime.test.ts
app/packages/shared-contracts/tests/unit/gateway-context.test.ts
app/packages/shared-contracts/tests/unit/governed-runtime.test.ts
app/packages/shared-contracts/tests/unit/microvertical-api-baseline.test.ts
app/packages/shared-contracts/tests/unit/operation-gateway.test.ts
app/packages/shared-contracts/tests/unit/problem-details.test.ts
app/packages/shared-contracts/tests/unit/ultramodern-build.test.ts
app/patches/@bleedingdev__modern-js-app-tools@3.8.2-ultramodern.12.patch
app/patches/@bleedingdev__modern-js-create@3.8.2-ultramodern.12.patch
app/patches/effect-rstest@0.1.0.patch
app/pnpm-workspace.yaml
app/quality-audit/knip-model.mts
app/quality-audit/knip-runtime-model.mts
app/rstest.config.ts
app/scripts/audit-database-trust-boundaries.mts
app/scripts/check-database-access-boundaries.mts
app/scripts/check-ontos-module-contracts.mts
app/scripts/database-trust-audit/collect-snapshot.mts
app/scripts/database-trust-audit/report.mts
app/scripts/generate-ontos-module-contract.mts
app/scripts/initialize-local-development.mts
app/scripts/local-environment-values.test.mts
app/scripts/migrate-contacts-authorization.mts
app/scripts/prepare-dev-module-contract.mts
app/scripts/proof-workerd-ssr.mts
app/scripts/provision-current-action-authorization.mts
app/scripts/quality-audit.mts
app/scripts/scaffolding/cli.mts
app/scripts/scaffolding/generator-adapter.mts
app/scripts/scaffolding/microvertical-page/scaffold.mts
app/scripts/scaffolding/policy/scaffold.mts
app/scripts/scaffolding/shared.mts
app/scripts/scaffolding/tests/fixture-files.mts
app/scripts/scaffolding/tests/fixture-ownership.mts
app/scripts/scaffolding/tests/module-contract-generator.test.mts
app/scripts/scaffolding/tests/resource-generator.test.mts
app/scripts/scaffolding/tests/retire-contribution.test.mts
app/scripts/scaffolding/tests/scaffold-generators.test.mts
app/scripts/tests/api-only-tooling.test.mts
app/scripts/tests/audit-database-trust-boundaries.test.mts
app/scripts/tests/authorization-rollout-contract.test.mts
app/scripts/tests/boundary-source-structure.test.mts
app/scripts/tests/check-authorization-readiness.test.mts
app/scripts/tests/code-tools-i18n.test.mts
app/scripts/tests/database-access-boundaries.test.mts
app/scripts/tests/dependency-declarations.test.mts
app/scripts/tests/effect-rstest-package.test.mts
app/scripts/tests/generated-slot-entries.test.mts
app/scripts/tests/initialize-local-development.test.mts
app/scripts/tests/locki-feature.test.mts
app/scripts/tests/migrate-contacts-authorization.test.mts
app/scripts/tests/module-entrypoint-boundaries.test.mts
app/scripts/tests/outbox-worker-delivery.test.mts
app/scripts/tests/plan-deployment-impact.test.mts
app/scripts/tests/protected-entrypoint-inventory.test.mts
app/scripts/tests/provision-current-action-authorization.test.mts
app/scripts/tests/quality-audit-count-domain.test.mts
app/scripts/tests/quality-audit-gate.test.mts
app/scripts/tests/quality-audit-model.test.mts
app/scripts/tests/quality-audit-runtime-model.test.mts
app/scripts/tests/quality-audit-test-support.mts
app/scripts/tests/quality-audit.test.mts
app/scripts/tests/quality-cli-lifecycle.test.mts
app/scripts/tests/report-fail-closed-authorization-impact.test.mts
app/scripts/tests/root-environment.test.mts
app/scripts/tests/tooling-process-fixture.mts
app/scripts/tests/typecheck-project-references.test.mts
app/scripts/tests/ultramodern-command.test.mts
app/scripts/validate-ultramodern-workspace.mts
app/tools/oxlint/effect-native/README.md
app/tools/oxlint/effect-native/index.ts
app/tools/oxlint/effect-native/repository-policy.config.ts
app/tools/oxlint/effect-native/rules/no-effect-run-in-tests.ts
app/tools/oxlint/effect-native/rules/no-instanceof.ts
app/tools/oxlint/effect-native/rules/no-manual-tag-comparison.ts
app/tools/oxlint/effect-native/rules/no-promise-shaped-port.ts
app/tools/oxlint/effect-native/shared/no-promise-port-types.ts
app/tools/oxlint/effect-native/shared/test-restricted-imports.ts
app/tools/oxlint/effect-native/tests/discover-rules.test.mts
app/tools/oxlint/effect-native/tests/fixtures.test.mts
app/tools/oxlint/effect-native/tests/fixtures/no-effect-run-in-tests/invalid/effect-client.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-effect-run-in-tests/invalid/tests/harness/it-layer.ts
app/tools/oxlint/effect-native/tests/fixtures/no-effect-run-in-tests/invalid/tests/support/effect-harness.ts
app/tools/oxlint/effect-native/tests/fixtures/no-effect-run-in-tests/invalid/tests/support/it-effect.mts
app/tools/oxlint/effect-native/tests/fixtures/no-effect-run-in-tests/valid/effect-client.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-effect-run-in-tests/valid/harness-usage.test.tsx
app/tools/oxlint/effect-native/tests/fixtures/no-effect-run-in-tests/valid/tests/harness/it-layer.ts
app/tools/oxlint/effect-native/tests/fixtures/no-effect-run-in-tests/valid/tests/support/effect-harness.ts
app/tools/oxlint/effect-native/tests/fixtures/no-instanceof/.oxlintrc.json
app/tools/oxlint/effect-native/tests/fixtures/no-instanceof/invalid/scripts/every-constructor.mts
app/tools/oxlint/effect-native/tests/fixtures/no-instanceof/valid/scripts/native-guards.mts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/.oxlintrc.json
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/apps/property-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/apps/property-options/configured-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/src/configured-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/src/destructured-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/src/expected-wrappers.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/src/negated-expected-wrappers.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/src/object-equality-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/src/partial-object-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/src/runtime.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/src/stable-expected-wrappers.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/src/tag-identity.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/core-runtime/tests/unit/assertions.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/invalid/packages/shared-contracts/src/switch.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/apps/error-combinators-disabled/property-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/apps/property-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/apps/property-options/configured-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/core-runtime/src/adt.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/core-runtime/src/configured-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/core-runtime/src/destructured-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/core-runtime/src/expected-wrappers.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/core-runtime/src/mutated-expected-wrappers.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/core-runtime/src/mutated-negated-wrappers.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/core-runtime/src/native-assertions.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/core-runtime/src/negated-expected-wrappers.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/shared-contracts/src/edge-lookalikes.ts
app/tools/oxlint/effect-native/tests/fixtures/no-manual-tag-comparison/valid/packages/shared-contracts/src/indirect-lookalikes.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/e2e/playwright-dynamic-extend.spec.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/e2e/playwright-extend-owned-service.spec.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/e2e/playwright-fake-factory.spec.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/e2e/playwright-mutable-extend.spec.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/e2e/playwright-shadowed.spec.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/e2e/rstest-extend.spec.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/unit/async-test-callback.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/unit/describe-wrapped-test-callback.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/unit/effect-rstest-hook-provenance.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/unit/inferred-promise-callback.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/apps/shell-super-app/tests/unit/layer-test-callback.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/packages/core-runtime/src/db/evasion-then-built-store.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/packages/core-runtime/src/edge-callback-parameters.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/packages/core-runtime/src/generic-interface-heritage.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/packages/core-runtime/src/generic-operation-ports.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/packages/core-runtime/src/unused-recursive-operation.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/packages/core-runtime/tests/unit/store.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/packages/core-runtime/tests/unit/test-local-ports.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/packages/example/tests/promise-round-trip.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/scripts/overloaded-operation.mts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/tools/example/tests/async-tooling.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/verticals/contacts/src/routes/edge-generic-jsx.tsx
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/invalid/verticals/contacts/src/routes/page.tsx
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/apps/shell-super-app/api/modules/fp-third-party-sdk-mirror.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/apps/shell-super-app/tests/unit/async-test-boundaries.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/apps/shell-super-app/tests/unit/describe-wrapped-test-callback.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/apps/shell-super-app/tests/unit/effect-rstest-hooks.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/apps/shell-super-app/tests/unit/playwright-extended.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/packages/core-runtime/src/db/driver-edge.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/packages/core-runtime/src/generic-effect-ports.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/packages/core-runtime/src/generic-interface-heritage.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/packages/example/tests/promise-round-trip.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/tools/example/tests/synchronous-tooling.test.ts
app/tools/oxlint/effect-native/tests/fixtures/no-promise-shaped-port/valid/verticals/contacts/src/effect-native-service.ts
app/tools/oxlint/effect-native/tests/json-rule-scope.test.mts
app/tools/oxlint/effect-native/tests/launcher.test.mts
app/tools/oxlint/effect-native/tests/oxlint.mts
app/tools/oxlint/effect-native/tests/oxlint.test.mts
app/tools/oxlint/effect-native/tests/paths.test.mts
app/tools/oxlint/effect-native/tests/production-options.test.mts
app/tools/oxlint/effect-native/tests/registration.test.mts
app/tools/oxlint/effect-native/tests/repository-policy.test.mts
app/tools/oxlint/effect-native/tests/rule-file-policy.test.mts
app/tools/oxlint/effect-native/tests/scaffold-text-unicode.test.mts
app/tools/oxlint/effect-native/tests/scaffold-unicode.test.mts
app/tools/oxlint/effect-native/tests/script-scope.test.mts
app/tools/oxlint/effect-native/tests/shared-helpers-probe.ts
app/tools/oxlint/effect-native/tests/shared-helpers.test.mts
app/tools/oxlint/effect-native/tests/source-rule-scope.test.mts
app/tools/oxlint/effect-native/tests/temporary-workspace.mts
app/tools/oxlint/effect-native/tests/temporary-workspace.test.mts
app/verticals/party-registry/package.json
app/verticals/party-registry/rstest.config.ts
app/verticals/party-registry/scripts/prepare-contacts-migration.mts
app/verticals/party-registry/tests/components/contacts-page.test.tsx
app/verticals/party-registry/tests/integration/ares-governed.test.ts
app/verticals/party-registry/tests/integration/database-boundary.test.ts
app/verticals/party-registry/tests/integration/engagement-database-boundary.test.ts
app/verticals/party-registry/tests/integration/governed-identity.test.ts
app/verticals/party-registry/tests/integration/identity-concurrency.test.ts
app/verticals/party-registry/tests/support/database-boundary.ts
app/verticals/party-registry/tests/unit/api-integration-ares-application.test.ts
app/verticals/party-registry/tests/unit/api-integration-client-url.test.ts
app/verticals/party-registry/tests/unit/api-integration-command-client.test.ts
app/verticals/party-registry/tests/unit/api-integration-command-contract.test.ts
app/verticals/party-registry/tests/unit/api-integration-command-recovery.test.ts
app/verticals/party-registry/tests/unit/api-integration-command-runtime.test.ts
app/verticals/party-registry/tests/unit/api-integration-contract.test.ts
app/verticals/party-registry/tests/unit/api-integration-correction-client.test.ts
app/verticals/party-registry/tests/unit/api-integration-runtime.test.ts
app/verticals/party-registry/tests/unit/ares-application-policy.test.ts
app/verticals/party-registry/tests/unit/ares-evidence-contract.test.ts
app/verticals/party-registry/tests/unit/ares-lookup-read.test.ts
app/verticals/party-registry/tests/unit/ares-subject.service.test.ts
app/verticals/party-registry/tests/unit/attach-engagement-handler.test.ts
app/verticals/party-registry/tests/unit/audit-evidence-contract.test.ts
app/verticals/party-registry/tests/unit/catalog-contract.test.ts
app/verticals/party-registry/tests/unit/contact-point-contract.test.ts
app/verticals/party-registry/tests/unit/contact-point-correction-action.test.ts
app/verticals/party-registry/tests/unit/contact-point-persistence.service.test.ts
app/verticals/party-registry/tests/unit/correction-contract.test.ts
app/verticals/party-registry/tests/unit/cors-origin.test.ts
app/verticals/party-registry/tests/unit/counterparty-contract.test.ts
app/verticals/party-registry/tests/unit/counterparty-persistence.service.test.ts
app/verticals/party-registry/tests/unit/counterparty-read-support.test.ts
app/verticals/party-registry/tests/unit/counterparty-role-lifecycle.test.ts
app/verticals/party-registry/tests/unit/database-client.test.ts
app/verticals/party-registry/tests/unit/engagement-catalog-contract.test.ts
app/verticals/party-registry/tests/unit/engagement-lifecycle-handler.test.ts
app/verticals/party-registry/tests/unit/engagement-lifecycle-registration.test.ts
app/verticals/party-registry/tests/unit/engagement-profile-api-contract.test.ts
app/verticals/party-registry/tests/unit/engagement-profile-persistence-service.test.ts
app/verticals/party-registry/tests/unit/engagement-reference-validation.test.ts
app/verticals/party-registry/tests/unit/engagement-schema-contract.test.ts
app/verticals/party-registry/tests/unit/gateway-assertion-redemption-runtime.test.ts
app/verticals/party-registry/tests/unit/identifier-contract.test.ts
app/verticals/party-registry/tests/unit/identifier-persistence.service.test.ts
app/verticals/party-registry/tests/unit/identifier-update-outbox.test.ts
app/verticals/party-registry/tests/unit/identity-action-evidence.test.ts
app/verticals/party-registry/tests/unit/identity-contract.test.ts
app/verticals/party-registry/tests/unit/identity-create-without-strong-identifier.test.ts
app/verticals/party-registry/tests/unit/identity-party-detail-alias.test.ts
app/verticals/party-registry/tests/unit/identity-party-detail-history.test.ts
app/verticals/party-registry/tests/unit/identity-persistence.service.test.ts
app/verticals/party-registry/tests/unit/matching-contract.test.ts
app/verticals/party-registry/tests/unit/matching-persistence.test.ts
app/verticals/party-registry/tests/unit/merge-alias-resolution-service.test.ts
app/verticals/party-registry/tests/unit/merge-alias-resolution.test.ts
app/verticals/party-registry/tests/unit/merge-collision-reference.test.ts
app/verticals/party-registry/tests/unit/merge-readiness-contract.test.ts
app/verticals/party-registry/tests/unit/merge-survivor-selection.test.ts
app/verticals/party-registry/tests/unit/party-search-worker.test.ts
app/verticals/party-registry/tests/unit/prepare-contacts-migration.test.ts
app/verticals/party-registry/tests/unit/read-outcome.test.ts
app/verticals/party-registry/tests/unit/relationship-domain-contract.test.ts
app/verticals/party-registry/tests/unit/relationship-operation-contract.test.ts
app/verticals/party-registry/tests/unit/relationship-persistence.service.test.ts
app/verticals/party-registry/tests/unit/runtime-locales.test.ts
app/verticals/party-registry/tests/unit/schema-contract.test.ts
app/verticals/party-registry/tests/unit/search-contract.test.ts
app/verticals/party-registry/tests/unit/search-core-adapter.test.ts
app/verticals/party-registry/tests/unit/search-identifier-sync.test.ts
app/verticals/party-registry/tests/unit/search-projector.test.ts
app/verticals/party-registry/tests/unit/search-provider.test.ts
app/verticals/party-registry/tests/unit/search-rebuild-request.test.ts
app/verticals/party-registry/tests/unit/search-semantics.test.ts
app/verticals/party-registry/tests/unit/search-source.test.ts
app/verticals/party-registry/tests/unit/search-worker-registration.test.ts
app/verticals/party-registry/tests/unit/timeline-resource-contract.test.ts

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: efdab4e556

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

BleedingDev · 2026-09-07T21:23:41Z

@coderabbitai review

coderabbitai · 2026-09-07T21:24:32Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb7f2918d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

BleedingDev · 2026-09-07T21:30:29Z

Coordination note (Claude, working alongside Codex in this PR):

I am migrating the whole test infrastructure to Rstest + Effect-native tests inside this PR:

new workspace package packages/effect-rstest (@app/effect-rstest, vendored port of @effect/vitest for Rstest) with it.effect / it.live / it.layer;
every node --test suite in packages/*, verticals/*, apps/* becomes an Rstest project; @app/core-runtime/testing/effect-runtime (runEffectTestPromise, makeEffectTestCallback, runEffectTestSync) is deleted, no Promise bridges remain in tests;
package/root scripts and the CI matrix switch to rstest --project unit|integration|component.

I will push in slices on top of this branch head. Please pull before editing files under **/tests/**; if you are mid-edit on a test file, keep the change small and I will rebase around it.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0ca264e244

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…nforcement#locki-2mgdh5s8 # Conflicts: # app/apps/shell-super-app/tests/integration/generated-owner-fixture.ts

BleedingDev · 2026-09-07T21:58:28Z

Coordination update for the shared #501 work: latest head is 02ed2745. All five Codex findings are fixed and resolved. Follow-ups preserve tag-assertion enforcement for both @rstest/core and the upcoming @app/effect-rstest assertion exports, and avoid confusing callback/predicate bodies with compared tag values. The rule and fixture edits are committed; my worktree is clean. Fresh CI and Codex review are running.

I merged latest main (841bd193) without rewriting history. The earlier combined head 0b735d1e passed all 20 CI jobs, and local validation passed format, all 167 rule tests, lint, typecheck, 61 generator tests, 13 shared-contract tests/type assertions, and both generated-owner isolation tests. Subsequent changes affect the tag rule and its regression fixtures only.

I will check incoming Rstest migration commits and handle the next CI/review round. Please build on this head and preserve the regression cases. CodeRabbit cannot review the combined PR under its current file/capacity limit.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b735d1ec9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…Rstest projects Vendor the community port of @effect/vitest for Rstest as a workspace package, define unit/integration/component Rstest projects for every app package, and migrate five pilot suites to it.effect / it.live / it.layer with no Promise bridges. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02ed2745cb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…nforcement#locki-2mgdh5s8 # Conflicts: # app/scripts/scaffolding/tests/scaffold-generators.test.mts # app/verticals/party-registry/tests/unit/api-integration-command-runtime.test.ts

…nforcement#locki-2mgdh5s8 # Conflicts: # app/apps/shell-super-app/tests/unit/auth-contract.test.ts # app/verticals/party-registry/tests/unit/ares-lookup-read.test.ts

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e63db3569f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4bf1565605

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Own authentication identities per worker; bound native acquisition without abandoning scoped cleanup. Wait for the real hydrated account menu before post-reload interaction. Run all browser tests with N-1 workers and no retries locally and in the integration gate. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b0dad1b42

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…cates Reject expected object discriminants in equality and containment matchers, including Node deep assertions. Migrate 59 assertions across 21 suites while preserving exact payload and extra-field checks. Add ten failing provenance-aware matcher regressions and migrate the old positive fixture. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Prevent parallel governed tests from having their customer roles ended by the database-boundary fixture. Also scope delivery-purpose updates/readback and the billing constraint probe. Preserve independent tenant rows with full-row regression snapshots; both defects reproduced within owned tenants before correction and all five Party integrations pass five parallel repeats. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 50c3d45c6a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bdeaf51310

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Adopt the immutable upstream package and remove the owned adapter. Carry the generic conformance fixes from ScriptedAlchemy/effect-rstest#4 in one temporary pnpm patch, tracked for removal by #507. Update actual imports and lint provenance without compatibility aliases or runner wrappers. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Preserve cleanup ownership boundaries and native Effect tests, adopt the patched upstream runner, remove fixture clones, and retain zero blocking quality findings. Add resource interaction coverage and verify lint detector equivalence. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Keep the fully validated cleanup reconciliation tree unchanged while joining the already-published package adoption commit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Preserve native Effect Rstest assertions while adopting the corrected worker hostname, PostgreSQL 18 configuration, deployment flag forwarding, and authorization rollout baseline. Full pnpm check and zero-blocker quality gate pass on the combined tree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46c7bfa688

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Follow exported static project configurations with source evidence and pinned-Knip positive and negative controls. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Resolve framework objectContaining and arrayContaining expected values while preserving lexical identity, mutation guards, ADT exemptions and payload semantics. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

BleedingDev · 2026-09-08T16:07:58Z

@codex review

Please review exact head 06d58ee478271542daad8fe707b9ee5e00033b61. Both findings from the previous review are fixed in separate commits with fail-before/pass-after regressions; both threads are answered and resolved. Full local pnpm check, 208 rule tests, 318 scripts and the pinned-Knip controls pass. Fresh CI is running. Please verify the fixes and report any remaining substantive migration defects. No merge is requested.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 06d58ee478

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Accept one static expect.not modifier without weakening helper provenance or mutation guards. Add ten failing-before positive cases and foreign, shadowed, mutated, payload and unsupported-modifier controls. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

BleedingDev · 2026-09-08T16:20:55Z

@codex review

Please review exact head dfe49e6d7c32d39aaa03d62902c77c4aa6037bca. The expect.not asymmetric-helper finding is fixed with ten failing-before positive regressions plus mutation/provenance/modifier negative controls. All 21 existing threads are answered and resolved. Full local pnpm check passes; fresh CI is running. No merge is requested.

chatgpt-codex-connector · 2026-09-08T16:26:41Z

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: dfe49e6d7c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Use native Effect predicates in runtime and test assertions

bfe3256

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-promise-shaped-port.ts

BleedingDev mentioned this pull request Sep 7, 2026

Use native Effect predicates in runtime and test assertions #502

Closed

Enforce native Effect interfaces and remove generator Promise bridges

bb7f291

BleedingDev force-pushed the codex/effect-native-enforcement#locki-2mgdh5s8 branch from efdab4e to bb7f291 Compare September 7, 2026 21:22

BleedingDev changed the base branch from main to codex/native-effect-predicates September 7, 2026 21:22

BleedingDev changed the base branch from codex/native-effect-predicates to main September 7, 2026 21:27

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-manual-tag-comparison.ts Outdated

BleedingDev added 2 commits September 7, 2026 23:32

Keep foreign SDK callbacks compatible with Effect diagnostics

0ca264e

Close test-local Promise and imported tag assertion bypasses

e7aff4c

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-manual-tag-comparison.ts Outdated

BleedingDev added 2 commits September 7, 2026 23:46

Merge remote-tracking branch 'origin/main' into codex/effect-native-e…

f01183e

…nforcement#locki-2mgdh5s8 # Conflicts: # app/apps/shell-super-app/tests/integration/generated-owner-fixture.ts

Respect tag exemptions in assertion comparisons

0b735d1

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-manual-tag-comparison.ts Outdated

Comment thread app/tools/oxlint/effect-native/rules/no-manual-tag-comparison.ts Outdated

BleedingDev and others added 4 commits September 8, 2026 00:13

Verify assertion imports and honor switch tag exemptions

be56a69

Preserve tag checks through Rstest assertion exports

536d650

Limit assertion tag detection to compared value projections

02ed274

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-promise-shaped-port.ts Outdated

BleedingDev added 3 commits September 8, 2026 00:31

Merge remote-tracking branch 'origin/main' into codex/effect-native-e…

4d92f4f

…nforcement#locki-2mgdh5s8 # Conflicts: # app/scripts/scaffolding/tests/scaffold-generators.test.mts # app/verticals/party-registry/tests/unit/api-integration-command-runtime.test.ts

Resolve Promise-returning generic function aliases at port declarations

095e1ae

Merge remote-tracking branch 'origin/main' into codex/effect-native-e…

e63db35

…nforcement#locki-2mgdh5s8 # Conflicts: # app/apps/shell-super-app/tests/unit/auth-contract.test.ts # app/verticals/party-registry/tests/unit/ares-lookup-read.test.ts

chatgpt-codex-connector Bot reviewed Sep 7, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-promise-shaped-port.ts Outdated

BleedingDev mentioned this pull request Sep 8, 2026

refactor: purge dead code and duplication, enforce quality guardrails #504

Merged

7 tasks done

BleedingDev and others added 2 commits September 8, 2026 11:49

fix(lint): recognize genuine Playwright extended test bindings

2c7a151

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

fix(lint): close destructured and partial tag assertion gaps

4bf1565

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-manual-tag-comparison.ts Outdated

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-promise-shaped-port.ts Outdated

Comment thread app/tools/oxlint/effect-native/rules/no-manual-tag-comparison.ts Outdated

BleedingDev and others added 2 commits September 8, 2026 12:31

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread app/packages/effect-rstest/src/internal/internal.ts Outdated

Comment thread app/tools/oxlint/effect-native/rules/no-promise-shaped-port.ts Outdated

fix(lint): recognize native test hooks and property tag assertions

bdeaf51

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-promise-shaped-port.ts Outdated

BleedingDev and others added 2 commits September 8, 2026 13:01

test(effect-rstest): pin upstream table row semantics

bc46ea0

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

fix(lint): inspect inherited and applied generic Promise ports

a4a6eb5

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

This was referenced Sep 8, 2026

Remove temporary effect-rstest patch after upstream fixes merge #507

Closed

Adopt published UltraModern 3.9.0-ultramodern.4 and native Effect #508

Merged

BleedingDev and others added 4 commits September 8, 2026 15:42

merge: preserve published upstream adapter adoption history

d0c4992

Keep the fully validated cleanup reconciliation tree unchanged while joining the already-published package adoption commit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread app/apps/shell-super-app/rstest.config.ts

Comment thread app/tools/oxlint/effect-native/rules/no-manual-tag-comparison.ts Outdated

BleedingDev and others added 2 commits September 8, 2026 18:06

fix(quality): model native Rstest project environments

ddaa97c

Follow exported static project configurations with source evidence and pinned-Knip positive and negative controls. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

fix(lint): inspect proven asymmetric tag assertions

06d58ee

Resolve framework objectContaining and arrayContaining expected values while preserving lexical identity, mutation guards, ADT exemptions and payload semantics. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

chatgpt-codex-connector Bot reviewed Sep 8, 2026

View reviewed changes

Comment thread app/tools/oxlint/effect-native/rules/no-manual-tag-comparison.ts Outdated

BleedingDev merged commit 084792f into main Sep 8, 2026
21 checks passed

BleedingDev deleted the codex/effect-native-enforcement#locki-2mgdh5s8 branch September 8, 2026 16:27

BleedingDev mentioned this pull request Sep 16, 2026

Deferred: first-party quality rules and agent workflow calibration (preserve TSGo and Ultracite) #867

Open

Conversation

BleedingDev commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Native Rstest and Effect throughout OntOS

Cleanup reconciliation and simplification

Parallelism and resource ownership

Current checkpoint and diff

Local validation

Migration delivered; all CI passed; final review pending

Uh oh!

semanticdiff-com Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

BleedingDev commented Sep 7, 2026

Uh oh!

coderabbitai Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

BleedingDev commented Sep 7, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

BleedingDev commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

BleedingDev commented Sep 7, 2026 •

edited

Loading

semanticdiff-com Bot commented Sep 7, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 7, 2026 •

edited

Loading

coderabbitai Bot commented Sep 7, 2026 •

edited

Loading

coderabbitai Bot commented Sep 7, 2026 •

edited

Loading

BleedingDev commented Sep 7, 2026 •

edited

Loading