Adopt published UltraModern 3.9.0-ultramodern.4 and native Effect - #508
Merged
Merged
Conversation
Preserve merged cleanup while adopting the current framework and Effect cohort. Keep owner boundaries, native tooling and quality gates. Draft checkpoint: framework compatibility publication and end-to-end acceptance remain pending. Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Review changes with |
|
Important Review skippedToo many files! This PR contains 1038 files, which is 938 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1038)
You can disable this status message by setting the |
Remove migration-only sorting disables and formatting overrides. Keep policy decisions in the configured preset. Co-Authored-By: Claude Code <noreply@anthropic.com>
Load rule-only plugin entrypoints and patch Perfectionist's eager utility imports. Keep all six sorting rules and explicit declaration dependencies without installing the ESLint runner. Eight real Oxlint parity controls pass. Co-Authored-By: Claude Code <noreply@anthropic.com>
Keep per-file hoisted state while sharing typed recording and destination resolution. Preserve all route assertions; 32 tests and scoped native lint pass. Co-Authored-By: Claude Code <noreply@anthropic.com>
Preserve the merged strict declaration repair on rc.112, use native reference installation and CLI defaults, and complete Context.Service consumers. Keep profiling through the supported Rsbuild Rsdoctor interface. Full native lint passes across 928 files. Reference, planner, command, search and strict declaration regressions pass; published framework adoption remains pending. Co-Authored-By: Claude Code <noreply@anthropic.com>
Keep existing schema-factory and SDK callback exceptions attached to their exact statements. Use the native object predicate in the Drizzle test seam. Formatting, full lint and focused tests pass together. Co-Authored-By: Claude Code <noreply@anthropic.com>
Isolate preset-produced formatting from functional migration commits. Import, package and Tailwind sorting remain enabled; no custom style overrides or formatter suppressions. Co-Authored-By: Claude Code <noreply@anthropic.com>
Merge main084792fe with no conflicts. Preserve the direct patched effect-rstest integration, current Effect cohort, native service changes, shared localized-link tests and full quality gates. Lefthook2.1.10 is installed and its real local format hook passes with explicitly approved sandbox-scoped read-only Git metadata queries. Co-Authored-By: Claude Code <noreply@anthropic.com>
Complete current-main Effect service, decoder and test integration. Keep narrow Better Auth admin imports and remove the stale root framework version. Checkpoint remaining release-dependent declaration work without disabling type checks. Co-Authored-By: Claude Code <noreply@anthropic.com>
BleedingDev
changed the title
BleedingDev
marked this pull request as ready for review
September 9, 2026 10:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31a5d87c66
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| "tooling": { | ||
| "command": "modern-js-create ultramodern", | ||
| "command": "ultramodern-create ultramodern", |
There was a problem hiding this comment.
The migration changes the workspace tooling executable to ultramodern-create, but app/README.md:51-54 still directs contributors to the removed @modern-js/create package and modern-js-create binary. On a fresh frozen install, following the required MicroVertical scaffolding workflow therefore invokes a command that is no longer declared by this workspace; update the documented package and command to match this configuration.
AGENTS.md reference: app/AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts published UltraModern
3.9.0-ultramodern.4and native Effect APIs. The migration preserves PR #504's cleanup and quality checks, along with the password-reset and session-revocation behavior integrated frommainthroughf4a71149.Application responsibilities remain visible in the file layout:
Canonical route metadata and typed parameters drive native localized navigation:
flowchart LR Route[Canonical resource route + typed params] --> Router[Native localized router] Router --> CS["/cs/zdroje/…"] Router --> EN["/en/resources/…"]The
.4framework release supplies the ESM plugin-loading, CLI declaration, Effect migration, federation, request-scoped SSR, localized-link and hydration repairs used by this migration.Formatting explicitly uses
printWidth: 120andtrailingComma: 'all'. Generated files follow the same configuration, generator reruns preserve existing service layers, and exact contract checks accept an equivalent optional leading union pipe. This removes the migration's accidental 80-column wrapping and function trailing-comma churn.Committed diff at
74a705c3againstmain(f4a71149), measured withgit diff --numstat:The first three browser tests exhausted their 30-second deadlines while the Shell compiled lazy imports in successive batches. The CI configuration now compiles those imports before the dev server starts serving tests:
dev: { assetPrefix: '/', + lazyCompilation: getBuildBoolean('CI') ? false : undefined, }flowchart LR Start[Start CI dev server] --> Compile[Compile Shell imports] Compile --> Ready[Server ready] Ready --> Tests[13 browser tests in parallel]Local development retains its existing lazy-compilation default; production output is unchanged. Browser traces and error contexts are retained for three days after a CI failure. Test deadlines, parallel workers and zero retries are unchanged.
Validation at
74a705c3:pnpm checkAll PR CI gates passed, including the separate quality audit. After merge as
1728c5ba, all main-branch gates passed again, including the browser job and main quality audit. Stage deployment is correctly skipped for a pull request; this change does not claim a stage deployment. CodeRabbit skipped its review because the migration exceeds its file limit.Earlier local acceptance at
dc551e17verified the published 38-package cohort, frozen installation, static checks, 335 script tests, 1,081 unit/component tests and 65 integration tests. Node and workerd production proofs and browser login, reload and localized navigation also passed there. These results are historical evidence, not validation of the current head.Production search/resource gateway transport and authorization integration remain separate follow-up work. The existing unavailable-provider response, HTTP 503, remains visible.